ChanServ changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 14:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
trumae has quit [Ping timeout: 272 seconds]
__DuBPiRaTe__ has quit [Quit: Leaving]
kevkevin has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 252 seconds]
kevkevin has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] AgusR7 opened pull request #31030: test: use context managers and add file existence checks in feature_fee_estimation.py (master...master) https://github.com/bitcoin/bitcoin/pull/31030
<bitcoin-git> [bitcoin] dollarparity opened pull request #31031: doc: clarify 'filename' argument in 'loadwallet' RPC (master...patch-1) https://github.com/bitcoin/bitcoin/pull/31031
PaperSword has quit [Ping timeout: 245 seconds]
PaperSword has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
achow101 has quit [Quit: Bye]
achow101 has joined #bitcoin-core-dev
ion- has quit [Remote host closed the connection]
ion- has joined #bitcoin-core-dev
ion- has quit []
ion- has joined #bitcoin-core-dev
ion- has quit [Remote host closed the connection]
ion- has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
<laanwj> <sipa> "ok, made an /etc/apparmor.d/guix..." <- glad to hear that, i'll remove the suggestion for aa-enforce, just making apparmor reload the configuration should be enough after manually updating it
kevkevin has joined #bitcoin-core-dev
<laanwj> i'm surprised the upstream launchpad issue still has had no attention, on the other hand the apparmor update broke so incredibly many things (every user-space app that used user namespaces), i wonder if they're going to revert this at some point
kevkevin has quit [Ping timeout: 252 seconds]
eval-exec has quit [Quit: eval-exec]
ion- has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
ion- has joined #bitcoin-core-dev
<vasild> jonatack: I vaguely remember, in some of your PRs there was a bogus warning about unused std::optional, but I can't remember which PR or how did you resolve it. I am kind of stuck with this https://cirrus-ci.com/task/4873699256434688?logs=ci#L2010 and I do not know how to resolve or reproduce it locally.
ion- has quit [Ping timeout: 252 seconds]
kevkevin has quit [Ping timeout: 265 seconds]
ion- has joined #bitcoin-core-dev
ion- has quit [Ping timeout: 260 seconds]
ion- has joined #bitcoin-core-dev
eval-exec has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 252 seconds]
eval-exec has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 246 seconds]
Guyver2 has joined #bitcoin-core-dev
___nick___ has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 252 seconds]
kevkevin has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] hebasto pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/f117f3f74738...4be785b3e335
<bitcoin-git> bitcoin/master cb750b4 Hennadii Stepanov: qt6, test: Use `qWarning()` instead of `QWARN()` macro
<bitcoin-git> bitcoin/master 5625840 Hennadii Stepanov: qt6, test: Handle deprecated `QVERIFY_EXCEPTION_THROWN`
<bitcoin-git> bitcoin/master 4be785b Hennadii Stepanov: Merge bitcoin-core/gui#839: qt6, test: Handle deprecated code
<bitcoin-git> [gui] hebasto merged pull request #839: qt6, test: Handle deprecated code (master...240929-qt6-test) https://github.com/bitcoin-core/gui/pull/839
kevkevin has quit [Ping timeout: 272 seconds]
kevkevin has joined #bitcoin-core-dev
jirijakes has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 265 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 276 seconds]
ion- has quit [Remote host closed the connection]
ion- has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
ion- has quit [Ping timeout: 252 seconds]
kevkevin has quit [Ping timeout: 260 seconds]
ion- has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4be785b3e335...51c698161b54
<bitcoin-git> bitcoin/master 5be34ba Hennadii Stepanov: qt: Fix linking when configured with `-DENABLE_WALLET=OFF`
<bitcoin-git> bitcoin/master 51c6981 Hennadii Stepanov: Merge bitcoin-core/gui#837: qt6: Fix linking when configured with `-DENABL...
<bitcoin-git> [gui] hebasto merged pull request #837: qt6: Fix linking when configured with `-DENABLE_WALLET=OFF` (master...240918-wallet-header) https://github.com/bitcoin-core/gui/pull/837
ion- has quit [Ping timeout: 252 seconds]
kevkevin has quit [Ping timeout: 252 seconds]
ion- has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 252 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 260 seconds]
Guyver2 has quit [Quit: Going offline, see ya! (www.adiirc.com)]
kevkevin has joined #bitcoin-core-dev
jirijakes has quit [Ping timeout: 246 seconds]
kevkevin has quit [Ping timeout: 276 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 248 seconds]
ion- has quit [Remote host closed the connection]
<bitcoin-git> [gui] hebasto opened pull request #840: qt6: Handle different signatures of `QANEF::nativeEventFilter` (master...241004-qanef) https://github.com/bitcoin-core/gui/pull/840
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 248 seconds]
ion- has joined #bitcoin-core-dev
ion- has quit [Remote host closed the connection]
ion- has joined #bitcoin-core-dev
ion- has quit [Ping timeout: 244 seconds]
<sipa> vasild: that's pretty strange
kevkevin has joined #bitcoin-core-dev
<vasild> you tell me :) I already tried to push a few tweaks in the hopes to silence it, but it keeps getting upset by that
kevkevin has quit [Ping timeout: 260 seconds]
ion- has joined #bitcoin-core-dev
ion- has quit [Ping timeout: 265 seconds]
kevkevin has joined #bitcoin-core-dev
cygnet3 has joined #bitcoin-core-dev
cygnet3_ has joined #bitcoin-core-dev
cygnet3 has quit [Ping timeout: 272 seconds]
ion- has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
gribble has quit [Read error: Connection reset by peer]
gribble` has joined #bitcoin-core-dev
abubakarsadiq has joined #bitcoin-core-dev
mekster669493981 has quit [Quit: Ping timeout (120 seconds)]
mekster669493981 has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
Lightsword has quit [Ping timeout: 252 seconds]
Lightsword has joined #bitcoin-core-dev
<bitcoin-git> [gui] furszy opened pull request #841: gui: bugfix, decouple WalletModel from RPCExecutor (master...2024_gui_rpconsole_walletmodel_dependency) https://github.com/bitcoin-core/gui/pull/841
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
adil has joined #bitcoin-core-dev
adil has quit [Quit: adil]
brunoerg has quit [Remote host closed the connection]
cold has quit [Ping timeout: 252 seconds]
cold has joined #bitcoin-core-dev
Guyver2_ has joined #bitcoin-core-dev
cman has joined #bitcoin-core-dev
sdaftuar1 has joined #bitcoin-core-dev
Earnest has joined #bitcoin-core-dev
katsu_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
<lightlike> #30544 was a recent similar case, where the optional was just removed as a fix - made sense there, but not here. I wonder what triggers it in these specific spots, optionals are used all over the place after all...
<gribble`> https://github.com/bitcoin/bitcoin/issues/30544 | rpc: fix maybe-uninitialized compile warning in getchaintxstats by mjdietzx · Pull Request #30544 · bitcoin/bitcoin · GitHub
Guyver2 has quit [*.net *.split]
mekster669493981 has quit [*.net *.split]
aleggg has quit [*.net *.split]
katsu has quit [*.net *.split]
conman has quit [*.net *.split]
Earnestly has quit [*.net *.split]
cfields has quit [*.net *.split]
da2ce7 has quit [*.net *.split]
sdaftuar has quit [*.net *.split]
katsu_ is now known as katsu
aleggg has joined #bitcoin-core-dev
da2ce7 has joined #bitcoin-core-dev
<sipa> how do i restart a github-actions job? https://github.com/bitcoin/bitcoin/actions/runs/11182394105/job/31088579369?pr=30605 is due to a spurious (and rare) libsecp256k1 test failure
adil has joined #bitcoin-core-dev
adil has quit [Client Quit]
brunoerg has quit [Remote host closed the connection]
<sipa> i just pushed again
<sipa> laanwj: confirmed. I deleted my /etc/apparmor.d/guix file, rebooted, ran guix-build and got the error. Then I moved the working /etc/apparmor.d/guix file back into place, ran /etc/init.d/apparmor reload, and after that guix-build works.
<sipa> Sjors[m]: ^ may be interesting to you as well
Guyver2_ has left #bitcoin-core-dev [#bitcoin-core-dev]
brunoerg has joined #bitcoin-core-dev
preimage has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
bugs_ has joined #bitcoin-core-dev
ion- has quit [Remote host closed the connection]
ion- has joined #bitcoin-core-dev
ion- has quit [Remote host closed the connection]
ion- has joined #bitcoin-core-dev
ion- has quit [Ping timeout: 246 seconds]
cygnet3_ has quit [Quit: Leaving]
cygnet3 has joined #bitcoin-core-dev
<jonatack> vasild: that error does look odd. i think i vaguely remember that it wasn't our code but an external issue
ion- has joined #bitcoin-core-dev
ion- has quit [Ping timeout: 244 seconds]
<vasild> jonatack: thanks! yes, this is the one!
<vasild> still unresolved and is a valgrind one, not during compilation; I wonder if both are related...
<vasild> lightlike: yes, #30544 seems like the same issue
<gribble`> https://github.com/bitcoin/bitcoin/issues/30544 | rpc: fix maybe-uninitialized compile warning in getchaintxstats by mjdietzx · Pull Request #30544 · bitcoin/bitcoin · GitHub
ion- has joined #bitcoin-core-dev
<vasild> what is even stranger is that the warning is reported on line 2766, but:
<vasild> the Select() call qouted in the warning message is on line 2765
ion- has quit [Ping timeout: 252 seconds]
ion- has joined #bitcoin-core-dev
ion- has quit [Ping timeout: 260 seconds]
Common has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
ion- has joined #bitcoin-core-dev
ion- has quit [Ping timeout: 246 seconds]
brunoerg has quit [Remote host closed the connection]
ion- has joined #bitcoin-core-dev
dac5039 has joined #bitcoin-core-dev
FelixWeis__ has quit [Ping timeout: 248 seconds]
FelixWeis__ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
ion- has quit [Remote host closed the connection]
ion- has joined #bitcoin-core-dev
ion- has quit [Remote host closed the connection]
pablomartin4btc has quit [Ping timeout: 260 seconds]
abubakarsadiq has quit [Quit: Connection closed for inactivity]
mudsip has joined #bitcoin-core-dev
mudsip has quit [Client Quit]
ion- has joined #bitcoin-core-dev
Common has quit [Read error: Connection reset by peer]
Common has joined #bitcoin-core-dev
ion- has quit [Ping timeout: 245 seconds]
dac5039 has quit [Quit: Client closed]
ion- has joined #bitcoin-core-dev
ion- has quit [Ping timeout: 252 seconds]
ion- has joined #bitcoin-core-dev
ion- has quit [Ping timeout: 255 seconds]
abubakarsadiq has joined #bitcoin-core-dev
trumae has joined #bitcoin-core-dev
trumae has quit [Read error: Connection reset by peer]
ion- has joined #bitcoin-core-dev
___nick___ has quit [Ping timeout: 246 seconds]
jirijakes has joined #bitcoin-core-dev
andrewtoth has quit [Remote host closed the connection]
bugs_ has quit [Quit: Leaving]
Talkless has joined #bitcoin-core-dev
achow101 has quit [Ping timeout: 272 seconds]
achow101 has joined #bitcoin-core-dev
achow101 has quit [Ping timeout: 260 seconds]
achow101 has joined #bitcoin-core-dev
achow101 has quit [Ping timeout: 248 seconds]
achow101 has joined #bitcoin-core-dev
achow101_ has joined #bitcoin-core-dev
achow101 has quit [Ping timeout: 272 seconds]
achow101_ is now known as achow101
<bitcoin-git> [bitcoincore.org] glozow pushed 5 commits to master: https://github.com/bitcoin-core/bitcoincore.org/compare/832981b9a79c...66cfd9d864ef
<bitcoin-git> bitcoincore.org/master 7cfeff1 Ava Chow: Remove powerpc64le binaries from downloads
<bitcoin-git> bitcoincore.org/master b4639ef Ava Chow: Bitcoin Core 28.0
<bitcoin-git> bitcoincore.org/master 43057e2 Ava Chow: Update maintenance table after 28.0
<bitcoin-git> [bitcoincore.org] glozow merged pull request #1067: Bitcoin Core 28.0 (master...28.0-rel) https://github.com/bitcoin-core/bitcoincore.org/pull/1067
Common has quit [Read error: Connection reset by peer]
Common has joined #bitcoin-core-dev
Talkless has quit [Remote host closed the connection]
kevkevin has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
preimage has quit [Quit: WeeChat 4.4.2]
kevkevin has quit [Ping timeout: 260 seconds]
twistedline has quit []
<bitcoin-git> [bitcoin] achow101 opened pull request #31034: [28.x] doc: Sync 28.0 release notes with website (28.x...28.0-relnotes-sync) https://github.com/bitcoin/bitcoin/pull/31034
<bitcoin-git> [bitcoin] achow101 opened pull request #31035: doc: Archive 28.0 release notes (master...28.0-relnotes-archive) https://github.com/bitcoin/bitcoin/pull/31035
twistedline has joined #bitcoin-core-dev
<bitcoin-git> [packaging] achow101 opened pull request #248: snap: Update to 28.0 (main...main) https://github.com/bitcoin-core/packaging/pull/248
abubakarsadiq has quit [Quit: Connection closed for inactivity]
kevkevin has joined #bitcoin-core-dev