16:40 <bitcoin-git> [bitcoin] fjahr opened pull request #31117: miner: Reorg Testnet4 minimum difficulty blocks (master...2024-10-t4-reorg-miner) https://github.com/bitcoin/bitcoin/pull/31117

16:48 <bitcoin-git> [bitcoin] l0rinc opened pull request #31118: doc: replace `-?` with `-h` for bench_bitcoin help (master...l0rinc/bench-help) https://github.com/bitcoin/bitcoin/pull/31118

17:51 <vasild> stevenroose: see https://bitcoincore.org/en/releases/28.0/#p2p-and-network-changes By default (before and after 28.0) bitcoind acts as if bind=0.0.0.0:8333 bind=127.0.0.1:8334=onion is given

17:51 <vasild> specifying port=1234 changes that to bind=0.0.0.0:1234 bind=127.0.0.1:8334=onion

17:54 <vasild> new in 28.0: to remove that bind=127.0.0.1:8334=onion one has to explicitly specify bind=0.0.0.0:1234 or any other bind= and also any failing bind= results in a startup failure. In <28.0 in your scenario it would fail to bind on bind=127.0.0.1:8334=onion but that would be ignored (or only mentioned in the log), but startup would proceed

17:57 <vasild> port= is redundant with bind=...:port, I couldn't object deprecating and removing port= if others feel like so

18:00 <vasild> Maybe if port= is given, then also drop that bind=127.0.0.1:8334=onion, like we do when bind= is given? Or if port= is given then default that bind=127.0.0.1:8334=onion to bind=127.0.0.1:port+1=onion?

18:00 <vasild> or do nothing

20:32 <bitcoin-git> [bitcoin] achow101 closed pull request #31114: Simple security.doc improvement (28.x...28.x) https://github.com/bitcoin/bitcoin/pull/31114