00:42 <bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5837e3463fe1...e569eb8d9173

00:42 <bitcoin-git> bitcoin/master 33381ea Fabian Jahr: scripted-diff: Modernize nLocalServices to m_local_services

00:42 <bitcoin-git> bitcoin/master e569eb8 Ava Chow: Merge bitcoin/bitcoin#30885: scripted-diff: Modernize nLocalServices naming

00:42 <bitcoin-git> [bitcoin] achow101 merged pull request #30885: scripted-diff: Modernize nLocalServices naming (master...2024-09-localservices-new) https://github.com/bitcoin/bitcoin/pull/30885

08:49 <hebasto> maflcko: could you please look into https://cirrus-ci.com/github/bitcoin/bitcoin/pull%2F30997? it seems like a kind of issues with depends sources cache

09:09 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e569eb8d9173...5fb94550638d

09:09 <bitcoin-git> bitcoin/master ca2e4ba Cory Fields: refactor: include the proper header rather than forward-declaring RemovalR...

09:09 <bitcoin-git> bitcoin/master 5fb9455 merge-script: Merge bitcoin/bitcoin#31058: refactor: include the proper header rather th...

09:09 <bitcoin-git> [bitcoin] fanquake merged pull request #31058: refactor: include the proper header rather than forward-declaring RemovalReasonToString (master...fix-pch-forward-declare) https://github.com/bitcoin/bitcoin/pull/31058

11:35 <bitcoin-git> [bitcoin] maflcko opened pull request #31061: refactor: Check original (translatable) format string at compile-time (master...2410-trans) https://github.com/bitcoin/bitcoin/pull/31061

13:05 <bitcoin-git> [bitcoincore.org] dergoegge opened pull request #1074: Security advisories for vulnerabilities fixed in v25.0 (master...2024-10-october-bugs) https://github.com/bitcoin-core/bitcoincore.org/pull/1074

16:05 <bitcoin-git> [bitcoin] maflcko opened pull request #31063: lint: commit-script-check.sh: echo to stderr (master...2410-lint-echo-stderr) https://github.com/bitcoin/bitcoin/pull/31063

16:20 <bitcoin-git> [bitcoin] maflcko closed pull request #29745: bench: Adds a benchmark for CheckInputScripts (master...benchCheckInputScripts) https://github.com/bitcoin/bitcoin/pull/29745

16:26 <bitcoin-git> [bitcoin] maflcko closed pull request #29540: validation: Use witness maleation flag for non-segwit blocks (master...pr29524) https://github.com/bitcoin/bitcoin/pull/29540

17:32 <bitcoin-git> [bitcoincore.org] achow101 pushed 4 commits to master: https://github.com/bitcoin-core/bitcoincore.org/compare/2c96576f787c...b601352e42a7

17:32 <bitcoin-git> bitcoincore.org/master 2261f43 0xb10c: posts: disclose large inv-to-send DoS

17:32 <bitcoin-git> bitcoincore.org/master 3d6c7fb 0xb10c: posts: Disclose mutated blocks hindering propagation

17:32 <bitcoin-git> bitcoincore.org/master 47d7110 dergoegge: posts: Disclose blocktxn assert crash

17:32 <bitcoin-git> [bitcoincore.org] achow101 merged pull request #1074: Security advisories for vulnerabilities fixed in v25.0 (master...2024-10-october-bugs) https://github.com/bitcoin-core/bitcoincore.org/pull/1074

20:51 <Chris_Stewart_5> trying to upgrade to 28.0, running into issues with the behavior with failing to start when a port (18445) is already bound. I've attempted to use -listenonion=0 to get around this, but it doesn't seem to work. My understanding is -listen=0 doesn't allow any p2p connection which isnt what i want

20:52 <Chris_Stewart_5> 2024-10-09T20:41:22Z [net:error] Unable to bind to 127.0.0.1:18445 on this computer. Bitcoin Core is probably already running.

20:52 <Chris_Stewart_5> 2024-10-09T20:41:22Z [error] Unable to bind to 127.0.0.1:18445 on this computer. Bitcoin Core is probably already running.

20:52 <Chris_Stewart_5> 2024-10-09T20:41:22Z [error] Failed to listen on any port. Use -listen=0 if you want this.

20:53 <sipa> is it already bound by bitcoin core itself?

20:53 <sipa> or other software

20:53 <Chris_Stewart_5> Shouldn't listenonion=0 not attempt to bind it in the first place? Or perhaps i'm misunderstanding the setting

20:53 <sipa> i'm not familiar with the option myself

20:56 <Chris_Stewart_5> I'll see if I get a response in IRC and if i don't i'll file an issue. I believe this should be minimally reproducible by attempting to run 2 regtest nodes on the same machine with different -port settings with -listenonion=0

20:58 <Chris_Stewart_5> i.e './bitcoind -regtest -rpcport=12345 -listenonion=0 && ./bitocind -regtest -rpcport=54321 -listenonion=0'

20:58 <Chris_Stewart_5> ah, probably need different -datadir as well

21:01 <Chris_Stewart_5> './bitcoind -regtest -datadir=/tmp/random-1 -port=12345 -rpcport=12346 -listenonion=0 && ./bitcoind -regtest -datadir=/tmp/random-2 -rpcport=54321 -port=54320 -listenonion=0'

21:11 <lightlike> looks related to #22729: "Bitcoin Core will now fail to start up if any of its P2P binds fail, rather than the previous behaviour where it would only abort startup if all P2P binds had failed."

21:11 <gribble`> https://github.com/bitcoin/bitcoin/issues/22729 | Make it possible to disable Tor binds and abort startup on bind failure by vasild · Pull Request #22729 · bitcoin/bitcoin · GitHub

21:21 <jonatack> (that change may have needed a release note)

21:23 <lightlike> sorry, i wasn't clear, it had release notes (that's how I found out about it). The quote above is from the release notes.

21:25 <jonatack> oh indeed, good: https://github.com/bitcoin/bitcoin/pull/30502

21:26 <lightlike> Chris_Stewart_5: I'm not familiar with this at all, but I see the same behavior. one workaround seems to be using -bind (instead of -port) on one of the nodes.

21:26 <bitcoin-git> [bitcoin] TheCharlatan opened pull request #31064: init: Correct coins db cache size setting (master...patchCoinsDBCacheSizeInit) https://github.com/bitcoin/bitcoin/pull/31064

21:27 <lightlike> FYI @vasild

21:44 <jonatack> Chris_Stewart_5: how are you binding the port initially?

21:46 <jonatack> (feel free to share your config via direct message on irc)

21:59 <Chris_Stewart_5> bitcoin.conf https://pastebin.com/cfGm9hzW debug.log https://pastebin.com/vUhnj7Rp . This has only been tested on regtest