01:46 <sipa> achow101: that's the reason for the distinction between pubkey.{h,cpp} and key.{h,cpp}: the latter only matters in wallet code etc

08:27 <bitcoin-git> [bitcoin] omahs opened pull request #31070: Fix typos in check-deps.sh (master...patch-2) https://github.com/bitcoin/bitcoin/pull/31070

08:59 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/489e5aa3a299...d8b835cf18ce

08:59 <bitcoin-git> bitcoin/master da8824b omahs: Fix typos in check-deps.sh

08:59 <bitcoin-git> bitcoin/master d8b835c merge-script: Merge bitcoin/bitcoin#31070: contrib: fix typos in check-deps.sh

08:59 <bitcoin-git> [bitcoin] fanquake merged pull request #31070: contrib: fix typos in check-deps.sh (master...patch-2) https://github.com/bitcoin/bitcoin/pull/31070

12:19 <bitcoin-git> [bitcoin] ryanofsky opened pull request #31072: scripted-diff: Replace strprintf(Untranslated(...)) with Untranslated(strprintf(...)) (master...pr/bfmt) https://github.com/bitcoin/bitcoin/pull/31072

12:46 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d8b835cf18ce...48cf3da63608

12:46 <bitcoin-git> bitcoin/master ccd10fd Cory Fields: build: Add missing USDT header dependency to kernel

12:46 <bitcoin-git> bitcoin/master 48cf3da merge-script: Merge bitcoin/bitcoin#30970: build: Add missing USDT header dependency to ...

12:46 <bitcoin-git> [bitcoin] fanquake merged pull request #30970: build: Add missing USDT header dependency to kernel (master...fix-kernel-no-usdt) https://github.com/bitcoin/bitcoin/pull/30970

14:51 <bitcoin-git> [bitcoin] dergoegge opened pull request #31073: ci: Split out native fuzz jobs for macOS and windows (master...2024-10-native-fuzz) https://github.com/bitcoin/bitcoin/pull/31073

17:00 <bitcoin-git> [gui-qml] D33r-Gee opened pull request #424: [DRAFT] WIP QML Load Snapshot Signet (main...qml-load-snapshot-signet) https://github.com/bitcoin-core/gui-qml/pull/424

19:21 <Chris_Stewart_5> I'm trying to udnerstand the 'createwalletdescriptor' in v28, is the purpose of this to upgrade pre-descriptor wallets (that implicitly use berkleydb as a db?) to a descriptor wallet

19:22 <Chris_Stewart_5> I'm trying to test this scenario, so try to create a non-descriptor wallet, but get an error saying that 'BDB wallet creation is deprecated and will be removed in a future release' when attempting to create a pre-descriptor wallet

19:23 <Chris_Stewart_5> There is some guidance sayign to use '-deprecatedrpc=create_bdb'. But is this RPC only going to stick around for a few versions as a migration RPC and then be deprecated / removed ?

19:25 <sipa> Chris_Stewart_5: my understanding is that it for upgrading descriptor pre-taproot wallets to support taproot

19:26 <Chris_Stewart_5> sipa: How tightly coupled is this with the bdb -> sqlite3 upgrade? It seems like the descriptor upgrade implicitly means you are now using sqlite3? Is that correct?

19:26 <bitcoin-git> [bitcoin] ryanofsky opened pull request #31074: util: Check bilingual_str format strings at compile time (master...pr/bicheck) https://github.com/bitcoin/bitcoin/pull/31074

19:27 <sipa> Chris_Stewart_5: in practice yes; legacy = BDB, descriptor = SQLite

19:29 <Chris_Stewart_5> ok thanks!

19:29 <sipa> Chris_Stewart_5: you can convert a legacy wallet to a descriptor wallet using the migratewallet RPC; that's unrelated to createwalletdescriptor, which is about adding descriptors to an existing descriptor wallet

19:33 <Chris_Stewart_5> Hmm. Perhaps I still don't understand. If my wallet was currently loaded with a descriptor like this 'pk(xpub68NZiKmJWnxxS6aaHmn81bvJeTESw724CRDs6HbuccFQN9Ku14VQrADWgqbhhTHBaohPX4CjNLf9fq9MYo6oDaPPLPxSb7gwQN3ih19Zm4Y/0)', and then i call 'createdescriptorwallet bech32', that would create a

19:34 <Chris_Stewart_5> wpkh((xpub68NZiKmJWnxxS6aaHmn81bvJeTESw724CRDs6HbuccFQN9Ku14VQrADWgqbhhTHBaohPX4CjNLf9fq9MYo6oDaPPLPxSb7gwQN3ih19Zm4Y/0)' in the wallet?

19:37 <sipa> something like that, i think

19:50 <Chris_Stewart_5> Hmm i'll just have to wait for achow101 to be back, but AFAICT we by default create all address type descriptors via the 'createwallet' RPC? I'm attempting to use 'createwalletdescriptor' but end up getting this error for all address types 'Error -4: Descriptor already exists' so I think i'm missing something

19:51 <achow101> Chris_Stewart_5: createwalletdescriptor is separate from legacy -> descriptor migration

19:52 <achow101> it's for adding new autogenerated descriptors without having to write them all out by hand

19:52 <achow101> if you don't give it a key to use, it will use the key that all other active descriptors use. active means that the descriptor is used by getnewaddress to output a new address

19:54 <achow101> createwallet already creates all address types when it makes a new wallet

19:54 <achow101> createwalletdescriptor is mainly useful if you created a blank wallet, or if you made a descriptor wallet before taproot activated, which is really just 0.21

20:00 <Chris_Stewart_5> Thank you! I didn't think of the blank setting.

21:52 <sipa> achow101: if you migrate a legacy wallet, does it get taproot descriptors?

22:45 <achow101> sipa: yes

22:46 <achow101> migrating generates a whole new set of active descriptors that are independent of the original keys