<janb84>
109;34M1;1MQuestion for the maintainers: In my PR reviews, I try to write my review as a letter to the maintainers, outlining why the PR should or should not be merged, in my opinion (in addition to optional nits for the author). When a new commit is pushed, and I post a re-ACK message, how is this displayed in your interface? Is only my latest (re-)ACK visible? Would it be helpful to
<janb84>
edit the original review and copy/move my "letter"? Is there something else non-obvious I should consider?
<janb84>
Please help me help you! :) Thanks
bitcoinlover has quit [Ping timeout: 244 seconds]
kevkevin_ has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 252 seconds]
thoragh has quit [Read error: Connection reset by peer]
Guest3 has joined #bitcoin-core-dev
magellan has quit [Ping timeout: 272 seconds]
kevkevin has joined #bitcoin-core-dev
sliv3r__ has quit [Quit: ZNC 1.8.2+deb3.1+deb12u1 - https://znc.in]
sliv3r__ has joined #bitcoin-core-dev
Guest3 has quit [Ping timeout: 250 seconds]
Guyver2 has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
bitcoinlover has joined #bitcoin-core-dev
bugs_ has joined #bitcoin-core-dev
Guest54 has joined #bitcoin-core-dev
darosior1 has joined #bitcoin-core-dev
jetpack has quit [Quit: ZNC 1.8.2+deb2+deb11u1 - https://znc.in]
jetpack has joined #bitcoin-core-dev
darosior has quit [Read error: Connection reset by peer]
darosior1 is now known as darosior
jonatack has quit [Ping timeout: 244 seconds]
joetor5 has joined #bitcoin-core-dev
Guest54 has quit [Ping timeout: 250 seconds]
joetor5 has quit [Quit: joetor5]
mudsip has joined #bitcoin-core-dev
mudsip has quit [Client Quit]
magellan has joined #bitcoin-core-dev
robszarka has quit [Quit: Leaving]
szarka has joined #bitcoin-core-dev
magellan has quit [Quit: WeeChat 4.7.0]
bitcoinlover has quit [Ping timeout: 272 seconds]
greypw1495085720 has joined #bitcoin-core-dev
greypw1495085720 has quit [Remote host closed the connection]
greypw1495085720 has joined #bitcoin-core-dev
shwouchk has quit [Quit: WeeChat 4.5.2]
l0rinc has joined #bitcoin-core-dev
S3RK_ has quit [Ping timeout: 260 seconds]
S3RK has joined #bitcoin-core-dev
iSiUp has joined #bitcoin-core-dev
joetor5 has joined #bitcoin-core-dev
joetor5 has quit [Client Quit]
bitdex has quit [Remote host closed the connection]
bitdex has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
Talkless has joined #bitcoin-core-dev
iSiUp has quit [Quit: WeeChat 4.7.0]
iSiUp has joined #bitcoin-core-dev
iSiUp has quit [Quit: WeeChat 4.7.0]
iSiUp has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
magellan has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 248 seconds]
jonatack1 has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 245 seconds]
jonatack has joined #bitcoin-core-dev
jonatack1 has quit [Ping timeout: 252 seconds]
mudsip has joined #bitcoin-core-dev
mudsip has quit [Client Quit]
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 244 seconds]
magellan has quit [Ping timeout: 244 seconds]
magellan has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 252 seconds]
magellan has quit [Ping timeout: 272 seconds]
Guyver2 has left #bitcoin-core-dev [Closing Window]
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 272 seconds]
twistedline has quit [Ping timeout: 252 seconds]
twistedline has joined #bitcoin-core-dev
Cory90 has joined #bitcoin-core-dev
Cory28 has quit [Ping timeout: 250 seconds]
furszy has quit [Changing host]
furszy has joined #bitcoin-core-dev
<sipa>
janb84: not a current maintainer, but i have been one; for me, i don't think it would matter that much, as a merging decision involves more than just counting acks, but also looking at the credibility/depth of the reviews
<sipa>
so that will generallt involve reading through the comments anyway, unless it's a very long PR with many buried comments, maybe only the end will matter
jonatack has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 244 seconds]
bugs_ has quit [Quit: Leaving]
Talkless has quit [Quit: Konversation terminated!]
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 252 seconds]
iSiUp has quit [Changing host]
iSiUp has joined #bitcoin-core-dev
vincenzopalazzo has quit [Server closed connection]
vincenzopalazzo has joined #bitcoin-core-dev
iSiUp has quit [Quit: WeeChat 4.7.0]
iSiUp has joined #bitcoin-core-dev
iSiUp has quit [Changing host]
iSiUp has joined #bitcoin-core-dev
iSiUp has quit [Quit: WeeChat 4.7.0]
iSiUp has joined #bitcoin-core-dev
iSiUp has quit [Changing host]
iSiUp has joined #bitcoin-core-dev
jon_atack has quit [Read error: Connection reset by peer]
jonatack has joined #bitcoin-core-dev
roconnor has quit [Ping timeout: 244 seconds]
iSiUp has quit [Client Quit]
iSiUp has joined #bitcoin-core-dev
iSiUp has quit [Client Quit]
iSiUp has joined #bitcoin-core-dev
roconnor has joined #bitcoin-core-dev
iSiUp has quit [Quit: WeeChat 4.7.0]
iSiUp has joined #bitcoin-core-dev
iSiUp has quit [Client Quit]
iSiUp has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
iSiUp has quit [Quit: WeeChat 4.7.0]
iSiUp has joined #bitcoin-core-dev
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 252 seconds]
jonatack has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 244 seconds]
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 244 seconds]
twistedline has quit [Read error: Connection reset by peer]
jonatack has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 255 seconds]
twistedline has joined #bitcoin-core-dev
dzxzg has quit [Remote host closed the connection]
jonatack has quit [Ping timeout: 244 seconds]
jonatack has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 248 seconds]
joetor5 has joined #bitcoin-core-dev
robobub has quit [Quit: Connection closed for inactivity]
l0rinc has quit [Ping timeout: 244 seconds]
cotsuka has quit [Read error: Connection reset by peer]