00:04
ghost43 has quit [Remote host closed the connection]
00:04
ghost43 has joined #bitcoin-core-dev
00:44
jerryf has quit [Ping timeout: 240 seconds]
00:44
jerryf_ has joined #bitcoin-core-dev
00:48
schmidty has quit [Server closed connection]
00:48
schmidty has joined #bitcoin-core-dev
00:53
cmirror has quit [Ping timeout: 252 seconds]
00:53
Ara has quit [Ping timeout: 252 seconds]
00:55
Ara has joined #bitcoin-core-dev
01:24
PaperSword has joined #bitcoin-core-dev
01:43
jkczyz has quit [Server closed connection]
01:43
jkczyz has joined #bitcoin-core-dev
01:44
bitcoinlover has joined #bitcoin-core-dev
02:24
entropyx has joined #bitcoin-core-dev
02:24
entropyx has quit [Changing host]
02:24
entropyx has joined #bitcoin-core-dev
02:24
entropyx has quit [Client Quit]
03:39
jonatack has quit [Ping timeout: 265 seconds]
03:57
jespada has quit [Ping timeout: 272 seconds]
04:00
jespada has joined #bitcoin-core-dev
04:01
cmirror has joined #bitcoin-core-dev
04:24
PaperSword has quit [Quit: PaperSword]
04:24
PaperSword1 has joined #bitcoin-core-dev
04:27
PaperSword1 is now known as PaperSword
04:38
cold has quit [Remote host closed the connection]
04:38
cold has joined #bitcoin-core-dev
04:39
Guest54 has joined #bitcoin-core-dev
04:41
Guest54 has quit [Client Quit]
04:47
jerryf_ has quit [Remote host closed the connection]
04:47
jerryf has joined #bitcoin-core-dev
04:56
Dansken has joined #bitcoin-core-dev
05:00
l0rinc has joined #bitcoin-core-dev
06:30
l0rinc has quit [Quit: l0rinc]
06:39
kevkevin has quit [Remote host closed the connection]
06:56
f321x has joined #bitcoin-core-dev
06:57
kevkevin has joined #bitcoin-core-dev
07:02
kevkevin has quit [Ping timeout: 260 seconds]
07:22
Christoph_ has joined #bitcoin-core-dev
07:31
virtu has quit [Ping timeout: 244 seconds]
07:31
virtu has joined #bitcoin-core-dev
07:31
kevkevin has joined #bitcoin-core-dev
07:36
kevkevin has quit [Ping timeout: 255 seconds]
07:46
rszarka has joined #bitcoin-core-dev
07:46
Guyver2 has joined #bitcoin-core-dev
07:46
Guyver2 has quit [Client Quit]
07:47
Guyver2 has joined #bitcoin-core-dev
07:47
Guyver2 has left #bitcoin-core-dev [#bitcoin-core-dev]
07:49
robszarka has quit [Ping timeout: 260 seconds]
08:06
kevkevin has joined #bitcoin-core-dev
08:09
Cory has quit [*.net *.split]
08:37
Talkless has joined #bitcoin-core-dev
08:38
maflcko has quit [Server closed connection]
08:39
maflcko has joined #bitcoin-core-dev
08:39
emcy__ has joined #bitcoin-core-dev
08:42
_durandal has quit [Ping timeout: 276 seconds]
09:10
kevkevin has quit [Ping timeout: 255 seconds]
09:13
<
bitcoin-git >
bitcoin/master 4bff4ce fanquake: contrib: drop bitcoin-util exception from FORTIFY check
09:13
<
bitcoin-git >
bitcoin/master 34b366f merge-script: Merge bitcoin/bitcoin#33155: contrib: drop `bitcoin-util` exception from F...
09:16
abubakarsadiq has joined #bitcoin-core-dev
09:26
<
bitcoin-git >
bitcoin/master 9014d40 Pieter Wuille: tests: add sighash caching tests to feature_taproot
09:26
<
bitcoin-git >
bitcoin/master 8f3ddb0 Pieter Wuille: script: (refactor) prepare for introducing sighash midstate cache
09:26
<
bitcoin-git >
bitcoin/master 92af9f7 Pieter Wuille: script: (optimization) introduce sighash midstate caching
09:37
kevkevin has joined #bitcoin-core-dev
09:42
kevkevin has quit [Ping timeout: 252 seconds]
09:51
kevkevin has joined #bitcoin-core-dev
10:21
hardtotell has quit [Server closed connection]
10:21
hardtotell has joined #bitcoin-core-dev
10:40
P8tBoy has quit [Server closed connection]
10:40
PatBoy has joined #bitcoin-core-dev
11:06
Christoph_ has quit [Quit: Christoph_]
11:07
Christoph_ has joined #bitcoin-core-dev
11:11
Christoph_ has quit [Ping timeout: 260 seconds]
11:25
abubakarsadiq has quit [Quit: Connection closed for inactivity]
11:26
Christoph_ has joined #bitcoin-core-dev
11:56
PaperSword has quit [Quit: PaperSword]
11:57
kevkevin has quit [Ping timeout: 255 seconds]
12:21
kevkevin has joined #bitcoin-core-dev
12:26
kevkevin has quit [Ping timeout: 252 seconds]
12:30
qxs has quit [Quit: leaving]
12:42
kevkevin has joined #bitcoin-core-dev
12:49
kevkevin has quit [Ping timeout: 252 seconds]
13:03
bugs_ has joined #bitcoin-core-dev
13:12
jonatack has joined #bitcoin-core-dev
13:18
kevkevin has joined #bitcoin-core-dev
13:21
andytoshi has quit [Server closed connection]
13:21
andytoshi has joined #bitcoin-core-dev
13:31
jon_atack has joined #bitcoin-core-dev
13:33
jonatack has quit [Ping timeout: 255 seconds]
13:53
joetor5 has joined #bitcoin-core-dev
13:57
f321x_ has joined #bitcoin-core-dev
13:57
eugenesiegel has joined #bitcoin-core-dev
13:57
f321x has quit [Ping timeout: 240 seconds]
13:57
jonatack has joined #bitcoin-core-dev
14:00
jon_atack has quit [Ping timeout: 255 seconds]
14:06
chjj has quit [Server closed connection]
14:06
chjj has joined #bitcoin-core-dev
14:06
joetor5 has quit [Remote host closed the connection]
14:07
joetor5 has joined #bitcoin-core-dev
14:10
eugenesiegel has quit [Quit: Client closed]
14:15
bitcoinlover has quit [Ping timeout: 255 seconds]
14:18
jon_atack has joined #bitcoin-core-dev
14:19
jonatack has quit [Ping timeout: 252 seconds]
14:26
PaperSword has joined #bitcoin-core-dev
14:34
joetor5 has quit [Quit: joetor5]
14:45
<
bitcoin-git >
bitcoin/master ca64b71 UdjinM6: test: fix scripts in `blockfilter_basic_test`
14:45
<
bitcoin-git >
bitcoin/master 41642d4 merge-script: Merge bitcoin/bitcoin#33162: test: fix scripts in `blockfilter_basic_test`
14:58
jonatack has joined #bitcoin-core-dev
15:00
jon_atack has quit [Ping timeout: 252 seconds]
15:01
Christoph_ has quit [Quit: Christoph_]
15:01
jon_atack has joined #bitcoin-core-dev
15:03
jonatack has quit [Ping timeout: 255 seconds]
15:14
jonatack has joined #bitcoin-core-dev
15:15
jon_atack has quit [Ping timeout: 252 seconds]
15:16
joetor5 has joined #bitcoin-core-dev
15:23
<
sipa >
!jinx fanquake
15:36
l0rinc has joined #bitcoin-core-dev
15:36
l0rinc has quit [Client Quit]
15:39
joetor5 has quit [Quit: joetor5]
15:47
zeropoint has joined #bitcoin-core-dev
15:52
PaperSword has quit [Quit: PaperSword]
15:53
PaperSword has joined #bitcoin-core-dev
16:01
Talkless has quit [Read error: Connection reset by peer]
16:07
jespada has quit [Ping timeout: 248 seconds]
16:10
jespada has joined #bitcoin-core-dev
16:10
f321x_ has quit [Quit: f321x_]
16:31
pablomartin has joined #bitcoin-core-dev
16:33
pablomartin4btc has quit [Ping timeout: 276 seconds]
16:34
eugenesiegel has joined #bitcoin-core-dev
16:34
meebey has quit [Server closed connection]
16:36
meebey has joined #bitcoin-core-dev
16:41
zeropoint has quit [Quit: Lost terminal]
17:05
zeropoint has joined #bitcoin-core-dev
17:11
emcy__ has quit [Quit: Leaving]
17:14
durandal_ has joined #bitcoin-core-dev
17:25
eugenesiegel has quit [Quit: Client closed]
17:32
pablomartin is now known as pablomartin4btc
17:47
jon_atack has joined #bitcoin-core-dev
17:49
jonatack has quit [Ping timeout: 255 seconds]
17:51
jonatack has joined #bitcoin-core-dev
17:53
jon_atack has quit [Ping timeout: 255 seconds]
17:56
jon_atack has joined #bitcoin-core-dev
17:58
jonatack has quit [Ping timeout: 240 seconds]
18:07
michaelfolkson has quit [Server closed connection]
18:07
michaelfolkson has joined #bitcoin-core-dev
18:08
joetor5 has joined #bitcoin-core-dev
18:15
mudsip has joined #bitcoin-core-dev
18:17
mudsip has quit [Client Quit]
18:23
l0rinc has joined #bitcoin-core-dev
18:53
rszarka has quit [Quit: Leaving]
18:53
szarka has joined #bitcoin-core-dev
18:56
kevkevin has quit [Remote host closed the connection]
18:57
kevkevin has joined #bitcoin-core-dev
18:57
joetor5 has quit [Quit: joetor5]
18:58
kevkevin has quit [Remote host closed the connection]
18:59
kevkevin has joined #bitcoin-core-dev
19:08
l0rinc has quit [Quit: l0rinc]
19:09
cotsuka has quit [Read error: Connection reset by peer]
19:12
cotsuka has joined #bitcoin-core-dev
19:15
l0rinc has joined #bitcoin-core-dev
19:20
dviola has quit [Ping timeout: 260 seconds]
19:22
diego has joined #bitcoin-core-dev
19:22
diego is now known as Guest4796
19:22
jonatack has joined #bitcoin-core-dev
19:24
jon_atack has quit [Ping timeout: 255 seconds]
19:27
jon_atack has joined #bitcoin-core-dev
19:28
jonatack has quit [Ping timeout: 240 seconds]
19:28
Christoph_ has joined #bitcoin-core-dev
19:52
l0rinc has quit [Quit: l0rinc]
19:54
Christoph_ has quit [Quit: Christoph_]
19:55
Christoph_ has joined #bitcoin-core-dev
19:56
b4nd0 has joined #bitcoin-core-dev
19:56
l0rinc has joined #bitcoin-core-dev
19:59
Christoph_ has quit [Ping timeout: 252 seconds]
20:00
b4nd0 has quit [Quit: Leaving]
20:07
Christoph_ has joined #bitcoin-core-dev
20:12
l0rinc has quit [Quit: l0rinc]
20:12
Christoph_ has quit [Ping timeout: 252 seconds]
20:13
Christoph_ has joined #bitcoin-core-dev
20:13
Guest4796 has left #bitcoin-core-dev [#bitcoin-core-dev]
20:14
dviola has joined #bitcoin-core-dev
20:17
jonatack has joined #bitcoin-core-dev
20:17
l0rinc has joined #bitcoin-core-dev
20:17
Christoph_ has quit [Client Quit]
20:18
jon_atack has quit [Ping timeout: 252 seconds]
20:19
jon_atack has joined #bitcoin-core-dev
20:20
l0rinc has quit [Client Quit]
20:21
jonatack has quit [Ping timeout: 240 seconds]
20:34
jonatack has joined #bitcoin-core-dev
20:35
jon_atack has quit [Ping timeout: 252 seconds]
20:39
Christoph_ has joined #bitcoin-core-dev
20:44
<
darosior >
Reviewing minrelaytxfee (still), why does the wallet's GetRequiredFeeRate() use the min relay fee instead of (the potentially higher floor) mempool min fee?
20:45
<
darosior >
Hmm i guess you may want to be able to craft a PSBT to send later when mempool min fee might be lower, although min relay fee is much less likely to change
20:47
Christoph_ has quit [Quit: Christoph_]
20:48
<
achow101 >
darosior: GetRequiredFeeRate returns the absolute lowest feerate that may be acceptable for a transaction. it's used as a check, not as the real fee that we ever use
20:49
<
achow101 >
it's used when the user provides a feerate and we need to check whether this will ever be accepted by our mempool
20:49
<
achow101 >
otherwise, we use the fee estimator which should be accounting for mempool min fee
20:53
<
darosior >
Yes fee estimator result is max(estimate, mempool min fee). But it's not used if the user provides a feerate manually
20:54
<
darosior >
Anyways, thanks, i was just curious why not check against the lowest our mempool will accept, but it makes sense to check against the lowest our mempool will
*ever* accept
20:56
<
darosior >
I guess it's an instance where different type of users of the wallet would want different things. Those just using it as a wallet directly in the most basic way would probably benefit from a mempool min fee check instead, since this would most likely be called when they are making a transaction to be sent immediately. But more sophisticated uses of
20:56
<
darosior >
the wallet, such as using it as a watchonly wallet to craft transaction for say a multisig, probably prefer a min relay feerate check here.
21:04
stickies-v has quit [Server closed connection]
21:04
stickies-v has joined #bitcoin-core-dev
21:24
joetor5 has joined #bitcoin-core-dev
21:35
l0rinc has joined #bitcoin-core-dev
22:02
jon_atack has joined #bitcoin-core-dev
22:04
jonatack has quit [Ping timeout: 252 seconds]
22:05
jerryf has quit [Remote host closed the connection]
22:05
jerryf has joined #bitcoin-core-dev
22:08
l0rinc has quit [Quit: l0rinc]
22:11
l0rinc has joined #bitcoin-core-dev
22:16
<
bitcoin-git >
bitcoin/master 1b40dc0 Lőrinc: refactor: extract `LargeCoinsCacheThreshold` from `GetCoinsCacheSizeState`
22:16
<
bitcoin-git >
bitcoin/master 64ed0fa Lőrinc: refactor: modernize `LargeCoinsCacheThreshold`
22:16
<
bitcoin-git >
bitcoin/master 554befd Lőrinc: test: revive `getcoinscachesizestate`
22:16
<
bitcoin-git >
[bitcoin] achow101 merged pull request #33021: test/refactor: revive test verifying that `GetCoinsCacheSizeState` switches from OK→LARGE→CRITICAL (master...l0rinc/validation_flush_tests)
https://github.com/bitcoin/bitcoin/pull/33021
22:26
bugs_ has quit [Quit: Leaving]
22:31
jonatack has joined #bitcoin-core-dev
22:33
jon_atack has quit [Ping timeout: 252 seconds]
22:39
jespada has quit [Ping timeout: 252 seconds]
23:08
joetor5 has quit [Quit: joetor5]
23:14
l0rinc has quit [Quit: l0rinc]
23:17
l0rinc has joined #bitcoin-core-dev
23:55
l0rinc has quit [Quit: l0rinc]
23:58
dergoegge has quit [Server closed connection]
23:58
l0rinc has joined #bitcoin-core-dev
23:58
dergoegge has joined #bitcoin-core-dev