achow101 changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 16:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
jerryf has quit [Ping timeout: 240 seconds]
jerryf_ has joined #bitcoin-core-dev
schmidty has quit [Server closed connection]
schmidty has joined #bitcoin-core-dev
cmirror has quit [Ping timeout: 252 seconds]
Ara has quit [Ping timeout: 252 seconds]
Ara has joined #bitcoin-core-dev
PaperSword has joined #bitcoin-core-dev
jkczyz has quit [Server closed connection]
jkczyz has joined #bitcoin-core-dev
bitcoinlover has joined #bitcoin-core-dev
entropyx has joined #bitcoin-core-dev
entropyx has quit [Changing host]
entropyx has joined #bitcoin-core-dev
entropyx has quit [Client Quit]
jonatack has quit [Ping timeout: 265 seconds]
jespada has quit [Ping timeout: 272 seconds]
jespada has joined #bitcoin-core-dev
cmirror has joined #bitcoin-core-dev
PaperSword has quit [Quit: PaperSword]
PaperSword1 has joined #bitcoin-core-dev
PaperSword1 is now known as PaperSword
cold has quit [Remote host closed the connection]
cold has joined #bitcoin-core-dev
Guest54 has joined #bitcoin-core-dev
Guest54 has quit [Client Quit]
jerryf_ has quit [Remote host closed the connection]
jerryf has joined #bitcoin-core-dev
Dansken has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
kevkevin has quit [Remote host closed the connection]
f321x has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 260 seconds]
Christoph_ has joined #bitcoin-core-dev
virtu has quit [Ping timeout: 244 seconds]
virtu has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 255 seconds]
rszarka has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
Guyver2 has quit [Client Quit]
Guyver2 has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [#bitcoin-core-dev]
robszarka has quit [Ping timeout: 260 seconds]
kevkevin has joined #bitcoin-core-dev
Cory has quit [*.net *.split]
Talkless has joined #bitcoin-core-dev
maflcko has quit [Server closed connection]
maflcko has joined #bitcoin-core-dev
emcy__ has joined #bitcoin-core-dev
_durandal has quit [Ping timeout: 276 seconds]
kevkevin has quit [Ping timeout: 255 seconds]
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/daca51bf80e7...34b366fa2c91
<bitcoin-git> bitcoin/master 4bff4ce fanquake: contrib: drop bitcoin-util exception from FORTIFY check
<bitcoin-git> bitcoin/master 34b366f merge-script: Merge bitcoin/bitcoin#33155: contrib: drop `bitcoin-util` exception from F...
<bitcoin-git> [bitcoin] fanquake merged pull request #33155: contrib: drop `bitcoin-util` exception from FORTIFY check (master...util_fortified) https://github.com/bitcoin/bitcoin/pull/33155
abubakarsadiq has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/34b366fa2c91...a27430e259df
<bitcoin-git> bitcoin/master 9014d40 Pieter Wuille: tests: add sighash caching tests to feature_taproot
<bitcoin-git> bitcoin/master 8f3ddb0 Pieter Wuille: script: (refactor) prepare for introducing sighash midstate cache
<bitcoin-git> bitcoin/master 92af9f7 Pieter Wuille: script: (optimization) introduce sighash midstate caching
<bitcoin-git> [bitcoin] fanquake merged pull request #32473: Introduce per-txin sighash midstate cache for legacy/p2sh/segwitv0 scripts (master...202504_sighash_cache) https://github.com/bitcoin/bitcoin/pull/32473
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 252 seconds]
kevkevin has joined #bitcoin-core-dev
hardtotell has quit [Server closed connection]
hardtotell has joined #bitcoin-core-dev
P8tBoy has quit [Server closed connection]
PatBoy has joined #bitcoin-core-dev
Christoph_ has quit [Quit: Christoph_]
Christoph_ has joined #bitcoin-core-dev
Christoph_ has quit [Ping timeout: 260 seconds]
abubakarsadiq has quit [Quit: Connection closed for inactivity]
Christoph_ has joined #bitcoin-core-dev
PaperSword has quit [Quit: PaperSword]
kevkevin has quit [Ping timeout: 255 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 252 seconds]
qxs has quit [Quit: leaving]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 252 seconds]
bugs_ has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
andytoshi has quit [Server closed connection]
andytoshi has joined #bitcoin-core-dev
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 255 seconds]
joetor5 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] hebasto opened pull request #33171: ci: Update `actions/checkout` version (master...250811-ci-update) https://github.com/bitcoin/bitcoin/pull/33171
f321x_ has joined #bitcoin-core-dev
eugenesiegel has joined #bitcoin-core-dev
f321x has quit [Ping timeout: 240 seconds]
jonatack has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 255 seconds]
chjj has quit [Server closed connection]
chjj has joined #bitcoin-core-dev
joetor5 has quit [Remote host closed the connection]
joetor5 has joined #bitcoin-core-dev
eugenesiegel has quit [Quit: Client closed]
bitcoinlover has quit [Ping timeout: 255 seconds]
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 252 seconds]
PaperSword has joined #bitcoin-core-dev
joetor5 has quit [Quit: joetor5]
<bitcoin-git> [bitcoin] glozow pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a27430e259df...41642d43b3b2
<bitcoin-git> bitcoin/master ca64b71 UdjinM6: test: fix scripts in `blockfilter_basic_test`
<bitcoin-git> bitcoin/master 41642d4 merge-script: Merge bitcoin/bitcoin#33162: test: fix scripts in `blockfilter_basic_test`
<bitcoin-git> [bitcoin] glozow merged pull request #33162: test: fix scripts in `blockfilter_basic_test` (master...fix_scripts_blockfilter_basic_test) https://github.com/bitcoin/bitcoin/pull/33162
jonatack has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 252 seconds]
Christoph_ has quit [Quit: Christoph_]
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 255 seconds]
jonatack has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 252 seconds]
joetor5 has joined #bitcoin-core-dev
<sipa> !jinx fanquake
<fanquake> heh
l0rinc has joined #bitcoin-core-dev
l0rinc has quit [Client Quit]
joetor5 has quit [Quit: joetor5]
<bitcoin-git> [bitcoin] musaHaruna opened pull request #33172: test: p2p block malleability (master...test-p2p-block-malleability) https://github.com/bitcoin/bitcoin/pull/33172
zeropoint has joined #bitcoin-core-dev
PaperSword has quit [Quit: PaperSword]
PaperSword has joined #bitcoin-core-dev
Talkless has quit [Read error: Connection reset by peer]
jespada has quit [Ping timeout: 248 seconds]
jespada has joined #bitcoin-core-dev
f321x_ has quit [Quit: f321x_]
pablomartin has joined #bitcoin-core-dev
pablomartin4btc has quit [Ping timeout: 276 seconds]
eugenesiegel has joined #bitcoin-core-dev
meebey has quit [Server closed connection]
meebey has joined #bitcoin-core-dev
zeropoint has quit [Quit: Lost terminal]
zeropoint has joined #bitcoin-core-dev
emcy__ has quit [Quit: Leaving]
durandal_ has joined #bitcoin-core-dev
eugenesiegel has quit [Quit: Client closed]
pablomartin is now known as pablomartin4btc
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 255 seconds]
jonatack has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 255 seconds]
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 240 seconds]
michaelfolkson has quit [Server closed connection]
michaelfolkson has joined #bitcoin-core-dev
joetor5 has joined #bitcoin-core-dev
mudsip has joined #bitcoin-core-dev
mudsip has quit [Client Quit]
l0rinc has joined #bitcoin-core-dev
rszarka has quit [Quit: Leaving]
szarka has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
joetor5 has quit [Quit: joetor5]
kevkevin has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
dviola has quit [Ping timeout: 260 seconds]
diego has joined #bitcoin-core-dev
diego is now known as Guest4796
jonatack has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 255 seconds]
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 240 seconds]
Christoph_ has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
Christoph_ has quit [Quit: Christoph_]
Christoph_ has joined #bitcoin-core-dev
b4nd0 has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
Christoph_ has quit [Ping timeout: 252 seconds]
b4nd0 has quit [Quit: Leaving]
Christoph_ has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
Christoph_ has quit [Ping timeout: 252 seconds]
Christoph_ has joined #bitcoin-core-dev
Guest4796 has left #bitcoin-core-dev [#bitcoin-core-dev]
dviola has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
Christoph_ has quit [Client Quit]
jon_atack has quit [Ping timeout: 252 seconds]
jon_atack has joined #bitcoin-core-dev
l0rinc has quit [Client Quit]
jonatack has quit [Ping timeout: 240 seconds]
<bitcoin-git> [bitcoin] Daulox92 opened pull request #33173: Update GitHub Actions (master...master) https://github.com/bitcoin/bitcoin/pull/33173
<bitcoin-git> [bitcoin] fanquake closed pull request #33173: Update GitHub Actions (master...master) https://github.com/bitcoin/bitcoin/pull/33173
jonatack has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 252 seconds]
Christoph_ has joined #bitcoin-core-dev
<darosior> Reviewing minrelaytxfee (still), why does the wallet's GetRequiredFeeRate() use the min relay fee instead of (the potentially higher floor) mempool min fee?
<darosior> Hmm i guess you may want to be able to craft a PSBT to send later when mempool min fee might be lower, although min relay fee is much less likely to change
Christoph_ has quit [Quit: Christoph_]
<achow101> darosior: GetRequiredFeeRate returns the absolute lowest feerate that may be acceptable for a transaction. it's used as a check, not as the real fee that we ever use
<achow101> it's used when the user provides a feerate and we need to check whether this will ever be accepted by our mempool
<achow101> otherwise, we use the fee estimator which should be accounting for mempool min fee
<darosior> Yes fee estimator result is max(estimate, mempool min fee). But it's not used if the user provides a feerate manually
<darosior> Anyways, thanks, i was just curious why not check against the lowest our mempool will accept, but it makes sense to check against the lowest our mempool will *ever* accept
<darosior> I guess it's an instance where different type of users of the wallet would want different things. Those just using it as a wallet directly in the most basic way would probably benefit from a mempool min fee check instead, since this would most likely be called when they are making a transaction to be sent immediately. But more sophisticated uses of
<darosior> the wallet, such as using it as a watchonly wallet to craft transaction for say a multisig, probably prefer a min relay feerate check here.
stickies-v has quit [Server closed connection]
stickies-v has joined #bitcoin-core-dev
joetor5 has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 252 seconds]
jerryf has quit [Remote host closed the connection]
jerryf has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
l0rinc has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] achow101 pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/41642d43b3b2...273e600e65c2
<bitcoin-git> bitcoin/master 1b40dc0 Lőrinc: refactor: extract `LargeCoinsCacheThreshold` from `GetCoinsCacheSizeState`
<bitcoin-git> bitcoin/master 64ed0fa Lőrinc: refactor: modernize `LargeCoinsCacheThreshold`
<bitcoin-git> bitcoin/master 554befd Lőrinc: test: revive `getcoinscachesizestate`
<bitcoin-git> [bitcoin] achow101 merged pull request #33021: test/refactor: revive test verifying that `GetCoinsCacheSizeState` switches from OK→LARGE→CRITICAL (master...l0rinc/validation_flush_tests) https://github.com/bitcoin/bitcoin/pull/33021
bugs_ has quit [Quit: Leaving]
jonatack has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 252 seconds]
jespada has quit [Ping timeout: 252 seconds]
joetor5 has quit [Quit: joetor5]
l0rinc has quit [Quit: l0rinc]
l0rinc has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
dergoegge has quit [Server closed connection]
l0rinc has joined #bitcoin-core-dev
dergoegge has joined #bitcoin-core-dev