shwouchk has quit [Read error: Connection reset by peer]
shwouchk has joined #bitcoin-core-dev
jamesob156659 has quit [Server closed connection]
jamesob156659 has joined #bitcoin-core-dev
Cory12 has joined #bitcoin-core-dev
cornfeedhobo_ is now known as cornfeedhobo
Cory79 has quit [Ping timeout: 250 seconds]
iSiUp has quit [Ping timeout: 244 seconds]
iSiUp has joined #bitcoin-core-dev
Cory27 has joined #bitcoin-core-dev
Cory15 has joined #bitcoin-core-dev
w0xlt has quit [Ping timeout: 258 seconds]
Cory12 has quit [Ping timeout: 250 seconds]
Cory27 has quit [Ping timeout: 250 seconds]
w0xlt has joined #bitcoin-core-dev
l0rinc has quit [Ping timeout: 260 seconds]
qubuepe24 has quit [Remote host closed the connection]
l0rinc has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
<bitcoin-git>
[bitcoin] kevkevinpal opened pull request #33264: threading: reduce the scope of lock in getblocktemplate (master...reduceScopeOfGetBlockTemplateLock) https://github.com/bitcoin/bitcoin/pull/33264
_durandal has joined #bitcoin-core-dev
emcy__ has quit [Ping timeout: 256 seconds]
purpleKarrot has joined #bitcoin-core-dev
w0xlt has quit [Ping timeout: 248 seconds]
w0xlt has joined #bitcoin-core-dev
w0xlt has quit [Ping timeout: 258 seconds]
purpleKarrot has quit [Quit: purpleKarrot]
purpleKarrot has joined #bitcoin-core-dev
lightlike has quit [Read error: Software caused connection abort]
lightlike has joined #bitcoin-core-dev
BlueMattMtrxBot has quit [Server closed connection]
BlueMattMtrxBot has joined #bitcoin-core-dev
bitcoinlover has joined #bitcoin-core-dev
gmaxwell has quit [Server closed connection]
gmaxwell has joined #bitcoin-core-dev
gmaxwell is now known as Guest6605
robszarka has joined #bitcoin-core-dev
szarka has quit [Ping timeout: 260 seconds]
l0rinc has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
Cory91 has joined #bitcoin-core-dev
Cory15 has quit [Ping timeout: 250 seconds]
hardtotell has quit [Server closed connection]
hardtotell has joined #bitcoin-core-dev
w0xlt has joined #bitcoin-core-dev
w0xlt has quit [Ping timeout: 248 seconds]
jonatack has quit [Ping timeout: 245 seconds]
kevkevin has quit [Remote host closed the connection]
zeropoint has quit [Quit: leaving]
kevkevin has joined #bitcoin-core-dev
antanst has quit [Server closed connection]
antanst has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 252 seconds]
PaperSword has quit [Quit: PaperSword]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 248 seconds]
w0xlt has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
andytoshi has quit [Server closed connection]
andytoshi has joined #bitcoin-core-dev
w0xlt has quit [Ping timeout: 258 seconds]
w0xlt has joined #bitcoin-core-dev
Cory91 has quit [Quit: Client closed]
Cory91 has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
kevkevin has quit [Ping timeout: 258 seconds]
f321x has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
w0xlt has quit [Ping timeout: 256 seconds]
w0xlt has joined #bitcoin-core-dev
<Sjors[m]1>
Should we move the achow101/signapple repo to bitcoin-core? Maybe for the v30 release.
<bitcoinlover>
Hi guys, ask a question, I need to measure performance of verifying some real blocks (including utxo loading from disk), I'm going to use -stopafterblockimport to achieve this. But I found the beginning blocks starting from genesis block has few Txs which is not a good choice to test with. Any hints?
<Sjors[m]1>
bitcoinlover: I think l0rinc has been working on that issue
kevkevin has joined #bitcoin-core-dev
thelounge042 has joined #bitcoin-core-dev
w0xlt has quit [Ping timeout: 258 seconds]
Guest6605 has quit [Changing host]
Guest6605 has joined #bitcoin-core-dev
Guest6605 is now known as gmaxwell
bitcoinlover is now known as HowHsu
___nick___ has joined #bitcoin-core-dev
f321x_ has joined #bitcoin-core-dev
f321x has quit [Ping timeout: 272 seconds]
kevkevin has quit [Ping timeout: 256 seconds]
<HowHsu>
@Sjors[m]1, does bitcoin core currently has benchmark like so, allow selecting some block files, then testing the connection?
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 260 seconds]
kevkevin has joined #bitcoin-core-dev
w0xlt has joined #bitcoin-core-dev
yonson has quit [Quit: Connection closed for inactivity]
w0xlt has quit [Ping timeout: 260 seconds]
S3RK_ has joined #bitcoin-core-dev
S3RK has quit [Ping timeout: 248 seconds]
kevkevin has quit [Ping timeout: 260 seconds]
f321x_ has quit [Ping timeout: 272 seconds]
f321x has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
dviola has quit [Read error: Connection reset by peer]
diego has joined #bitcoin-core-dev
diego is now known as Guest7107
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
Guyver2 has left #bitcoin-core-dev [Closing Window]
Guest7107 has quit [Ping timeout: 260 seconds]
diego has joined #bitcoin-core-dev
diego is now known as Guest2701
kevkevin has quit [Ping timeout: 260 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 260 seconds]
kevkevin has joined #bitcoin-core-dev
cncr04s has quit [Server closed connection]
cncr04s has joined #bitcoin-core-dev
Cory98 has joined #bitcoin-core-dev
Cory91 has quit [Ping timeout: 250 seconds]
Cory48 has joined #bitcoin-core-dev
Cory98 has quit [Ping timeout: 250 seconds]
Cory76 has joined #bitcoin-core-dev
HowHsu has quit [Ping timeout: 256 seconds]
Cory48 has quit [Ping timeout: 250 seconds]
Cory75 has joined #bitcoin-core-dev
HowHsu has joined #bitcoin-core-dev
Cory76 has quit [Ping timeout: 250 seconds]
Cory75 has quit [Quit: Client closed]
Cory75 has joined #bitcoin-core-dev
mudsip has joined #bitcoin-core-dev
mudsip has quit [Client Quit]
jonatack has joined #bitcoin-core-dev
emcy__ has joined #bitcoin-core-dev
Guest2701 has left #bitcoin-core-dev [#bitcoin-core-dev]
_durandal has quit [Ping timeout: 258 seconds]
dviola has joined #bitcoin-core-dev
Cory65 has joined #bitcoin-core-dev
Cory75 has quit [Ping timeout: 250 seconds]
Cory37 has joined #bitcoin-core-dev
Cory65 has quit [Ping timeout: 250 seconds]
f321x has quit [Remote host closed the connection]
<Sjors[m]1>
achow101: consistency with other maintainer tooling and a bit easier to find. But not a big deal.
<Sjors[m]1>
Quick sv2 workgroup update since I'll be afk during some of the meeting. I just launched a standalone sv2 template provider that connects over IPC: https://github.com/Sjors/sv2-tp
dzxzg has joined #bitcoin-core-dev
Emc99 has joined #bitcoin-core-dev
<Sjors[m]1>
Thanks everyone for getting #31802 over the finish line.
<achow101>
There are no pre-proposed meeting topics this week. Any last minute ones to add?
<Murch[m]>
Good morning
<kanzure>
hi
<kevkevin>
hi
<achow101>
#topic Stratum v2 WG Update (sjors)
<achow101>
<Sjors[m]1> Quick sv2 workgroup update since I'll be afk during some of the meeting. I just launched a standalone sv2 template provider that connects over IPC: https://github.com/Sjors/sv2-tp
<achow101>
<Sjors[m]1> Thanks everyone for getting #31802 over the finish line.
<johnny9dev>
was out last week (summer time). But getting back this week and focused on testing. I opened a PR to add a basic unittest (bitcoin-core/gui-qml#497). Going to use Qt's unittest framework and likely add GMock later on for more complex test scenarios. Will try to cover all c++ modules and use the QML test framework to do basic testing on the qml views as well.
<Murch[m]>
No, that’s not what I meant, but I’ll follow up later.
<stickies-v>
I think #33208 can be removed from the milestone, it's not completely fixed but the most common case should be, seems fine to me to not have this be a blocker
<achow101>
the blocker on that is the translation string
<sipa>
hi. not here. no clustermempool updates
<achow101>
since updating transifex will mess up translations that have already been done
<l0rinc>
is there a way to update the English one without messing up anything else? The translations can stay the same as far as I'm concerned
<achow101>
if the string is updated in the source code, but we don't update transifex, it will be english for all languages
<achow101>
even if there is a translation for the old string
<_aj_>
could update the source test for the translations when the translations are merged?
<_aj_>
source text
<achow101>
_aj_: we don't update transifex after translation strings freeze
<achow101>
not even for minor releaes
<achow101>
but we do pull down new translations for minor releases
Guest29 has joined #bitcoin-core-dev
<l0rinc>
sounds like transifex is holding us prisoners here
<l0rinc>
or hostages or whatever the term is :)
<_aj_>
achow101: we get the translation data out of transifex and merge it in though eg #32004. do that, then bulk search and replace the current english text with the change
<achow101>
_aj_: that's prone to breakage on the next translations update
<achow101>
l0rinc: it's more of our own policy to not screw the translators
<l0rinc>
how could it break exactly, isn't the source code being used as the source of truth?
<l0rinc>
could other translation be messed up or just that they would have to retranslate this one in the worst case?
<achow101>
l0rinc: the translation files also contain the untranslated string so that they can be matched against the source. what _aj_ is proposing is to modify the untranslated string contained in the translation file
<l0rinc>
yes, it's what I proposed as well
<l0rinc>
if we change all the keys, wouldn't that solve the problem deterministically?
<achow101>
updating the source file in transifex will result in collateral damage in that _other_ strings will be marked as untranslated, requiring translators to re-enter and/or re-review those translations. while transifex has "memory", it doesn't fill things in automatically
<_aj_>
so let's not do that until 31.0?
<achow101>
this particular string would appear as a completely new string with no memory, and so has to be translated from scratch
<achow101>
changing the translation files manually will require them to be changed manually for all strings update, otherwise the change gets reverted
<achow101>
we do pull down translations for minor releases, and it's done by a script
eugenesiegel has quit [Ping timeout: 250 seconds]
<l0rinc>
I'm not sure I fully understand why this is an unsolvable problem, seems like a very minor inconvenience only - and I don't mind helping where I can
eugenesiegel has joined #bitcoin-core-dev
<achow101>
it's an inconvenience to all translators, and an inconvenience to the maintainers for the next 2 years. I don't think that's "very minor"
<achow101>
*either an
<_aj_>
seems like it would be pretty easy to change update-translations to do it automatically
Ademan has joined #bitcoin-core-dev
<l0rinc>
we will have the same problem again regardless of this particular issue
<stickies-v>
nothing against the change but i'm not sure it's worth spending this much time on tbh
Guest29 has left #bitcoin-core-dev [#bitcoin-core-dev]
<achow101>
stickies-v: right, is changing the string worth this much energy?
<achow101>
l0rinc: why do you think we would have the same problem again?
<l0rinc>
refactoring and updating strings is happening daily
<achow101>
but not in the release branches, and generally not after translation strings freeze
<achow101>
once we branch off, we can strings as we want
<achow101>
this has been the process for at least a decade
<l0rinc>
ok, seems I'm still missing some details, I'll accept of course and try to understand it better
<stickies-v>
for #33189, maybe request review from some of the reviewers of the original PR? it was on my list for a while, but it's going to take me a lot more time than the many people familiar with the original pr
enochazariah has quit [Quit: Connection closed for inactivity]
sliv3r__ has quit [Ping timeout: 248 seconds]
sliv3r__ has joined #bitcoin-core-dev
w0xlt has joined #bitcoin-core-dev
w0xlt has quit [Ping timeout: 260 seconds]
w0xlt has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] hebasto closed pull request #32054: cmake, guix: Skip building tests in subtrees for releases (master...250313-test-binary) https://github.com/bitcoin/bitcoin/pull/32054
___nick___ has quit [Ping timeout: 260 seconds]
Talkless has quit [Quit: Konversation terminated!]
hugohn____ has quit [Server closed connection]
hugohn____ has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
l0rinc has quit [Client Quit]
MyNickname has joined #bitcoin-core-dev
MyNickname has quit [Read error: Connection reset by peer]
tqfoley has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
l0rinc has joined #bitcoin-core-dev
Cory95 has joined #bitcoin-core-dev
Cory82 has quit [Ping timeout: 250 seconds]
Cory61 has joined #bitcoin-core-dev
Cory95 has quit [Ping timeout: 250 seconds]
Cory71 has joined #bitcoin-core-dev
Cory61 has quit [Ping timeout: 250 seconds]
<bitcoin-git>
[bitcoin] achow101 opened pull request #33268: wallet: Identify transactions spending 0-value outputs, and add tests for anchor outputs in a wallet (master...zero-value-from-me) https://github.com/bitcoin/bitcoin/pull/33268