00:13
PaperSword has quit [Quit: PaperSword]
00:25
conman has quit [Remote host closed the connection]
00:33
jon_atack has joined #bitcoin-core-dev
00:34
jonatack has quit [Ping timeout: 240 seconds]
00:39
jonatack has joined #bitcoin-core-dev
00:41
jon_atack has quit [Ping timeout: 252 seconds]
00:45
jerryf has quit [Ping timeout: 240 seconds]
00:47
jerryf has joined #bitcoin-core-dev
00:58
jon_atack has joined #bitcoin-core-dev
00:59
jonatack has quit [Ping timeout: 255 seconds]
01:10
_durandal has joined #bitcoin-core-dev
01:10
conman has joined #bitcoin-core-dev
01:13
durandal_ has quit [Ping timeout: 240 seconds]
01:19
zeropoint has quit [Quit: leaving]
01:20
jonatack has joined #bitcoin-core-dev
01:22
jon_atack has quit [Ping timeout: 252 seconds]
01:44
l0rinc has quit [Quit: l0rinc]
02:01
Guest1 has joined #bitcoin-core-dev
02:08
Guest1 has quit [Quit: Client closed]
02:08
joetor5 has joined #bitcoin-core-dev
02:25
bitdex has joined #bitcoin-core-dev
02:29
twistedline has quit []
02:30
bitcoinlover has joined #bitcoin-core-dev
02:34
twistedline has joined #bitcoin-core-dev
03:04
jon_atack has joined #bitcoin-core-dev
03:06
jonatack has quit [Ping timeout: 255 seconds]
03:16
jon_atack has quit [Ping timeout: 252 seconds]
03:18
joetor5 has quit [Quit: joetor5]
03:39
l0rinc has joined #bitcoin-core-dev
04:01
cmirror has quit [Remote host closed the connection]
04:01
cmirror has joined #bitcoin-core-dev
05:45
bitcoinlover has quit [Ping timeout: 260 seconds]
06:00
Christoph_ has joined #bitcoin-core-dev
06:03
l0rinc has quit [Quit: l0rinc]
06:14
BlueMattMtrxBot has quit [Server closed connection]
06:14
BlueMattMtrxBot has joined #bitcoin-core-dev
06:21
kevkevin has quit [Remote host closed the connection]
06:31
Guest19 has joined #bitcoin-core-dev
06:32
WizJin_ has joined #bitcoin-core-dev
06:32
WizJin_ has quit [Remote host closed the connection]
06:32
WizJin_ has joined #bitcoin-core-dev
06:33
Guest19 has quit [Client Quit]
06:34
WizJin_ has quit [Client Quit]
06:36
kevkevin has joined #bitcoin-core-dev
06:37
Guest95 has joined #bitcoin-core-dev
06:38
Guest95 has left #bitcoin-core-dev [#bitcoin-core-dev]
06:41
kevkevin has quit [Ping timeout: 260 seconds]
06:55
Guest67 has joined #bitcoin-core-dev
06:55
Guest30 has joined #bitcoin-core-dev
06:56
Guest67 has quit [Client Quit]
07:05
WizJin has joined #bitcoin-core-dev
07:06
Guest30 has quit [Quit: Client closed]
07:08
kevkevin has joined #bitcoin-core-dev
07:13
kevkevin has quit [Ping timeout: 255 seconds]
07:16
<
fanquake >
must be the new drive-by trend
07:20
f321x has joined #bitcoin-core-dev
07:23
f321x has quit [Remote host closed the connection]
07:26
f321x has joined #bitcoin-core-dev
07:27
Christoph_ has quit [Quit: Christoph_]
07:35
dviola has quit [Quit: WeeChat 4.7.0]
07:41
robszarka has joined #bitcoin-core-dev
07:44
szarka has quit [Ping timeout: 260 seconds]
07:52
bitcoinlover has joined #bitcoin-core-dev
08:00
kevkevin has joined #bitcoin-core-dev
08:00
Guyver2 has joined #bitcoin-core-dev
08:52
Christoph_ has joined #bitcoin-core-dev
09:04
kevkevin has quit [Ping timeout: 276 seconds]
09:19
robszarka has quit [Quit: Leaving]
09:19
szarka has joined #bitcoin-core-dev
09:28
kevkevin has joined #bitcoin-core-dev
09:31
Guyver2 has left #bitcoin-core-dev [Closing Window]
09:43
laanwj has quit [Server closed connection]
09:44
laanwj has joined #bitcoin-core-dev
10:10
shwouchk has quit [Read error: Connection reset by peer]
10:10
shwouchk has joined #bitcoin-core-dev
10:16
jerryf has quit [Remote host closed the connection]
10:16
jerryf has joined #bitcoin-core-dev
10:32
kevkevin has quit [Ping timeout: 260 seconds]
11:02
kevkevin has joined #bitcoin-core-dev
11:26
uasf has quit [Server closed connection]
11:27
uasf has joined #bitcoin-core-dev
11:38
joetor5 has joined #bitcoin-core-dev
11:56
aleggg has joined #bitcoin-core-dev
12:17
jonatack has joined #bitcoin-core-dev
12:17
warren has quit [Server closed connection]
12:18
warren has joined #bitcoin-core-dev
12:32
jespada has joined #bitcoin-core-dev
12:54
jon_atack has joined #bitcoin-core-dev
12:54
jonatack has quit [Ping timeout: 252 seconds]
12:59
jonatack has joined #bitcoin-core-dev
13:02
jon_atack has quit [Ping timeout: 252 seconds]
13:52
virtu has quit [Ping timeout: 260 seconds]
13:53
virtu has joined #bitcoin-core-dev
14:00
theStack has quit [Server closed connection]
14:10
joetor5 has quit [Quit: joetor5]
14:14
<
sipa >
hebasto: awesome!
14:14
<
hebasto >
gh glitch?
14:15
<
sipa >
the PRs are still there if you go to #12345
14:15
<
sipa >
just not listed
14:15
<
sipa >
in the overview
14:17
<
glozow >
finally, we did it guys, we're free!
14:23
<
bitcoin-git >
bitcoin/master db32280 willcl-ark: util: detect and warn when using exFAT on macOS
14:23
<
bitcoin-git >
bitcoin/master ec484bd merge-script: Merge bitcoin/bitcoin#31453: util: detect and warn when using exFAT on Mac...
14:24
Guest25 has joined #bitcoin-core-dev
14:24
Guest25 has quit [Client Quit]
14:36
jon_atack has joined #bitcoin-core-dev
14:38
jonatack has quit [Ping timeout: 245 seconds]
14:45
janb84 has joined #bitcoin-core-dev
14:48
jonatack has joined #bitcoin-core-dev
14:50
jon_atack has quit [Ping timeout: 260 seconds]
14:59
jon_atack has joined #bitcoin-core-dev
14:59
jonatack has quit [Ping timeout: 260 seconds]
15:11
jonatack has joined #bitcoin-core-dev
15:13
jon_atack has quit [Ping timeout: 255 seconds]
15:21
zeropoint has joined #bitcoin-core-dev
15:30
jon_atack has joined #bitcoin-core-dev
15:31
visiteur has joined #bitcoin-core-dev
15:32
zeropoint has quit [Ping timeout: 248 seconds]
15:32
jonatack has quit [Ping timeout: 248 seconds]
15:33
l0rinc has joined #bitcoin-core-dev
15:35
jonatack has joined #bitcoin-core-dev
15:37
jon_atack has quit [Ping timeout: 248 seconds]
15:54
bugs_ has joined #bitcoin-core-dev
15:54
visiteur has quit [K-Lined]
15:59
LUKASZICHO has joined #bitcoin-core-dev
15:59
l0rinc has quit [Quit: l0rinc]
16:00
LUKASZICHO has quit [Client Quit]
16:01
l0rinc has joined #bitcoin-core-dev
16:01
Christoph_ has quit [Ping timeout: 260 seconds]
16:03
bitcoinlover has quit [Ping timeout: 252 seconds]
16:04
Christoph_ has joined #bitcoin-core-dev
16:16
ghost43_ has joined #bitcoin-core-dev
16:16
ghost43 has quit [Ping timeout: 240 seconds]
16:26
stringintech has joined #bitcoin-core-dev
16:27
jespada has quit [Ping timeout: 248 seconds]
16:28
l0rinc has quit [Quit: l0rinc]
16:28
<
Sjors[m]1 >
I'd like to propose #31802 for the v30 milestone, if only to discuss if it needs to be punted to the next release again.
16:30
jespada has joined #bitcoin-core-dev
16:34
purpleKarrot has joined #bitcoin-core-dev
16:41
stringintech has quit [Changing host]
16:41
stringintech has joined #bitcoin-core-dev
16:42
stringintech has quit [Quit: Client closed]
16:43
theStack has joined #bitcoin-core-dev
16:43
stringintech has joined #bitcoin-core-dev
16:53
jon_atack has joined #bitcoin-core-dev
16:55
jonatack has quit [Ping timeout: 252 seconds]
16:56
jespada has quit [Ping timeout: 252 seconds]
16:56
jespada has joined #bitcoin-core-dev
16:58
josie has quit [Server closed connection]
16:58
josie has joined #bitcoin-core-dev
16:58
<
stringintech >
Reviewing IBD staller detection logic; the condition for setting the staller variable in FindNextBlocks() differs from the condition for setting m_stalling_since for that staller after detection. The first condition checks if we've reached the end of the IBD window and found no blocks to download from the peer, but the second checks if there are
16:58
<
stringintech >
any in-flight requests from that peer (which could include block requests from earlier). I wondered whether this difference is intentional. (I can think of a scenario where no in-flight requests are resolved from any peer and we wouldn't trigger the timeout for any peer until the in-flight requests are cleared)
17:02
stringintech10 has joined #bitcoin-core-dev
17:03
f321x has quit [Quit: f321x]
17:03
stringintech10 has quit [Client Quit]
17:04
stringintech73 has joined #bitcoin-core-dev
17:06
stringintech has quit [Ping timeout: 250 seconds]
17:06
stringintech73 has quit [Client Quit]
17:06
stringintech has joined #bitcoin-core-dev
17:29
jonatack has joined #bitcoin-core-dev
17:31
<
sipa >
stringintech: hmm
17:31
zeropoint has joined #bitcoin-core-dev
17:32
jon_atack has quit [Ping timeout: 276 seconds]
17:32
<
sipa >
i'm probably the author of that code, but i don't recall that being intentional
17:32
<
sipa >
it's also possible it has been changed since i wrote it
17:38
<
stringintech >
sipa: Thanks! Wouldn't it make more sense if the second one would check for vToDownload.empty() instead of state.vBlocksInFlight.empty() since we could have requested a block from this peer but we could not because of the staller?
17:46
WizJin_ has joined #bitcoin-core-dev
17:50
WizJin has quit [Ping timeout: 260 seconds]
17:52
stringintech has quit [Ping timeout: 250 seconds]
17:54
stringintech has joined #bitcoin-core-dev
18:04
stringintech has quit [Ping timeout: 250 seconds]
18:04
jon_atack has joined #bitcoin-core-dev
18:05
jonatack has quit [Ping timeout: 252 seconds]
18:06
bugs_ has quit [Quit: Leaving]
18:28
l0rinc has joined #bitcoin-core-dev
18:33 ___nick___ has joined #bitcoin-core-dev
18:33 ___nick___ has quit [Client Quit]
18:34
<
bitcoin-git >
bitcoin/master 0173788 Ryan Ofsky: wallet: Translate [default wallet] string in progress messages
18:34
<
bitcoin-git >
bitcoin/master db225ce Ryan Ofsky: wallet, refactor: Replace GetDisplayName() with LogName()
18:34
<
bitcoin-git >
bitcoin/master 73972d5 Ava Chow: Merge bitcoin/bitcoin#31296: wallet: Translate [default wallet] string in ...
18:35 ___nick___ has joined #bitcoin-core-dev
18:40
l0rinc has quit [Quit: l0rinc]
18:41
l0rinc has joined #bitcoin-core-dev
18:44
Christoph_ has quit [Quit: Christoph_]
19:03
jonatack has joined #bitcoin-core-dev
19:05
jon_atack has quit [Ping timeout: 272 seconds]
19:06
jespada_ has joined #bitcoin-core-dev
19:09
jespada has quit [Ping timeout: 276 seconds]
19:22 ___nick___ has quit [Ping timeout: 252 seconds]
19:48
bitdex has quit [Ping timeout: 240 seconds]
19:54
l0rinc has quit [Quit: l0rinc]
20:07
VonNaturAustreVe has joined #bitcoin-core-dev
20:13
bitdex has joined #bitcoin-core-dev
20:33
zeropoint has quit [Quit: leaving]
20:34
jon_atack has joined #bitcoin-core-dev
20:36
jonatack has quit [Ping timeout: 272 seconds]
20:54
purpleKarrot has quit [Quit: purpleKarrot]
20:54
purpleKarrot has joined #bitcoin-core-dev
20:57
BGL has quit [Ping timeout: 248 seconds]
20:58
l0rinc has joined #bitcoin-core-dev
21:19
jonatack has joined #bitcoin-core-dev
21:22
jon_atack has quit [Ping timeout: 252 seconds]
21:33
jon_atack has joined #bitcoin-core-dev
21:35
jonatack has quit [Ping timeout: 252 seconds]
21:35
<
bitcoin-git >
bitcoin/master 266dd0e Anthony Towns: net_processing: drop MaybePunishNodeForTx
21:35
<
bitcoin-git >
bitcoin/master b29ae9e Anthony Towns: validation: only check input scripts once
21:35
<
bitcoin-git >
bitcoin/master 876dbdf Anthony Towns: tests: drop expect_disconnect behaviour for tx relay
21:49
PaperSword has joined #bitcoin-core-dev
21:54
PaperSword has quit [Client Quit]
22:03
joetor5 has joined #bitcoin-core-dev
22:09
jerryf has quit [Ping timeout: 240 seconds]
22:10
ghost43 has joined #bitcoin-core-dev
22:10
ghost43_ has quit [Ping timeout: 240 seconds]
22:11
jerryf has joined #bitcoin-core-dev
22:23
nymius has joined #bitcoin-core-dev
22:24
BGL has joined #bitcoin-core-dev
22:30
l0rinc has quit [Quit: l0rinc]
22:33
flag has quit [Ping timeout: 265 seconds]
22:34
flag has joined #bitcoin-core-dev
22:37
l0rinc has joined #bitcoin-core-dev
22:42
purpleKarrot has quit [Quit: purpleKarrot]
22:43
purpleKarrot has joined #bitcoin-core-dev
22:47
aleggg has quit [Ping timeout: 260 seconds]
22:53
jonatack has joined #bitcoin-core-dev
22:54
jon_atack has quit [Ping timeout: 252 seconds]
23:00
jon_atack has joined #bitcoin-core-dev
23:01
jonatack has quit [Ping timeout: 252 seconds]
23:04
l0rinc has quit [Quit: l0rinc]
23:11
nymius has quit [Quit: nymius]
23:13
jonatack has joined #bitcoin-core-dev
23:14
jon_atack has quit [Ping timeout: 248 seconds]
23:19
VonNaturAustreVe has quit [Ping timeout: 255 seconds]
23:31
<
lightlike >
stringintech: (not online but maybe you'll see this in the logs) I think the idea behind the stalling logic is that we are in a stalling situation when a peer that could do work for us has to become idle because we can't assign it any.
23:31
<
lightlike >
We don't require that its assigned queue of 16 blocks must be full all of the time. So as long as state.vBlocksInFlight is non-empty, we are not in a stalling case yet, because the peer has still work scheduled and isn't idle.
23:48
<
lightlike >
I think the suggested alternative would also be possible (require all queues to be at the MAX_BLOCKS_IN_TRANSIT_PER_PEER limit), it would be stricter, resulting in earlier (and therefore more) stalling disconnections. I don't think though that any of the two approaches is inconsistent.
23:53
VonNaturAustreVe has joined #bitcoin-core-dev
23:59
VonNaturAustreVe has quit [Ping timeout: 255 seconds]
23:59
l0rinc has joined #bitcoin-core-dev