<fanquake>
Aren't major releases *the* time when we make breaking changes to interfaces?
<Sjors[m]1>
fanquake: yes, what I'm saying is that we shouldn't start merging breaking interface changes into master until we have one that's actually important
<Sjors[m]1>
That's why I 'm collecting them in a PR for now. But most changes aren't actually breaking, so those can be merged as we go.
<fanquake>
Isn't that only a problem if people are running master in production?
<bitcoin-git>
bitcoin/master 79d6f45 fanquake: random: scope environ extern to macOS, BSDs and Illumos
<bitcoin-git>
bitcoin/master 96614ff Hennadii Stepanov: Merge bitcoin/bitcoin#33714: random: scope environ extern to macOS, BSDs a...
<bitcoin-git>
[bitcoin] hebasto merged pull request #33714: random: scope environ extern to macOS, BSDs and Illumos (master...drop_some_platforms) https://github.com/bitcoin/bitcoin/pull/33714
<fanquake>
In which case, anything already goes?
<Sjors[m]1>
It's possible v31 won't have any breaking changes, depends on the pace of things.
<fanquake>
Still not sure I understand the problem. The inerface is experimental, and there are currently no guarantees made? Why do we need to start trying to enforce some sort of interface stability in master, via merge order or similar?
<fanquake>
(again, this only being a problem if people are running/continually compiling master in production, which is already all bets off?)
<Sjors[m]1>
I'm not talking about people running on master. I'm talking about people who use v30 now and v31 later.
<Sjors[m]1>
If we don't have to break things, we shouldn't.
<Sjors[m]1>
Even though "experimental" certainly allows us to.
<fanquake>
Sure, but none of this seems special to the mining interface?
<fanquake>
If a breaking change is going into a release, it can be merged early in the cycle, or later, the effect on the release is still the same
<Sjors[m]1>
Yes, once we know a release is going to have a breaking change anyway, then we can just pile on breaking changes in any order.
<fanquake>
Doesn't that kinda defeat the point of it currently being unstable?
<Sjors[m]1>
I don't believe so. It lowers the bar for us to make breaking changes, but the bar doesn't have to be zero.
<Sjors[m]1>
We also haven't decided on a versioning mechanism for the interface yet. Once we do it will easier to communicate to client devs how to deal with breaking changes.
flow has quit [Quit: WeeChat 4.5.2]
flow has joined #bitcoin-core-dev
jerryf_ has quit [Remote host closed the connection]
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
flow has quit [Quit: WeeChat 4.5.2]
flow has joined #bitcoin-core-dev
<fanquake>
CI seems to be holding up pretty well against merge stack & cache thrashing
l0rinc has quit [Remote host closed the connection]
l0rinc has joined #bitcoin-core-dev
<TheCharlatan>
nice :)
<bitcoin-git>
[bitcoin] fanquake opened pull request #33778: depends: add zeromq patch to fix mingw CMake file install location (master...mingw_zmq_cmake_install) https://github.com/bitcoin/bitcoin/pull/33778
AaronvanW has quit [Remote host closed the connection]
l0rinc has quit [Ping timeout: 244 seconds]
l0rinc has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 264 seconds]
zeropoint has joined #bitcoin-core-dev
memset_ has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] hebasto opened pull request #33779: ci, iwyu: Fix warnings in `src/kernel` and treat them as errors (master...251104-force-iwyu-kernel) https://github.com/bitcoin/bitcoin/pull/33779
AaronvanW has joined #bitcoin-core-dev
memset has quit [Ping timeout: 272 seconds]
AaronvanW has quit [Ping timeout: 240 seconds]
AaronvanW has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 252 seconds]
jonatack has joined #bitcoin-core-dev
purpleKarrot has quit [Quit: purpleKarrot]
l0rinc has quit [Quit: l0rinc]
<bitcoin-git>
[bitcoin] fanquake opened pull request #33780: guix: disable libsanitizer in Linux GCC build (master...gcc_disable_libsanitizer) https://github.com/bitcoin/bitcoin/pull/33780
<bitcoin-git>
[bitcoin] Mystique85 opened pull request #33784: Improve SHA256 x86 SHANI code safety and consistency (no functional changes) (master...master) https://github.com/bitcoin/bitcoin/pull/33784
<bitcoin-git>
[bitcoin] DrahtBot closed pull request #33784: Improve SHA256 x86 SHANI code safety and consistency (no functional changes) (master...master) https://github.com/bitcoin/bitcoin/pull/33784
___nick___ has quit [Ping timeout: 244 seconds]
<bitcoin-git>
[bitcoin] maflcko opened pull request #33785: util: Allow Assert() in contexts without __func__ (master...2511-assert-func) https://github.com/bitcoin/bitcoin/pull/33785
l0rinc has joined #bitcoin-core-dev
ojwXOKSIwV9QNCxx has quit [K-Lined]
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 264 seconds]
windsok has quit [*.net *.split]
tarotfied has quit [*.net *.split]
sliv3r__ has quit [*.net *.split]
_flooded has quit [*.net *.split]
bugs_ has quit [*.net *.split]
BGL has quit [*.net *.split]
Holz has quit [*.net *.split]
cstrm has quit [*.net *.split]
fjahr has quit [*.net *.split]
TallTim has quit [*.net *.split]
dlb76 has quit [*.net *.split]
synexic has quit [*.net *.split]
infernix has quit [*.net *.split]
stevenroose has quit [*.net *.split]
kevkevin has quit [*.net *.split]
flag has quit [*.net *.split]
twistedline has quit [*.net *.split]
jamesob443688173 has quit [*.net *.split]
johnzwen- has quit [*.net *.split]
Zenton has quit [*.net *.split]
jon_atack has quit [*.net *.split]
flow has quit [*.net *.split]
durandal_ has quit [*.net *.split]
achow101 has quit [*.net *.split]
corebot has quit [*.net *.split]
chjj has quit [*.net *.split]
bitcoin-git has quit [*.net *.split]
aleggg has quit [*.net *.split]
cmirror has quit [*.net *.split]
justache has quit [*.net *.split]
EPiSKiNG- has quit [*.net *.split]
josie has quit [*.net *.split]
TheCharlatan has quit [*.net *.split]
Earnestly has quit [*.net *.split]
dergoegge has quit [*.net *.split]
elichai2 has quit [*.net *.split]
sr_gi[m]1 has quit [*.net *.split]
katsu has quit [*.net *.split]
eragmus___ has quit [*.net *.split]
oribellow has quit [*.net *.split]
TheRec_ has quit [*.net *.split]
maflcko has quit [*.net *.split]
spynxic has quit [*.net *.split]
BlueMatt has quit [*.net *.split]
cfields has quit [*.net *.split]
RubenSomsen has quit [*.net *.split]
Sjors[m]1 has quit [*.net *.split]
jerryf_ has quit [*.net *.split]
memset has quit [*.net *.split]
afiore has quit [*.net *.split]
vasild has quit [*.net *.split]
ghost43 has quit [*.net *.split]
SpellChecker has quit [*.net *.split]
cm has quit [*.net *.split]
laanwj has quit [*.net *.split]
BlueMattMtrxBot has quit [*.net *.split]
S3RK_ has quit [*.net *.split]
dermoth has quit [*.net *.split]
edouardparis_ has quit [*.net *.split]
P8tBoy has quit [*.net *.split]
Ademan has quit [*.net *.split]
jimhhq has quit [*.net *.split]
maxedw__ has quit [*.net *.split]
Anth0mk has quit [*.net *.split]
l0rinc has quit [*.net *.split]
cold has quit [*.net *.split]
Nebraskka has quit [*.net *.split]
roconnor has quit [*.net *.split]
warren has quit [*.net *.split]
hodlinator has quit [*.net *.split]
pablomartin4btc has quit [*.net *.split]
pinheadmz has quit [*.net *.split]
JTL has quit [*.net *.split]
Chris_St1 has quit [*.net *.split]
szkl has quit [*.net *.split]
cornfeedhobo has quit [*.net *.split]
jetpack has quit [*.net *.split]
javi404 has quit [*.net *.split]
cotsuka_ has quit [*.net *.split]
angusp has quit [*.net *.split]
tinova4 has quit [*.net *.split]
meebey_ has quit [*.net *.split]
uasf has quit [*.net *.split]
nickler has quit [*.net *.split]
marcofleon has quit [*.net *.split]
jesseposner has quit [*.net *.split]
stratospher[m] has quit [*.net *.split]
BlueMattTest1 has quit [*.net *.split]
Murch[m] has quit [*.net *.split]
jrayhawk has quit [*.net *.split]
rogeliodh has quit [*.net *.split]
janb84 has quit [*.net *.split]
jamesob1566593 has quit [*.net *.split]
luke-jr_ has quit [*.net *.split]
jackielove4u2 has quit [*.net *.split]
Saturday7 has quit [*.net *.split]
b10c has quit [*.net *.split]
antanst has quit [*.net *.split]
darosior has quit [*.net *.split]
robobub has quit [*.net *.split]
_aj_ has quit [*.net *.split]
willcl-ark_ has quit [*.net *.split]
jon_atack has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
bugs_ has joined #bitcoin-core-dev
jerryf_ has joined #bitcoin-core-dev
memset has joined #bitcoin-core-dev
flow has joined #bitcoin-core-dev
luke-jr_ has joined #bitcoin-core-dev
aleggg has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
BGL has joined #bitcoin-core-dev
jackielove4u2 has joined #bitcoin-core-dev
Holz has joined #bitcoin-core-dev
S3RK_ has joined #bitcoin-core-dev
dermoth has joined #bitcoin-core-dev
windsok has joined #bitcoin-core-dev
cmirror has joined #bitcoin-core-dev
BlueMattMtrxBot has joined #bitcoin-core-dev
laanwj has joined #bitcoin-core-dev
cm has joined #bitcoin-core-dev
Chris_St1 has joined #bitcoin-core-dev
afiore has joined #bitcoin-core-dev
szkl has joined #bitcoin-core-dev
Saturday7 has joined #bitcoin-core-dev
justache has joined #bitcoin-core-dev
b10c has joined #bitcoin-core-dev
antanst has joined #bitcoin-core-dev
cornfeedhobo has joined #bitcoin-core-dev
cstrm has joined #bitcoin-core-dev
Zenton has joined #bitcoin-core-dev
Earnestly has joined #bitcoin-core-dev
jimhhq has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] l0rinc opened pull request #33786: script: remove dead code in `CountWitnessSigOps` (master...l0rinc/witness-pointer-to-reference) https://github.com/bitcoin/bitcoin/pull/33786