00:33 <dzxzg> with the PIMPL pattern for e.g. PeerMan and PeerManImpl, what is the philosophy for unit testing functions that are internal to PeerManImpl and don't need to be exposed through PeerMan? For e.g. the stale tip eviction unit test we export the internal function: https://github.com/bitcoin/bitcoin/blob/d5ed4ba9d8627f1897322ce7eb5b34e08e4f73ac/src/net_processing.h#L141-L142

00:34 <dzxzg> Is the answer to only test "public" interfaces?

00:53 <dzxzg> It just seems like esp. for peermanagerimpl, the scope of internal functions grows from a one-off utility to something with lots of users with various subtle expectations; to make it concrete, in the case of PeerManagerImpl::BlockRequested, would anyone object to continuing the approach of exporting stuff into the interface class just for the purpose of being used in unit tests?

01:42 <dzxzg> maybe this is just an argument for breaking stuff out of PeerManImpl into smaller chunks

02:44 <sipa> dzxzg: could make them protected, or make the test function/class a friend