<bitcoin-git>
[bitcoin] glozow reopened pull request #33565: net_processing: rename RelayTransaction to better describe what it does (master...rename_RelayTransaction) https://github.com/bitcoin/bitcoin/pull/33565
Cory31 has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
Cory95 has quit [Ping timeout: 250 seconds]
Cory38 has joined #bitcoin-core-dev
Cory31 has quit [Ping timeout: 250 seconds]
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 260 seconds]
kevkevin has quit [Ping timeout: 240 seconds]
kevkevin has joined #bitcoin-core-dev
Cory53 has joined #bitcoin-core-dev
Cory38 has quit [Ping timeout: 250 seconds]
kevkevin has quit [Remote host closed the connection]
Cory53 has quit [Quit: Client closed]
Cory53 has joined #bitcoin-core-dev
busy has quit [Quit: Leaving]
Cory20 has joined #bitcoin-core-dev
Cory58 has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
Cory53 has quit [Ping timeout: 250 seconds]
Cory20 has quit [Ping timeout: 250 seconds]
Cory30 has joined #bitcoin-core-dev
Cory58 has quit [Ping timeout: 250 seconds]
kevkevin has quit [Remote host closed the connection]
Cory36 has joined #bitcoin-core-dev
SN has joined #bitcoin-core-dev
SN has quit [Client Quit]
Cory30 has quit [Ping timeout: 250 seconds]
Cory30 has joined #bitcoin-core-dev
Cory36 has quit [Ping timeout: 250 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
Saturday7 has quit [Read error: Connection reset by peer]
Saturday7 has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
Cory7 has joined #bitcoin-core-dev
Cory30 has quit [Ping timeout: 250 seconds]
Cory6 has joined #bitcoin-core-dev
cstrm has quit [Read error: Connection reset by peer]
cstrm has joined #bitcoin-core-dev
Cory7 has quit [Ping timeout: 250 seconds]
jerryf_ has quit [Remote host closed the connection]
jerryf has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Ping timeout: 244 seconds]
Saturday7 has quit [Read error: Connection reset by peer]
Saturday7 has joined #bitcoin-core-dev
Chris_Stewart_5 has joined #bitcoin-core-dev
abubakarsadiq has quit [Quit: Connection closed for inactivity]
kevkevin has quit [Ping timeout: 265 seconds]
f321x has joined #bitcoin-core-dev
f321x has quit [Remote host closed the connection]
f321x has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
AaronvanW has quit [Remote host closed the connection]
<bitcoin-git>
[bitcoin] fanquake merged pull request #33785: util: Allow `Assert` (et al.) in contexts without __func__ (master...2511-assert-func) https://github.com/bitcoin/bitcoin/pull/33785
szarka has quit [Ping timeout: 265 seconds]
kevkevin has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
kevkevin has quit [Ping timeout: 265 seconds]
Cory6 has quit [Quit: Client closed]
Cory6 has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [Closing Window]
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
Cory6 has quit [Quit: Client closed]
Cory6 has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
flooded has joined #bitcoin-core-dev
memset has joined #bitcoin-core-dev
afiore has quit [Remote host closed the connection]
Cory6 has quit [Quit: Client closed]
afiore has joined #bitcoin-core-dev
Cory6 has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
kevkevin has quit [Ping timeout: 246 seconds]
memset has joined #bitcoin-core-dev
<pinheadmz>
is there still a matrix bridge to this channel ?
<sipa>
BlueMatt: ^
jerryf_ has joined #bitcoin-core-dev
Emzy has joined #bitcoin-core-dev
jerryf has quit [Remote host closed the connection]
jerryf_ has quit [Remote host closed the connection]
jerryf has joined #bitcoin-core-dev
<laanwj>
pinheadmz: yes, see PM
<laanwj>
re: #33181, still working on it. build on RISC-V is going to take a while. i started one on a emulator and on a RISC-V machine, but i forgot how long the guix bootstrapping takes. i don't think any of them will finish any time soon
<bitcoin-git>
[bitcoin] maflcko opened pull request #33840: test: [refactor] Use reference over ptr to chainman (master...2511-assert-func) https://github.com/bitcoin/bitcoin/pull/33840
pinheadmz[m] has joined #bitcoin-core-dev
<darosior>
laanwj: curious what risc-v machine you got?
kevkevin has quit [Ping timeout: 250 seconds]
<bitcoin-git>
[bitcoin] hebasto opened pull request #33841: cmake: Switch to `minisketch` upstream build system (master...251110-minisketch) https://github.com/bitcoin/bitcoin/pull/33841
<bitcoin-git>
[bitcoin] fanquake merged pull request #33433: test: rpc_bind: Skip nonloopback test if no such address is found (master...qafix_rpc_bind_nonloopback_unavail) https://github.com/bitcoin/bitcoin/pull/33433
jon_atack has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] fanquake closed pull request #30059: Add option dbfilesize to control LevelDB target ("max") file size (master...dbfilesize_param) https://github.com/bitcoin/bitcoin/pull/30059
jonatack has quit [Ping timeout: 252 seconds]
<fanquake>
Has Drahtbot has gone awol? All it's comments are gone, and it's not adding labels / ACK comments to new PRs
flooded has quit [Remote host closed the connection]
flooded has joined #bitcoin-core-dev
<dergoegge>
rip drahtbot
<fanquake>
I'm wondering if the newest AI anti-spam features, have triggered some GH anti-spam feature, and got the account banned
<sipa>
github's AI anti-spam doesn't like competition from other AI anti-spam bots?
AaronvanW has quit [Remote host closed the connection]
<darosior>
Re #33843 ^. I think this trend to trim down PR beyond reasonable is not a good one. It seems that when a PR is not attracting proper review on the totality of the effort, individual commits sometimes get pushed individually where they 1) don't quite make sense on their own and 2) each go with shallower review.
<vasild>
darosior: Are you saying that it is not reasonable to have tests added in a followup PR? Those tests are more than half of the size of the actual code changes (tests ~500 lines, actual code changes ~1000 lines).
<fanquake>
Why can't they be added and reviewed, with the new feature they are testing?
<fanquake>
I think the comment about splitting up PRs is likely also in regards to PRs like #33565, where things are getting very granular. 1 PR per function rename, is surely pushing limits. (not exactly clear why that was reopened, given the 2 NACKs)
<corebot>
https://github.com/bitcoin/bitcoin/issues/33565 | net_processing: rename RelayTransaction to better describe what it does by vasild · Pull Request #33565 · bitcoin/bitcoin · GitHub
<fanquake>
"not to burden the main one," isn't much of a reasoning?
<fanquake>
What is the burden exactly
<vasild>
#33565 has no NACKs
<corebot>
https://github.com/bitcoin/bitcoin/issues/33565 | net_processing: rename RelayTransaction to better describe what it does by vasild · Pull Request #33565 · bitcoin/bitcoin · GitHub
Cory14 has joined #bitcoin-core-dev
<sipa>
Specifically for tests, I think they belong as close to the feature changes they are for, in the same PR, and even within the same PR, as close to the commit with the changes. The purpose of tests is convincing reviewers that the code changes are correct! Making reviewers go look at a different PR for that seems entirely counter-productive.
<vasild>
fanquake: reviewing 1500 lines vs reviewing 1000 lines
<darosior>
vasild: not picking on you in particular, but i think both #29415 and #33843 are examples of this trend. It sometimes makes a lot of sense to split up some commits. It seems here this is used to get changes in with less review, which i think should be resisted.
<corebot>
https://github.com/bitcoin/bitcoin/issues/29415 | Broadcast own transactions only via short-lived Tor or I2P connections by vasild · Pull Request #29415 · bitcoin/bitcoin · GitHub
<fanquake>
vasild: " I guess people can look at just that for code changes and tests and ACK that one directly?" why can't the do the same with 29415, if you just leave the tests in there?
Cory6 has quit [Ping timeout: 250 seconds]
<sipa>
if the tiny split-off change gets reviewed and merged, but the big feature PR doesn't get review, what's the point?
<vasild>
sipa: this way the code changes and the tests can be reviewed by different sets of people (the reasoning for splitting any PR into smaller pieces)
Cory14 has quit [Ping timeout: 250 seconds]
<sipa>
vasild: i think that is entirely backwards
<sipa>
those _should_ be the same people
<fanquake>
they can still do that with both in one pr though
<sipa>
because the purpose of tests is convincing reviewers
<sipa>
(that's an argument specifically against splitting off tests, it's not an argument against splitting off things in general)
Cory97 has joined #bitcoin-core-dev
<vasild>
fanquake: can do the same with 29415 if it has the tests, but then there is no option to review and ACK without the tests
<fanquake>
Anyone can ack whatever specific commit hashes they want
<fanquake>
I haven't seen any compelling argument to defer adding tests until after adding a new feature
<vasild>
fair enough
jackielove4u has quit [Quit: Ping timeout (120 seconds)]
joetor5 has quit [Remote host closed the connection]
Cory87 has quit [Ping timeout: 250 seconds]
flooded has quit [Remote host closed the connection]
joetor5 has joined #bitcoin-core-dev
flooded has joined #bitcoin-core-dev
joetor5 has quit [Changing host]
joetor5 has joined #bitcoin-core-dev
dermoth has quit [Read error: Connection reset by peer]
Cory35 has quit [Ping timeout: 250 seconds]
jon_atack has joined #bitcoin-core-dev
Cory67 has joined #bitcoin-core-dev
dermoth has joined #bitcoin-core-dev
Cory20 has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 260 seconds]
Cory91 has joined #bitcoin-core-dev
Cory80 has quit [Ping timeout: 250 seconds]
Cory67 has quit [Ping timeout: 250 seconds]
<laanwj>
darosior: i'm building on this kind of server right now: https://labs.scaleway.com/en/em-rv1/ . i want to get one of the starfive visionfive 2 boards for at home, though. currently i only have old sifive unleashed/unmatched, but they could never handle guix builds without crashing *sigh*
Cory20 has quit [Ping timeout: 250 seconds]
jonatack has joined #bitcoin-core-dev
joetor5 has quit [Remote host closed the connection]
jon_atack has quit [Ping timeout: 260 seconds]
Cory96 has joined #bitcoin-core-dev
Talkless has joined #bitcoin-core-dev
Cory91 has quit [Ping timeout: 250 seconds]
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 252 seconds]
l0rinc has quit [Ping timeout: 244 seconds]
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
Cory22 has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
Cory96 has quit [Ping timeout: 250 seconds]
jon_atack has quit [Ping timeout: 264 seconds]
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
<sliv3r__>
Is draftbot dead? Cannot see anymore his comments on PRs, including the acks summary.
jon_atack has joined #bitcoin-core-dev
<sipa>
sliv3r__: it appears to have been nuked from orbit
jonatack has quit [Ping timeout: 244 seconds]
<sliv3r__>
RIP :'(
memset_ has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
kinlo has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 264 seconds]
flooded has quit [Remote host closed the connection]
flooded has joined #bitcoin-core-dev
Talkless has quit [Quit: Konversation terminated!]
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 244 seconds]
Cory48 has joined #bitcoin-core-dev
Cory72 has joined #bitcoin-core-dev
Cory22 has quit [Ping timeout: 250 seconds]
Cory48 has quit [Ping timeout: 250 seconds]
jon_atack has quit [Ping timeout: 244 seconds]
jonatack has joined #bitcoin-core-dev
memset_ has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
kevkevin_ has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 256 seconds]
Cory26 has joined #bitcoin-core-dev
Cory30 has joined #bitcoin-core-dev
Cory72 has quit [Ping timeout: 250 seconds]
<darosior>
Surely Github deletes this way because of the asymmetry LLMs gave to spam, but doesn't erase the data on the backend for a little while
<sipa>
we've seen "deleted" accounts come back, including all their comments
Cory26 has quit [Ping timeout: 250 seconds]
<sipa>
ryanofsky: where is the magic code that (in 32297, e.g.) converts between UniValue request, and "request :Text", which seems like a string type?