memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
memset has quit [Ping timeout: 272 seconds]
memset has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
hacker4web3bitco has joined #bitcoin-core-dev
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
Saturday7 has quit [Read error: Connection reset by peer]
Saturday7 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
bitdex has quit [Ping timeout: 272 seconds]
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
Guest87 has joined #bitcoin-core-dev
Guest87 has quit [Client Quit]
kevkevin has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 250 seconds]
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
AaronvanW has quit [Remote host closed the connection]
AaronvanW has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 246 seconds]
l0rinc has quit [Quit: l0rinc]
kevkevin has joined #bitcoin-core-dev
f321x has joined #bitcoin-core-dev
AaronvanW has quit [Remote host closed the connection]
AaronvanW has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
AaronvanW has quit [Remote host closed the connection]
Guyver2 has left #bitcoin-core-dev [Closing Window]
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
magellan has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] l0rinc opened pull request #33805: merkle: migrate `path` arg to reference and drop unused args (master...l0rinc/ComputeMerklePath-dead-code) https://github.com/bitcoin/bitcoin/pull/33805
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 244 seconds]
memset has quit [Remote host closed the connection]
kevkevin has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
magellan has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
kevkevin has quit [Ping timeout: 264 seconds]
memset has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 244 seconds]
kevkevin has joined #bitcoin-core-dev
Guest34 has joined #bitcoin-core-dev
Guest34 has quit [Client Quit]
kevkevin has quit [Ping timeout: 252 seconds]
<bitcoin-git>
[bitcoin] waketraindev opened pull request #33807: qt: Comment out sensitive commands in history to prevent re-execution (master...2025-11-gui-comment-sensitive-commands) https://github.com/bitcoin/bitcoin/pull/33807
brunoerg has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] waketraindev closed pull request #33807: qt: Comment out sensitive commands in history to prevent re-execution (master...2025-11-gui-comment-sensitive-commands) https://github.com/bitcoin/bitcoin/pull/33807
<bitcoin-git>
[gui] waketraindev opened pull request #909: qt: Comment out sensitive commands in history to prevent re-execution (master...2025-11-gui-comment-sensitive-commands) https://github.com/bitcoin-core/gui/pull/909
magellan has quit [Quit: WeeChat 4.7.1]
jonatack has joined #bitcoin-core-dev
AaronvanW has quit [Remote host closed the connection]
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 244 seconds]
kevkevin has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
kevkevin has quit [Ping timeout: 246 seconds]
eugenesiegel has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
Novo__ has joined #bitcoin-core-dev
eugenesiegel7 has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 260 seconds]
eugenesiegel has quit [Ping timeout: 250 seconds]
enochazariah has joined #bitcoin-core-dev
AaronvanW has quit [Remote host closed the connection]
eugenesiegel7 has quit [Quit: Client closed]
brunoerg has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
magellan has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
enochazariah has quit [Ping timeout: 250 seconds]
abubakarsadiq has joined #bitcoin-core-dev
hacker4web3bitco has quit [Ping timeout: 244 seconds]
magellan has quit [Ping timeout: 260 seconds]
magellan has joined #bitcoin-core-dev
magellan has quit [Ping timeout: 256 seconds]
magellan has joined #bitcoin-core-dev
enochazariah has joined #bitcoin-core-dev
Emc99 has joined #bitcoin-core-dev
magellan has quit [Ping timeout: 246 seconds]
dzxzg has joined #bitcoin-core-dev
purpleKarrot has joined #bitcoin-core-dev
<stickies-v>
#startmeeting
<corebot>
stickies-v: Meeting started at 2025-11-06T16:00+0000
<stickies-v>
There are no pre-proposed meeting topics this week. Any last minute ones to add?
<fjahr>
hi
<sipa>
hi ish
<stringintech>
hi
<b10c>
hi
magellan has joined #bitcoin-core-dev
<marcofleon>
hi
<shiza>
hi
<fjahr>
all hail the new chair stickies-v ;)
<abubakarsadiq>
hi
<cfields>
I second the motion to hail stickies-v.
<stickies-v>
let's start with the WG updates. i'll be moving on quickly, so please make sure to have your update (or acknowledgement that you're writing something) ready
stringintech has quit [Client Quit]
<stickies-v>
#topic Erlay WG Update (sr_gi)
<yancy>
hi
<kevkevin>
(ﾉ◕ヮ◕)ﾉ hail stickies-v
<stickies-v>
#topic Fuzzing WG Update (dergoegge)
<dzxzg>
hi
stringintech has joined #bitcoin-core-dev
<stickies-v>
#topic Kernel WG Update (TheCharlatan)
<stickies-v>
feels nice being able to open small pull requests
<fjahr>
👏
<TheCharlatan>
feels weird no longer having to checkout that branch anymore :P
<TheCharlatan>
There will be a bunch of follow-up PRs as more people start developing against it and find some things either overlooked during the review cycles, or still not sufficiently polished.
<l0rinc>
congrats
<TheCharlatan>
In the meantime, we should figure out how best to surface documentation for it
<TheCharlatan>
Similarly we also had a discussion on where the host the various language bindings. If I am counting correctly, there are now rust, go, java, python, zig, and js bindings in various stages of completion and long-term commitment.
<TheCharlatan>
I.e. should these live in bitcoin-core/bindings, bitcoin/bindings, or somewhere else.
<TheCharlatan>
didn't really reach a conclusion on that yet, does anybody here have a suggestion?
jonatack has joined #bitcoin-core-dev
<laanwj>
yes that was awesome. good to get tha tin, congrats!!!
dzxzg has quit [Quit: Konversation terminated!]
<laanwj>
would make sense to make a repository for that under bitcoin-core
<stickies-v>
i'll just quickly rehash my point that i think it might be helpful to provide documentation / guidance on how to implement language bindings, but not centralize the actual implementation/distribution to keep the kernel development pace high until we're much more stable
<laanwj>
and agree that one repository with all the bindings would be preferable to seperate ones per language
jon_atack has quit [Ping timeout: 255 seconds]
<laanwj>
stickies-v: that's a good point too. but people aren't forced to use the central repository, it'll be for the more mature ones at first
<TheCharlatan>
I think I agree with stickies-v here, maybe a repo hosting some basic bindings guidance and examples would be a good place to start off of.
<TheCharlatan>
Could add a little readme in src/kernel that links to it and can then further link to other bindings under development.
<TheCharlatan>
I talked to a few people working on language-specific bitcoin tooling (bitcoinj, rust-bitcoin, btcsuite) and some have voiced support for hosting bindings under their org umbrella. A project even offered nice domain names :P
<laanwj>
yes
<TheCharlatan>
We also still need to settle on a particular versioning scheme. A suggestion was to treat our internal version as a "product name" and then have a specific versioning scheme for the header.
<laanwj>
i'd guess that works for languages that have a very active bitcoin community, like rust, yes
<l0rinc>
and java
<TheCharlatan>
This versioning approach seemed a bit confusing to some, and would still practically tie bitcoin core versioning with the kernel library.
<TheCharlatan>
Maybe for now the best action is to just not bother with it for a while still
<laanwj>
there's two seperate versionings here: the interface, and the kernel itself (e.g. what consensus rules). that complicates it a bit
<laanwj>
right. it's experimental for now. it wouldn't help to set things in stone too early
<abubakarsadiq>
@theCharlatan it will be nice if this ideas are opened in an issue somewhere contributors and users will chime in on which approach is best
<stickies-v>
laanwj do we need separate versions for interface and consensus?
<laanwj>
stickies-v: not sure. i was only talking conceptually. maybe these can be unified somehow
<TheCharlatan>
yes, people might also eventually have other unforeseeable opinions on implementation details, e.g. performance trade offs, and select specific versions outside of the interface.
<TheCharlatan>
abubakarsadiq yes, I think an issue for this topic would be good.
<laanwj>
but the former would be more stable, the latter would be really "product version"
<stickies-v>
TheCharlatan: will you open the issue to discuss this further?
<TheCharlatan>
will do.
<TheCharlatan>
Another area that will still need work are the tests.
<TheCharlatan>
The PR introduced a new test_kernel binary.
<laanwj>
i was surprised the tests for the kernel aren't enabled by default when the library is
<TheCharlatan>
Currently the tests, header, and implementation glue code are all in one big files. It would be nice to find a better topology for these. Especially the tests should get some more work in that regard.
<TheCharlatan>
The tests were initially meant to exercise the API without using our internal code. Some of the test utilities required to do this can now be removed and replaced with our usual test framework code.
<laanwj>
agree, that would make sense
<TheCharlatan>
People working on the bindings have also been asking for test vectors to test their APIs with.
<purpleKarrot>
One topic we may also want to discuss is the naming convention. I find it extremely hard to reason about the all lowercase function names. It is unclear what separates the type from the method name.
<TheCharlatan>
We can probably create a separate test data json file, similar to the ones we already use in the unit tests.
<laanwj>
yes it's a very critical API, so focus on testing, also cross-language would be good
<laanwj>
yes!
<TheCharlatan>
yes, purpleKarrot had suggested a naming in his own experimental api. I think it makes sense, but it does break convention with other C APIs under the bitcoin-core umbrella, e.g. minisketch and libsecp256k1.
<laanwj>
purpleKarrot: naming is important but also has a tendency to distract, because people tend to have strong differing opinions on it. but sure, creating an issue to discuss that makes sense
<vasild>
hi
<purpleKarrot>
If a convention makes code hard to reason about, it is time to rethink the convention.
dzxzg has joined #bitcoin-core-dev
<laanwj>
sure
<TheCharlatan>
At the current stage I think it would even be fairly straight forward to do a rename in a single big scripted-diff. Maybe prepare a PR for the change you had in mind, and we discuss it on there purpleKarrot?
<purpleKarrot>
sounds good.
<TheCharlatan>
We've also been working towards doing a beta release of the rust bindings. Among other things, we've started our own qa_assets repo for our own fuzz tests.
<TheCharlatan>
fuzzing the interface has proved fruitful early on - it revealed some constraints deeper in our consensus code that we probably would have not detected without them.
<stickies-v>
want to make sure we leave enough time for other WG's - i suggest we move on, lmk if you have more to discuss TheCharlatan and then we can come back to it at then end
<stickies-v>
#topic Benchmarking WG Update (l0rinc)
<l0rinc>
For #31132 we've simplified the multithreaded `InputFetcher` to collect directly to the temporary cache to avoid modifying the main dbcache in case of an invalid block.
<l0rinc>
Since we don't fail on missing entries anymore (it's not the cache-warmer's job to validate), we can safely filter intra-block spends based on short-ids instead of full txids - we don't even need to use `SipHash` this way since we're just relying on sorted vector binary search for presence checks which the benchmarks indicate are several times faster.
<laanwj>
"fuzzing the interface has proved fruitful early on - it revealed some constraints deeper in our consensus code that we probably would have not detected without them." glad to see this is already finding bugs that aren't in the API code itself :)
<l0rinc>
Local benchmarks also revealed that we may have some memory leaks in the code, see: #33806 (will investigate)
<l0rinc>
and we're writing an article for Bitcoin magazine about our benchmarking and optimization efforts
<laanwj>
nice!
magellan has quit [Read error: Connection reset by peer]
jonatack has quit [Ping timeout: 256 seconds]
<l0rinc>
thanks, that's it
<laanwj>
30% speed-up on reindex is very impressive
<stickies-v>
more speedups ahead in v31 it seems, thank you l0rinc. looking forward to reading the article, keep us posted?
<l0rinc>
sure
<stickies-v>
#topic Silent Payments WG Update (Novo__)
<abubakarsadiq>
From novo__: Hi I won't be available for the irc meeting. This is the update for SIlent Payments; josibake is off for now, so I and theStack will be taking over the PRs. A new silentpayments secp module PR has been opened by theStack https://github.com/bitcoin-core/secp256k1/pull/1765 (limited to full-node scanning to make it easier to merge). We will update https://github.com/bitcoin/bitcoin/pull/28122
<stickies-v>
thanks for passing it on abubakarsadiq
<stickies-v>
#topic Cluster Mempool WG Update (sdaftuar, sipa)
<glozow>
Just in case sipa is offline - #33629 is the PR to review. We're hoping to do a review "sprint" next week and would love to recruit anybody who has spare hands
<glozow>
Perhaps we can use this channel or #bitcoin-core-pr-reviews as a helpdesk for it next week. Please please do join in :)
<sipa>
hi, what glozow said
<stickies-v>
will there be pizza for the sprint?
<glozow>
As the PR gets to a stage where all pushes are minor edits, we can take the approach of getting it in master early in the release cycle, with the expectation that it will get more testing this way, and there will be followups
<glozow>
I am very happy to get a pizza delivered to you if you participate
<glozow>
Especially if you pay 10,000 BTC. Then you can have 2 pizzas
<sipa>
:D
<stickies-v>
i thought core devs don't have bitcoin
<laanwj>
hehe
<glozow>
I didn't say I have bitcoin, I have pizzas
<stickies-v>
where do people sign up for the sprint?
<fanquake>
"early in the release cycle," I guess this is should be pretty soon? Given we are 2 months in already
<fanquake>
Also taking into account upcoming christmas / holiday breaks etc
<glozow>
You can just do things! But if you're interested and don't know where to start, maybe a comment in #bitcoin-core-pr-reviews? I'm very happy to help people ramp up / look for things to do
<stickies-v>
cool - thanks! anything else?
<glozow>
fanquake: yes I mean merge in the next couple of weeks, unless we find problems
<glozow>
Nothing else from me
<stickies-v>
#topic Stratum v2 WG Update (sjors)
<stickies-v>
#topic Multiprocess WG Update (ryanofsky)
<abubakarsadiq>
yes, the push after the comment fixed it.
<TheCharlatan>
nice
<stickies-v>
#topic Net Split WG Update (cfields)
<cfields>
Sorry, I've been away for the past few weeks and haven't gotten rolling yet, so still nothing to report. I hope to have an issue opened by next-week with a logical grouping of subprojects and proposed high-level plan for discussion/review.
<stickies-v>
thanks cfields , looking forward to it
<l0rinc>
stickies-v: can you please add Andrew Toth to the benchmarking working group?
<stickies-v>
#topic dormant WGs
<stickies-v>
we haven't had updates from erlay and multiprocess wgs here on the meeting for a while. i suggest i'll remove the from the rotation for now, until champions reach out to reactivate it. don't want to waste ppl's time. any objections?
<stickies-v>
l0rinc: what's his irc handle?
<l0rinc>
dunno, will ping you later
<stickies-v>
Anything else to discuss?
<l0rinc>
left this at the end: it's been in review for more than a year now, but I think #30442 is also finally rfm
<l0rinc>
same for #33042 and #33443 and #33768 and #33786
<TheCharlatan>
One last thing I wanted to add before is kudos to all reviewers and especially stickies-v and purpleKarrot who really helped getting the API into shape :)
<stickies-v>
feels like tooting my own horn, but yeah, celebrating is important, thanks for the shoutout TheCharlatan. And obviously this is all possible thanks to your brilliant work
<stickies-v>
and with that, let's
<stickies-v>
#endmeeting
<corebot>
stickies-v: Meeting ended at 2025-11-06T16:57+0000
<bitcoin-git>
[gui] waketraindev opened pull request #910: Added test coverage for qt gui#901 console history filter (master...2025-11-gui-filtered-qt-tests) https://github.com/bitcoin-core/gui/pull/910
saturday- has joined #bitcoin-core-dev
Saturday7 has quit [Ping timeout: 240 seconds]
l0rinc has joined #bitcoin-core-dev
Talkless has joined #bitcoin-core-dev
hacker4web3bitco has quit [Ping timeout: 260 seconds]
AaronvanW has quit [Remote host closed the connection]
kevkevin has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [Closing Window]
<Sjors[m]1>
Thanks abubakarsadiq
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 244 seconds]
AaronvanW has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 256 seconds]
hacker4web3bitco has joined #bitcoin-core-dev
AaronvanW has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 244 seconds]
Earnestly has quit [Ping timeout: 245 seconds]
Novo__ has quit [Quit: Connection closed for inactivity]
Earnestly has joined #bitcoin-core-dev
hacker4web3bitco has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
Earnestly has quit [Ping timeout: 256 seconds]
AaronvanW has joined #bitcoin-core-dev
Earnestly has joined #bitcoin-core-dev
enochazariah has quit [Ping timeout: 250 seconds]
brunoerg has quit [Ping timeout: 260 seconds]
kevkevin has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
AaronvanW has quit [Remote host closed the connection]
AaronvanW has joined #bitcoin-core-dev
AaronvanW has quit [Remote host closed the connection]
robszarka has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
szarka has quit [Ping timeout: 255 seconds]
jonatack has quit [Ping timeout: 245 seconds]
Talkless has quit [Quit: Konversation terminated!]
jonatack has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
kevkevin has joined #bitcoin-core-dev
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 264 seconds]
nanotube has joined #bitcoin-core-dev
AaronvanW has quit [Remote host closed the connection]
AaronvanW has joined #bitcoin-core-dev
AaronvanW has quit [Ping timeout: 256 seconds]
skr0 has joined #bitcoin-core-dev
skr0 has quit [Client Quit]
jonatack has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 265 seconds]
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 245 seconds]
nanotube has quit [Ping timeout: 244 seconds]
jon_atack has quit [Ping timeout: 245 seconds]
jonatack has joined #bitcoin-core-dev
nanotube has joined #bitcoin-core-dev
<hebasto>
fanquake: re "Anybody want to do a Guix build for #33181 (on riscv64)? Cross arch non-determinism should be fixed" -- initiated; it might take a few days to complete