Chris_Stewart_5 has quit [Ping timeout: 240 seconds]
jonatack has quit [Ping timeout: 240 seconds]
luke-jr has quit [Ping timeout: 240 seconds]
nanotube has quit [Ping timeout: 240 seconds]
jadi has quit [Ping timeout: 240 seconds]
S3RK has quit [Ping timeout: 240 seconds]
sliv3r__- has joined #bitcoin-core-dev
nanotube has joined #bitcoin-core-dev
S3RK has joined #bitcoin-core-dev
cmirror has quit [Ping timeout: 246 seconds]
cman has joined #bitcoin-core-dev
cm_ has joined #bitcoin-core-dev
justache- has joined #bitcoin-core-dev
dongcarl00 has joined #bitcoin-core-dev
pinheadmz[m]1 has joined #bitcoin-core-dev
achow101_ has joined #bitcoin-core-dev
jimhhq_ has joined #bitcoin-core-dev
Chris_Stewart_5 has joined #bitcoin-core-dev
justache has quit [Ping timeout: 246 seconds]
BUSY has quit [Ping timeout: 246 seconds]
pinheadmz[m] has quit [Ping timeout: 246 seconds]
achow101 has quit [Ping timeout: 246 seconds]
BlueMattTest1 has quit [Ping timeout: 246 seconds]
dongcarl0 has quit [Ping timeout: 246 seconds]
cm has quit [Ping timeout: 246 seconds]
Chris_St1 has quit [Ping timeout: 246 seconds]
conman has quit [Ping timeout: 246 seconds]
jimhhq has quit [Ping timeout: 246 seconds]
cm_ is now known as cm
maxedw__ has quit [Ping timeout: 246 seconds]
maxedw__ has joined #bitcoin-core-dev
BUSY has joined #bitcoin-core-dev
BlueMattTest1 has joined #bitcoin-core-dev
justache- has quit [Ping timeout: 240 seconds]
dongcarl00 has quit [Read error: Connection reset by peer]
dongcarl00 has joined #bitcoin-core-dev
BlueMattMtrxBot has quit [*.net *.split]
BlueMattMtrxBot has joined #bitcoin-core-dev
justache has joined #bitcoin-core-dev
BlueMattTest1 has quit [Ping timeout: 246 seconds]
BUSY has quit [Ping timeout: 246 seconds]
BUSY has joined #bitcoin-core-dev
BlueMattTest1 has joined #bitcoin-core-dev
cmirror has joined #bitcoin-core-dev
<Sjors[m]1>
It may seem boring, but I have a bunch of MuSig2 related things based on #29136, so please give it a review!
<corebot>
https://github.com/bitcoin/bitcoin/issues/29136 | wallet: `addhdkey` RPC to add just keys to wallets via new `unused(KEY)` descriptor by achow101 · Pull Request #29136 · bitcoin/bitcoin · GitHub
TallTim_ has joined #bitcoin-core-dev
TallTim has quit [Ping timeout: 244 seconds]
kevkevin has quit [Remote host closed the connection]
cotsuka has quit [Remote host closed the connection]
adys has quit [Read error: Connection reset by peer]
adys has joined #bitcoin-core-dev
cotsuka has joined #bitcoin-core-dev
xFFFC0000 has quit [Quit: Connection closed for inactivity]
kevkevin has quit [Remote host closed the connection]
Cory95 has quit [Quit: Client closed]
Cory95 has joined #bitcoin-core-dev
szarka has quit [Quit: Leaving]
Cory22 has joined #bitcoin-core-dev
Cory95 has quit [Ping timeout: 272 seconds]
<darosior>
achow101_, furszy: been reading the existing wallet migration code to review #34156 and i have a few questions:
<darosior>
- Why does HasLegacyRecords return `true` when the result of `cursor->Next` is `Status::FAIL`? I was able to change the check to just "return true if status == MORE" and no test fail.
<darosior>
- Why is `empty_local_wallet` never set to `true` when `HasLegacyRecords()` returns `false`? Moving the line that sets `empty_local_wallet` outside the if/else block similarly does not make any test fail.
<achow101_>
darosior: "Why does HasLegacyRecords" <-- it doesn't particularly matter since BerkeleyROCursor::Next doesn't return FAIL, but == MORE is more correct
<achow101_>
wait, nvm it's a SQLiteCursor, so FAIL can happen
<achow101_>
"Why is `empty_local_wallet`" <-- a wallet might be intentionally empty, i.e. a blank wallet, which we want to preserve after migrating instead of deleting. the case we want to remove it is if the wallet contained only watchonly things and the resulting migrated spendable wallet contains nothing
<achow101_>
and moving the setter into the if/else results in UB
achow101_ is now known as achow101
<darosior>
empty_local_wallet: ah right i see. (I don't think what i actually suggested would be UB, but it would incorrect (though this is untested)).
<darosior>
Thanks
Cory27 has joined #bitcoin-core-dev
zeropoint has joined #bitcoin-core-dev
Cory5 has quit [Ping timeout: 272 seconds]
Cory83 has joined #bitcoin-core-dev
Cory27 has quit [Ping timeout: 272 seconds]
jerryf_ has joined #bitcoin-core-dev
jerryf has quit [Ping timeout: 252 seconds]
jerryf_ has quit [Remote host closed the connection]
jerryf has joined #bitcoin-core-dev
l0rinc has quit [Ping timeout: 246 seconds]
l0rinc has joined #bitcoin-core-dev
l0rinc has quit [Remote host closed the connection]