<lightlike>
achow101: not convinced: removing it (as in always sending zero instead?) could break compatibility with other software, including old versions of core. I guess we could work around with versioning, but I don't really see the point, just for one field.
<achow101>
whoops, misread that message. meant to say no it's not being removed
<lightlike>
oh ok :)
<WakeTrainDev>
i'm assuming it's going to be set to -1 or similar in the version message, and removed from qt/peer list as well
<WakeTrainDev>
at least thats how i read it :P
durandal_ has quit [Ping timeout: 246 seconds]
<lightlike>
yes, not worth the compatibility troubles imo. removing from the gui seems unproblematic though.
jerryf_ has joined #bitcoin-core-dev
jerryf has quit [Ping timeout: 252 seconds]
jonatack has joined #bitcoin-core-dev
durandal_ has joined #bitcoin-core-dev
jerryf has joined #bitcoin-core-dev
jerryf_ has quit [Ping timeout: 252 seconds]
jerryf_ has joined #bitcoin-core-dev
jerryf has quit [Ping timeout: 252 seconds]
kevkevin has joined #bitcoin-core-dev
jadi has quit [Ping timeout: 260 seconds]
<bitcoin-git>
[gui] waketraindev opened pull request #921: Remove deprecated "Starting Block" from Peer Detail (master...pr/qt_remove_startingheight) https://github.com/bitcoin-core/gui/pull/921
<bitcoin-git>
[bitcoin] fanquake merged pull request #34203: doc: p2p: replace last remaining "command" terminology with "message type" (master...202601-doc-p2p-command-afuera) https://github.com/bitcoin/bitcoin/pull/34203
jerryf__ has quit [Remote host closed the connection]
jerryf has joined #bitcoin-core-dev
jerryf_ has joined #bitcoin-core-dev
jerryf has quit [Ping timeout: 252 seconds]
Guyver2 has left #bitcoin-core-dev [Closing Window]
l0rinc has quit [Quit: l0rinc]
jerryf_ has quit [Remote host closed the connection]
jerryf has joined #bitcoin-core-dev
jerryf_ has joined #bitcoin-core-dev
jerryf has quit [Remote host closed the connection]
___nick___ has joined #bitcoin-core-dev
___nick___ has quit [Client Quit]
___nick___ has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
ozdeadman has joined #bitcoin-core-dev
ozdeadman has quit [Quit: ZNC 1.7.5+deb4 - https://znc.in]
deadmanoz has joined #bitcoin-core-dev
Guest36 has joined #bitcoin-core-dev
Guest36 has quit [Client Quit]
vasild has quit [Quit: leaving]
l0rinc has quit [Ping timeout: 244 seconds]
l0rinc has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] l0rinc opened pull request #34207: coins/refactor: enforce `GetCoin()` returns only unspent coins (master...l0rinc/getcoin-unspent) https://github.com/bitcoin/bitcoin/pull/34207
vasild has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] l0rinc opened pull request #34208: bench: add fluent API for untimed `setup` steps in nanobench (master...l0rinc/untimed-setup-nanobench) https://github.com/bitcoin/bitcoin/pull/34208
___nick___ has quit [Ping timeout: 240 seconds]
___nick___ has joined #bitcoin-core-dev
___nick___ has quit [Ping timeout: 244 seconds]
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
Cory90 has quit [Quit: Client closed]
Cory90 has joined #bitcoin-core-dev
___nick___ has joined #bitcoin-core-dev
jerryf has joined #bitcoin-core-dev
jerryf_ has quit [Ping timeout: 252 seconds]
jerryf_ has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 250 seconds]
jerryf has quit [Ping timeout: 252 seconds]
eugenesiegel has joined #bitcoin-core-dev
eugenesiegel has quit [Quit: Client closed]
jamesob443688173 has joined #bitcoin-core-dev
jamesob1566593 has joined #bitcoin-core-dev
WakeTrainDev has joined #bitcoin-core-dev
WakeTrainDev has quit [Quit: leaving]
dongcarl000 has quit [Read error: Connection reset by peer]
<bitcoin-git>
[bitcoin] D33r-Gee opened pull request #34211: build: Alt restore cross-compilation for Android (master...260601-android-deployqt-build) https://github.com/bitcoin/bitcoin/pull/34211
<bitcoin-git>
[bitcoin] DrahtBot closed pull request #34211: build: Alt restore cross-compilation for Android (master...260601-android-deployqt-build) https://github.com/bitcoin/bitcoin/pull/34211
<bitcoin-git>
[bitcoin] hebasto reopened pull request #34211: build: Alt restore cross-compilation for Android (master...260601-android-deployqt-build) https://github.com/bitcoin/bitcoin/pull/34211
jadi has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
jadi has quit [Ping timeout: 264 seconds]
jadi has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
<furszy>
darosior: "Why does HasLegacyRecords" --> At that point, we've just created the sqlite db. The FAIL return could only happen if the db is busy, locked, the API is misused (which we ensure is not the case for all this three), or… if there is a memory allocation failure.
<furszy>
this last one could cause an issue (and should be fixed). But still, we are talking about a non-realistic scenario. bitcoind would fail much earlier if there is no enough memory.
<darosior>
Yeah it does seem unrealistic, was just going through the possible cases systematically
<furszy>
all good, keep going. The more eyes, the better
<darosior>
On the other hand this is the kind of things where we are better off just doing the "more correct" thing just in case, to harden against future modifications of the code where reviewers may not realize that a function named `HasLegacyRecords()`, possibly outside of a PR's diff, actually returns true on failure
___nick___ has quit [Quit: No Ping reply in 180 seconds.]
dzxzg has joined #bitcoin-core-dev
___nick___ has joined #bitcoin-core-dev
szarka has joined #bitcoin-core-dev
WizJin_ has joined #bitcoin-core-dev
WizJin__ has quit [Ping timeout: 252 seconds]
jadi has quit [Ping timeout: 264 seconds]
jadi has joined #bitcoin-core-dev
abubakarsadiq has quit [Quit: Connection closed for inactivity]
BUSY has quit [Ping timeout: 246 seconds]
BUSY has joined #bitcoin-core-dev
WizJin__ has joined #bitcoin-core-dev
WizJin_ has quit [Ping timeout: 264 seconds]
Cory17 has joined #bitcoin-core-dev
Cory90 has quit [Ping timeout: 272 seconds]
___nick___ has quit [Read error: Connection reset by peer]
___nick___ has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] BitcoinMechanic opened pull request #34212: doc: Clarify -migratewallet can be used to delete private keys (master...fix-docs) https://github.com/bitcoin/bitcoin/pull/34212
Chris_Stewart_5 has quit [Ping timeout: 245 seconds]
Cory94 has joined #bitcoin-core-dev
Cory17 has quit [Ping timeout: 272 seconds]
jonatack has joined #bitcoin-core-dev
jerryf has joined #bitcoin-core-dev
jerryf_ has quit [Remote host closed the connection]
jerryf_ has joined #bitcoin-core-dev
jerryf has quit [Ping timeout: 252 seconds]
jerryf_ has quit [Remote host closed the connection]
jerryf has joined #bitcoin-core-dev
robszarka has joined #bitcoin-core-dev
___nick___ has quit [Ping timeout: 240 seconds]
Cory28 has joined #bitcoin-core-dev
szarka has quit [Ping timeout: 246 seconds]
Cory94 has quit [Ping timeout: 272 seconds]
<bitcoin-git>
[bitcoin] brunoerg opened pull request #34213: net: do not read/dump anchors if network is not active (master...2026-01-net-anchors-networkactive) https://github.com/bitcoin/bitcoin/pull/34213
<bitcoin-git>
[bitcoin] bensig opened pull request #34214: policy: restore 80-byte default for datacarriersize (master...revert-datacarrier-default) https://github.com/bitcoin/bitcoin/pull/34214
jamesob1566593 has quit [Read error: Connection reset by peer]
jamesob443688173 has quit [Read error: Connection reset by peer]
Cory56 has joined #bitcoin-core-dev
Cory5 has joined #bitcoin-core-dev
jamesob443688173 has joined #bitcoin-core-dev
jamesob1566593 has joined #bitcoin-core-dev
afiore has quit [Remote host closed the connection]
<bitcoin-git>
bitcoin/master fafbc70 MarcoFalke: rpc: [wallet] Use unsigned type for tx version in sendall
<bitcoin-git>
bitcoin/master a9daa6d Ava Chow: Merge bitcoin/bitcoin#34135: rpc: [wallet] Use unsigned type for tx versio...
<bitcoin-git>
[bitcoin] achow101 merged pull request #34135: rpc: [wallet] Use unsigned type for tx version in sendall (master...2512-rpc-wallet-less-i32) https://github.com/bitcoin/bitcoin/pull/34135