#bitcoin-core-dev on 2026-01-21 — searchable irc log

2025-01-16 14:22 achow101 changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 16:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt

00:16 bitdex has joined #bitcoin-core-dev

00:17 MrHAPPY has joined #bitcoin-core-dev

00:46 <achow101_> 29.3rc1 bins are up

00:47 achow101_ is now known as achow101

00:52 durandal_ has quit [Ping timeout: 244 seconds]

01:02 andrewtoth has quit [Remote host closed the connection]

01:02 andrewtoth has joined #bitcoin-core-dev

01:05 durandal_ has joined #bitcoin-core-dev

01:22 bitdex has quit [Ping timeout: 252 seconds]

01:48 memset has quit [Remote host closed the connection]

01:49 memset has joined #bitcoin-core-dev

01:53 memset has quit [Remote host closed the connection]

01:54 memset has joined #bitcoin-core-dev

02:14 TheRec has joined #bitcoin-core-dev

02:15 TheRec_ has quit [Ping timeout: 246 seconds]

02:26 <bitcoin-git> [bitcoin] DevPatel-11 opened pull request #34357: rpc: Handle nullptr from createNewBlock in getblocktemplate (master...fix/34262-getblocktemplate-nullcheck) https://github.com/bitcoin/bitcoin/pull/34357

02:40 <bitcoin-git> [bitcoin] mzumsande opened pull request #34358: wallet: fix removeprunedfunds bug with conflicting transactions (master...202601_importprunedfund_bug) https://github.com/bitcoin/bitcoin/pull/34358

02:42 <bitcoin-git> [bitcoin] mzumsande opened pull request #34359: test: add test for rebroadcast of transaction received via p2p (master...202601_test_rebroadcast) https://github.com/bitcoin/bitcoin/pull/34359

02:56 Cory46 has quit [Quit: Client closed]

02:57 Cory46 has joined #bitcoin-core-dev

03:11 bitdex has joined #bitcoin-core-dev

03:15 <bitcoin-git> [bitcoin] w0xlt opened pull request #34360: bench: add WalletBalanceManySpent for high-history wallet scenario (master...wallet-balance-many-spent-bench-3) https://github.com/bitcoin/bitcoin/pull/34360

03:28 memset has quit [Remote host closed the connection]

03:28 memset has joined #bitcoin-core-dev

03:37 MrHAPPY has quit []

03:49 memset has quit [Ping timeout: 252 seconds]

03:52 memset has joined #bitcoin-core-dev

04:08 <bitcoin-git> [bitcoin] theStack opened pull request #34361: test: clean up tx resurrection (re-org) test in feature_block.py (master...202601-test-feature_block_resurrect_cleanup) https://github.com/bitcoin/bitcoin/pull/34361

04:38 <bitcoin-git> [bitcoin] 8144225309 opened pull request #34362: wallet: skip APS when no partial spend exists (master...aps-skip-no-partial-spend) https://github.com/bitcoin/bitcoin/pull/34362

04:48 <bitcoin-git> [bitcoin] ryanofsky opened pull request #34363: Update libmultiprocess subtree to avoid occasional rpc_misc.py timeout (master...pr/subtree-7) https://github.com/bitcoin/bitcoin/pull/34363

05:01 cmirror has quit [Remote host closed the connection]

05:01 cmirror has joined #bitcoin-core-dev

05:12 andrewtoth has quit [Remote host closed the connection]

05:13 andrewtoth has joined #bitcoin-core-dev

05:27 Guest2 has joined #bitcoin-core-dev

05:27 Guest2 has quit [Client Quit]

05:37 cotsuka has quit [Read error: Connection reset by peer]

05:37 cotsuka has joined #bitcoin-core-dev

06:16 aleggg has quit [Remote host closed the connection]

06:20 andrewtoth has quit [Remote host closed the connection]

06:20 andrewtoth has joined #bitcoin-core-dev

06:27 aleggg has joined #bitcoin-core-dev

06:42 WizJin_ has quit [Ping timeout: 265 seconds]

06:47 WizJin has joined #bitcoin-core-dev

06:57 cfields has quit [Ping timeout: 252 seconds]

07:03 ghost43 has quit [Ping timeout: 252 seconds]

07:06 ghost43 has joined #bitcoin-core-dev

07:08 cfields has joined #bitcoin-core-dev

07:09 Gestodia has joined #bitcoin-core-dev

08:02 afiore has quit [Ping timeout: 252 seconds]

08:03 afiore has joined #bitcoin-core-dev

08:31 sliv3r__ has quit [Ping timeout: 264 seconds]

08:32 sliv3r__ has joined #bitcoin-core-dev

08:53 kevkevin has joined #bitcoin-core-dev

08:57 kevkevin has quit [Remote host closed the connection]

08:59 ___nick___ has joined #bitcoin-core-dev

09:31 robszarka has joined #bitcoin-core-dev

09:32 <bitcoin-git> [bitcoin] crackedhandle opened pull request #34364: contrib: add initial zsh completion for bitcoin-cli (master...contrib/zsh-completions) https://github.com/bitcoin/bitcoin/pull/34364

09:32 <bitcoin-git> [bitcoin] DrahtBot closed pull request #34364: contrib: add initial zsh completion for bitcoin-cli (master...contrib/zsh-completions) https://github.com/bitcoin/bitcoin/pull/34364

09:34 szarka has quit [Ping timeout: 255 seconds]

09:37 nickler has quit [Quit: leaving]

09:38 nickler has joined #bitcoin-core-dev

11:06 cotsuka has quit [Read error: Connection reset by peer]

11:09 cotsuka has joined #bitcoin-core-dev

11:14 memset has quit [Remote host closed the connection]

11:14 memset has joined #bitcoin-core-dev

11:23 ___nick___ has quit [Ping timeout: 245 seconds]

11:24 ___nick___ has joined #bitcoin-core-dev

11:38 Gestodia has quit [Quit: Client closed]

11:56 <bitcoin-git> [bitcoin] rkrux opened pull request #34366: test: switch order of error code and message check (master...test-error-debug) https://github.com/bitcoin/bitcoin/pull/34366

12:01 robszarka has quit [Quit: Leaving]

12:02 szarka has joined #bitcoin-core-dev

12:08 <bitcoin-git> [bitcoin] billymcbip closed pull request #34294: test: Remove redundant STRICTENC flag from script_tests (master...strictenc) https://github.com/bitcoin/bitcoin/pull/34294

12:24 <bitcoin-git> [bitcoin] sedited pushed 9 commits to master: https://github.com/bitcoin/bitcoin/compare/8c07800b193e...52096de2121d

12:24 <bitcoin-git> bitcoin/master fad4a9f MarcoFalke: Set bugprone-unused-return-value.AllowCastToVoid

12:24 <bitcoin-git> bitcoin/master faa109f MarcoFalke: test: refactor: Use BOOST_CHECK_EQUAL over BOOST_CHECK ==

12:24 <bitcoin-git> bitcoin/master fa1de11 MarcoFalke: util: Add Unexpected::error()

12:24 <bitcoin-git> [bitcoin] sedited merged pull request #34032: util: Add some more Unexpected and Expected methods (master...2512-exp) https://github.com/bitcoin/bitcoin/pull/34032

12:35 durandal_ has quit [Read error: Connection reset by peer]

12:45 ___nick___ has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]

12:47 ___nick___ has joined #bitcoin-core-dev

12:48 ___nick___ has quit [Client Quit]

12:50 durandal_ has joined #bitcoin-core-dev

12:50 ___nick___ has joined #bitcoin-core-dev

13:04 l0rinc has joined #bitcoin-core-dev

13:07 cotsuka has quit [Read error: Connection reset by peer]

13:09 cotsuka has joined #bitcoin-core-dev

13:18 ___nick___ has quit [Ping timeout: 244 seconds]

13:27 ___nick___ has joined #bitcoin-core-dev

13:45 bitdex has quit [Quit: = ""]

13:50 l0rinc has quit [Quit: l0rinc]

13:57 gf2718_ has joined #bitcoin-core-dev

14:11 Gestodia has joined #bitcoin-core-dev

14:37 Guyver2 has joined #bitcoin-core-dev

14:59 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/52096de2121d...fa267551c4ea

14:59 <bitcoin-git> bitcoin/master faa18dc MarcoFalke: refactor: Use std::bind_front over std::bind

14:59 <bitcoin-git> bitcoin/master fa26755 merge-script: Merge bitcoin/bitcoin#34353: refactor: Use std::bind_front over std::bind

14:59 <bitcoin-git> [bitcoin] fanquake merged pull request #34353: refactor: Use std::bind_front over std::bind (master...2601-bind-front) https://github.com/bitcoin/bitcoin/pull/34353

15:07 <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/fa267551c4ea...e324925d1990

15:07 <bitcoin-git> bitcoin/master 7562e2a Ryan Ofsky: Squashed 'src/ipc/libmultiprocess/' changes from a4f92969649..1fc65008f7d

15:07 <bitcoin-git> bitcoin/master 73d0fe6 Ryan Ofsky: Merge commit '7562e2aeed95b0dc627e8e3a849941992f0189bb' into pr/subtree-7

15:07 <bitcoin-git> bitcoin/master e324925 merge-script: Merge bitcoin/bitcoin#34363: Update libmultiprocess subtree to avoid occas...

15:07 <bitcoin-git> [bitcoin] fanquake merged pull request #34363: Update libmultiprocess subtree to avoid occasional rpc_misc.py timeout (master...pr/subtree-7) https://github.com/bitcoin/bitcoin/pull/34363

15:11 ___nick___ has quit [Read error: Connection reset by peer]

15:11 ___nick___ has joined #bitcoin-core-dev

15:22 <bitcoin-git> [bitcoin] maflcko opened pull request #34369: test: Scale NetworkThread close timeout with timeout_factor (master...2601-test-scale-close-timeout) https://github.com/bitcoin/bitcoin/pull/34369

15:36 cotsuka has quit [Read error: Connection reset by peer]

15:37 cotsuka has joined #bitcoin-core-dev

15:41 <bitcoin-git> [bitcoin] maflcko closed pull request #34334: fix: check event loop state before stopping in NetworkThread.close() (master...fix/p2p-network-thread-close-already-stopped) https://github.com/bitcoin/bitcoin/pull/34334

15:46 durandal_ has quit [Read error: Connection reset by peer]

15:47 <bitcoin-git> [bitcoin] luke-jr opened pull request #34370: [29.x] Fix #34222 backport bugs (29.x...fix_34222_backport) https://github.com/bitcoin/bitcoin/pull/34370

15:49 gf2718_ has quit [Ping timeout: 264 seconds]

15:49 Guyver2 has left #bitcoin-core-dev [Closing Window]

15:53 gf2718 has joined #bitcoin-core-dev

15:54 <bitcoin-git> [bitcoin] 8144225309 opened pull request #34371: wallet: allow importprunedfunds for spending transactions (master...fix-importprunedfunds-spending) https://github.com/bitcoin/bitcoin/pull/34371

15:54 Cory79 has joined #bitcoin-core-dev

15:57 Cory45 has joined #bitcoin-core-dev

15:59 Cory46 has quit [Ping timeout: 272 seconds]

16:00 jerryf has quit [Remote host closed the connection]

16:00 jerryf has joined #bitcoin-core-dev

16:01 Cory79 has quit [Ping timeout: 272 seconds]

16:01 durandal_ has joined #bitcoin-core-dev

16:18 _flood has quit [Remote host closed the connection]

16:19 _flood has joined #bitcoin-core-dev

16:20 btsf_1 has joined #bitcoin-core-dev

16:20 btsf_1 has quit [Remote host closed the connection]

16:29 jerryf has quit [Remote host closed the connection]

16:29 jerryf has joined #bitcoin-core-dev

16:38 durandal_ has quit [Ping timeout: 240 seconds]

16:42 gf2718 has quit [Quit: WeeChat 4.8.1]

16:42 gf2718 has joined #bitcoin-core-dev

16:42 <bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e324925d1990...3ea2b6fe180e

16:42 <bitcoin-git> bitcoin/master fab055c MarcoFalke: test: Scale NetworkThread close timeout with timeout_factor

16:42 <bitcoin-git> bitcoin/master 3ea2b6f Hennadii Stepanov: Merge bitcoin/bitcoin#34369: test: Scale NetworkThread close timeout with ...

16:42 <bitcoin-git> [bitcoin] hebasto merged pull request #34369: test: Scale NetworkThread close timeout with timeout_factor (master...2601-test-scale-close-timeout) https://github.com/bitcoin/bitcoin/pull/34369

16:45 gf2718 has quit [Client Quit]

16:48 gf2718 has joined #bitcoin-core-dev

16:51 durandal_ has joined #bitcoin-core-dev

17:01 Gestodia has quit [Quit: Client closed]

17:01 durandal_ has quit [Ping timeout: 246 seconds]

17:02 memset has quit [Remote host closed the connection]

17:02 kevkevin has joined #bitcoin-core-dev

17:03 memset has joined #bitcoin-core-dev

17:07 mudsip has joined #bitcoin-core-dev

17:13 memset has quit [Remote host closed the connection]

17:13 memset has joined #bitcoin-core-dev

17:14 durandal_ has joined #bitcoin-core-dev

17:17 mudsip has quit []

17:19 durandal_ has quit [Read error: Connection reset by peer]

17:31 jerryf has quit [Remote host closed the connection]

17:32 jerryf has joined #bitcoin-core-dev

17:36 durandal_ has joined #bitcoin-core-dev

17:39 memset has quit [Remote host closed the connection]

17:39 memset has joined #bitcoin-core-dev

17:44 <bitcoin-git> [bitcoin] luke-jr opened pull request #34372: QA: wallet_migration: Test several more weird scenarios (master...qa_wallet_migration_tests_202601) https://github.com/bitcoin/bitcoin/pull/34372

17:53 cotsuka has quit [Remote host closed the connection]

17:54 cotsuka has joined #bitcoin-core-dev

17:55 memset has quit [Ping timeout: 252 seconds]

17:57 memset has joined #bitcoin-core-dev

18:01 Cory32 has joined #bitcoin-core-dev

18:05 Cory45 has quit [Ping timeout: 272 seconds]

18:06 cotsuka has quit [Read error: Connection reset by peer]

18:09 cotsuka has joined #bitcoin-core-dev

18:20 jerryf has quit [Remote host closed the connection]

18:20 jerryf has joined #bitcoin-core-dev

18:23 jerryf has quit [Remote host closed the connection]

18:24 jerryf has joined #bitcoin-core-dev

18:29 Cory54 has joined #bitcoin-core-dev

18:29 WizJin_ has joined #bitcoin-core-dev

18:32 WizJin has quit [Ping timeout: 246 seconds]

18:33 Cory32 has quit [Ping timeout: 272 seconds]

18:33 Cory13 has joined #bitcoin-core-dev

18:37 Cory54 has quit [Ping timeout: 272 seconds]

18:45 kevkevin has quit [Remote host closed the connection]

18:47 kevkevin has joined #bitcoin-core-dev

18:47 WizJin__ has joined #bitcoin-core-dev

18:48 Cory3 has joined #bitcoin-core-dev

18:51 Cory3 has quit [Client Quit]

18:51 Cory3 has joined #bitcoin-core-dev

18:52 WizJin_ has quit [Ping timeout: 264 seconds]

18:52 Cory13 has quit [Ping timeout: 272 seconds]

19:08 Cory3 has quit [Quit: Client closed]

19:08 Cory3 has joined #bitcoin-core-dev

19:12 Cory74 has joined #bitcoin-core-dev

19:13 PaperSword has quit [Quit: PaperSword]

19:13 PaperSword has joined #bitcoin-core-dev

19:14 <bitcoin-git> [bitcoin] maflcko opened pull request #34373: refactor: Remove remaining std::bind, check via clang-tidy (master...2601-no-bind) https://github.com/bitcoin/bitcoin/pull/34373

19:16 Cory3 has quit [Ping timeout: 272 seconds]

19:18 gf2718 has quit [Ping timeout: 246 seconds]

19:19 gf2718 has joined #bitcoin-core-dev

19:23 gf2718 has quit [Ping timeout: 246 seconds]

19:30 kevkevin has quit [Remote host closed the connection]

19:31 Cory28 has joined #bitcoin-core-dev

19:34 Cory74 has quit [Quit: Client closed]

19:37 gf2718 has joined #bitcoin-core-dev

19:44 gf2718 has quit [Ping timeout: 264 seconds]

19:56 <bitcoin-git> [bitcoin] stickies-v opened pull request #34374: kernel: use structured logging and simplify logging interface (master...2026-01/kernel-logging-layering-predicate) https://github.com/bitcoin/bitcoin/pull/34374

19:57 Cory11 has joined #bitcoin-core-dev

20:01 Cory28 has quit [Ping timeout: 272 seconds]

20:10 spynx has joined #bitcoin-core-dev

20:12 spynxic has quit [Read error: Connection reset by peer]

20:17 <bitcoin-git> [bitcoin] maflcko closed pull request #34350: wallet: fix importprunedfunds to allow importing spending txs (master...fix-importprunedfunds) https://github.com/bitcoin/bitcoin/pull/34350

20:17 <bitcoin-git> [bitcoin] ismaelsadeeq opened pull request #34375: doc: mempool: fix `removeUnchecked` incorrect comment (master...01-2026-fix-removeUnchecked-doc) https://github.com/bitcoin/bitcoin/pull/34375

20:30 gf2718 has joined #bitcoin-core-dev

20:34 Cory11 has quit [Ping timeout: 272 seconds]

20:35 gf2718 has quit [Ping timeout: 256 seconds]

20:36 l0rinc has joined #bitcoin-core-dev

20:36 deadmanoz has joined #bitcoin-core-dev

20:38 ozdeadman has quit [Ping timeout: 264 seconds]

21:04 ___nick___ has quit [Ping timeout: 250 seconds]

21:06 cotsuka has quit [Read error: Connection reset by peer]

21:09 cotsuka has joined #bitcoin-core-dev

21:13 gf2718 has joined #bitcoin-core-dev

21:17 gf2718 has quit [Ping timeout: 246 seconds]

21:57 <bitcoin-git> [bitcoin] sedited pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/3ea2b6fe180e...2a1234001c46

21:57 <bitcoin-git> bitcoin/master d30ad4a Ava Chow: wallet, rpc: Use HandleWalletError in createwallet

21:57 <bitcoin-git> bitcoin/master 5875a9c Ava Chow: wallet: disallow unnamed wallets in createwallet and restorewallet

21:57 <bitcoin-git> bitcoin/master 75b704d Ava Chow: wallettool: Disallow creating new unnamed wallets

21:57 <bitcoin-git> [bitcoin] sedited merged pull request #34269: wallet: disallow creating new or restoring to an unnamed (default) wallet (master...dont-create-default-wallets) https://github.com/bitcoin/bitcoin/pull/34269

22:00 gf2718 has joined #bitcoin-core-dev

22:05 gf2718 has quit [Ping timeout: 255 seconds]

22:09 <bitcoin-git> [bitcoin] sedited pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2a1234001c46...5715748333fe

22:09 <bitcoin-git> bitcoin/master 0aba464 rkrux: test: switch order of error code and message check

22:09 <bitcoin-git> bitcoin/master 5715748 merge-script: Merge bitcoin/bitcoin#34366: test: switch order of error code and message ...

22:09 <bitcoin-git> [bitcoin] sedited merged pull request #34366: test: switch order of error code and message check (master...test-error-debug) https://github.com/bitcoin/bitcoin/pull/34366

22:15 gf2718 has joined #bitcoin-core-dev

22:19 jonatack has joined #bitcoin-core-dev

22:23 gf2718 has quit [Ping timeout: 246 seconds]

22:31 <bitcoin-git> [bitcoin] l0rinc opened pull request #34376: bench/test: clarify merkle bench and witness test intent (master...l0rinc/bench-test-32497-followup) https://github.com/bitcoin/bitcoin/pull/34376

22:36 cotsuka has quit [Read error: Connection reset by peer]

22:39 cotsuka has joined #bitcoin-core-dev

22:40 Zenton_ has quit [Ping timeout: 264 seconds]

22:50 l0rinc has quit [Quit: l0rinc]

22:55 gf2718 has joined #bitcoin-core-dev

23:00 gf2718 has quit [Ping timeout: 256 seconds]

23:03 Zenton has joined #bitcoin-core-dev

23:07 cotsuka has quit [Read error: Connection reset by peer]

23:09 cotsuka has joined #bitcoin-core-dev

23:31 <bitcoin-git> [bitcoin] fjahr opened pull request #34377: test: Rename wallet name in restore attempt in wallet_assumeutxo (master...2026-01-win-test-flaky) https://github.com/bitcoin/bitcoin/pull/34377

23:32 gf2718 has joined #bitcoin-core-dev

23:34 memset has quit [Remote host closed the connection]

23:35 memset has joined #bitcoin-core-dev

23:37 gf2718 has quit [Ping timeout: 246 seconds]

23:44 jonatack has quit [Ping timeout: 265 seconds]