achow101 changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 16:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
<bitcoin-git> [bitcoin] achow101 opened pull request #34215: wallettool: fix unnamed createfromdump failure walletsdir deletion (master...createfromdump-deletion) https://github.com/bitcoin/bitcoin/pull/34215
SpellChecker has quit [Quit: bye]
SpellChecker has joined #bitcoin-core-dev
tinova40 has joined #bitcoin-core-dev
tinova4 has quit [Ping timeout: 264 seconds]
tinova40 is now known as tinova4
adil has joined #bitcoin-core-dev
adil has quit [Quit: adil]
jackielove4u has quit [Ping timeout: 244 seconds]
jadi has quit [Ping timeout: 240 seconds]
jonatack has quit [Ping timeout: 244 seconds]
jackielove4u has joined #bitcoin-core-dev
aleggg has joined #bitcoin-core-dev
dzxzg has quit [Quit: Konversation terminated!]
jerryf_ has joined #bitcoin-core-dev
jerryf has quit [Remote host closed the connection]
deadmanoz has quit [Quit: Leaving]
abubakarsadiq has joined #bitcoin-core-dev
deadmanoz has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
bitdex has quit [Ping timeout: 252 seconds]
bitdex has joined #bitcoin-core-dev
jerryf has joined #bitcoin-core-dev
jerryf_ has quit [Ping timeout: 252 seconds]
bitdex has quit [Ping timeout: 252 seconds]
bitdex has joined #bitcoin-core-dev
Cory26 has joined #bitcoin-core-dev
kevkevin_ has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 264 seconds]
Cory82 has quit [Ping timeout: 272 seconds]
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
kevkevin_ has quit [Ping timeout: 252 seconds]
kevkevin has joined #bitcoin-core-dev
bitdex has quit [Ping timeout: 252 seconds]
bitdex has joined #bitcoin-core-dev
bitdex has quit [Remote host closed the connection]
bitdex has joined #bitcoin-core-dev
bitdex has quit [Remote host closed the connection]
bitdex has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 260 seconds]
ghost43 has quit [Ping timeout: 252 seconds]
kevkevin has joined #bitcoin-core-dev
ghost43 has joined #bitcoin-core-dev
bitdex has quit [Remote host closed the connection]
bitdex has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 240 seconds]
l0rinc has quit [Ping timeout: 246 seconds]
l0rinc has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
l0rinc has quit [Client Quit]
kevkevin has quit [Ping timeout: 246 seconds]
<bitcoin-git> [bitcoin] tboy1337 opened pull request #34217: contrib: Fix Python issues in makeseeds.py (master...seed-script-fixes) https://github.com/bitcoin/bitcoin/pull/34217
<bitcoin-git> [bitcoin] tboy1337 opened pull request #34218: test: Fix Python compatibility issues in test framework (master...test-framework-fixes) https://github.com/bitcoin/bitcoin/pull/34218
kevkevin has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [Closing Window]
jerryf has quit [Ping timeout: 252 seconds]
jerryf has joined #bitcoin-core-dev
jerryf_ has joined #bitcoin-core-dev
jerryf has quit [Ping timeout: 252 seconds]
jerryf_ has quit [Remote host closed the connection]
jerryf has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 264 seconds]
jerryf_ has joined #bitcoin-core-dev
jerryf has quit [Ping timeout: 252 seconds]
timbo has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
timbo has quit [Quit: WeeChat 4.8.1]
timbo has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 250 seconds]
timbo has quit [Client Quit]
Cory26 has quit [Quit: Client closed]
timbo has joined #bitcoin-core-dev
Cory26 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake closed pull request #34218: test: Fix Python compatibility issues in test framework (master...test-framework-fixes) https://github.com/bitcoin/bitcoin/pull/34218
<bitcoin-git> [bitcoin] fanquake closed pull request #34217: contrib: Fix Python issues in makeseeds.py (master...seed-script-fixes) https://github.com/bitcoin/bitcoin/pull/34217
timbo has left #bitcoin-core-dev [#bitcoin-core-dev]
timbo_xyz has joined #bitcoin-core-dev
memset_ has joined #bitcoin-core-dev
timbo_xyz has quit [Quit: WeeChat 4.8.1]
memset has quit [Ping timeout: 252 seconds]
kevkevin has joined #bitcoin-core-dev
aleggg has quit [Remote host closed the connection]
timbo has joined #bitcoin-core-dev
timbo is now known as timbo_xyz
timbo_xyz has quit [Client Quit]
timbo has joined #bitcoin-core-dev
timbo has quit [Client Quit]
timbo_xyz has joined #bitcoin-core-dev
jerryf_ has quit [Remote host closed the connection]
jerryf has joined #bitcoin-core-dev
timbo_xyz has quit [Quit: WeeChat 4.8.1]
timbo_xyz has joined #bitcoin-core-dev
timbo_xyz has quit [Client Quit]
timbo_xyz has joined #bitcoin-core-dev
timbo_xyz has quit [Client Quit]
oneeyedalien has joined #bitcoin-core-dev
billymcbip has joined #bitcoin-core-dev
timbo_xyz has joined #bitcoin-core-dev
___nick___ has joined #bitcoin-core-dev
timbo_xyz has quit [Client Quit]
Cory26 has quit [Quit: Client closed]
Cory26 has joined #bitcoin-core-dev
timbo_xyz has joined #bitcoin-core-dev
<timbo_xyz> quit
timbo_xyz has quit [Quit: WeeChat 4.8.1]
timbo_xyz has joined #bitcoin-core-dev
timbo_xyz has quit [Client Quit]
<bitcoin-git> [bitcoin] fanquake pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/a9daa6dbd3ae...90d651a81f51
<bitcoin-git> bitcoin/master 4ed0693 furszy: wallet: RestoreWallet failure, erase only what was created
<bitcoin-git> bitcoin/master 36093bd furszy: test: add coverage for unnamed wallet migration failure
<bitcoin-git> bitcoin/master f4c7e28 furszy: wallet: fix unnamed wallet migration failure
<bitcoin-git> [bitcoin] fanquake merged pull request #34156: wallet: fix unnamed legacy wallet migration failure (master...2025_wallet_migration_jinglewreck) https://github.com/bitcoin/bitcoin/pull/34156
kevkevin has quit [Ping timeout: 240 seconds]
billymcbip has quit [Ping timeout: 272 seconds]
billymcbip has joined #bitcoin-core-dev
billymcbip has quit [Ping timeout: 272 seconds]
TheRec_ has quit []
TheRec has joined #bitcoin-core-dev
TheRec has joined #bitcoin-core-dev
oneeyedalien has quit [Quit: Leaving]
billymcbip has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
___nick___ has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
___nick___ has joined #bitcoin-core-dev
___nick___ has quit [Client Quit]
___nick___ has joined #bitcoin-core-dev
<dergoegge> Does anyone know why we return with 1 (indicating an error) if the user hits ctrl-c before appinit is complete? (https://github.com/bitcoin/bitcoin/blob/90d651a81f51f76a35658bb1e76e8806d09d18b0/src/bitcoind.cpp#L284)
billymcbip has quit [Quit: Client closed]
<dergoegge> I'm trying to test shutdown/kill/restart scenarios and this trips the error detection of the test.
abubakarsadiq has quit [Quit: Connection closed for inactivity]
<dergoegge> furszy ryanofsky you both touched those lines last, maybe you know?
<bitcoin-git> [bitcoin] tboy1337 opened pull request #34219: psbt: validate pubkeys in MuSig2 pubnonce/partial sig deserialization (master...fix-musig2-validation-incomplete) https://github.com/bitcoin/bitcoin/pull/34219
___nick___ has quit [Ping timeout: 240 seconds]
___nick___ has joined #bitcoin-core-dev
___nick___ has quit [Ping timeout: 264 seconds]
___nick___ has joined #bitcoin-core-dev
bitdex has quit [Quit: = ""]
jamesob1566593 has quit [Quit: The Lounge - https://thelounge.chat]
jamesob443688173 has quit [Quit: The Lounge - https://thelounge.chat]
jamesob443688173 has joined #bitcoin-core-dev
jamesob1566593 has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 240 seconds]
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/90d651a81f51...cd6e4c9235f7
<bitcoin-git> bitcoin/master f78f6f1 Ava Chow: wallettool: do not use fs::remove_all in createfromdump cleanup
<bitcoin-git> bitcoin/master cd6e4c9 merge-script: Merge bitcoin/bitcoin#34215: wallettool: fix unnamed createfromdump failur...
<bitcoin-git> [bitcoin] fanquake merged pull request #34215: wallettool: fix unnamed createfromdump failure walletsdir deletion (master...createfromdump-deletion) https://github.com/bitcoin/bitcoin/pull/34215
WakeTrainDev has joined #bitcoin-core-dev
<fjahr> FYI, we'll build the next asmap in a little over 24h: https://github.com/asmap/asmap-data/issues/40
<ryanofsky> dergoegge, the line you linked to should only return failure on failure. the wait() call should return true on ctrl-c, false only if there is some error with the pipe
<ryanofsky> if AppInit is returning false when ctrl-c, that would be wrong and would not be intended. code should be distinguishing interrupted & failure statuses and returning the right one
luke-jr has joined #bitcoin-core-dev
luke-jr_ has quit [Ping timeout: 256 seconds]
kevkevin has joined #bitcoin-core-dev
<sedited> dergoegge do you have a reproducer for that? Can I insert an interrupt on some line and it makes it exit with 1?
<dergoegge> I can reproduce this reliably by just staring the node and immediately hitting ctrl-c
jerryf has quit [Remote host closed the connection]
jerryf has joined #bitcoin-core-dev
jerryf has quit [Ping timeout: 252 seconds]
jerryf has joined #bitcoin-core-dev
takinbo has quit [Ping timeout: 255 seconds]
l0rinc has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 244 seconds]
<bitcoin-git> [bitcoin] fanquake pushed 12 commits to 30.x: https://github.com/bitcoin/bitcoin/compare/e9f73b8149f9...abb6ae2ec59d
<bitcoin-git> bitcoin/30.x 454ac8e furszy: wallet: RestoreWallet failure, erase only what was created
<bitcoin-git> bitcoin/30.x ac4d095 furszy: wallet: fix unnamed wallet migration failure
<bitcoin-git> bitcoin/30.x 8e5c02a furszy: test: add coverage for unnamed wallet migration failure
<bitcoin-git> [bitcoin] fanquake merged pull request #34209: [30.x]: Final backports & 30.2rc1 (30.x...30_2_rc1) https://github.com/bitcoin/bitcoin/pull/34209
<bitcoin-git> [bitcoin] fanquake pushed tag v30.2rc1: https://github.com/bitcoin/bitcoin/compare/v30.2rc1
takinbo has joined #bitcoin-core-dev
<bitcoin-git> [bitcoincore.org] fanquake opened pull request #1213: Bitcoin Core v30.2 (master...bitcoin_core_30_2) https://github.com/bitcoin-core/bitcoincore.org/pull/1213
<bitcoin-git> [qa-assets] maflcko merged pull request #252: Add fuzz inputs (main...main) https://github.com/bitcoin-core/qa-assets/pull/252
<bitcoin-git> [qa-assets] maflcko pushed 3 commits to main: https://github.com/bitcoin-core/qa-assets/compare/c87ae4dd4daf...eac1c57614d7
<bitcoin-git> qa-assets/main 6be1610 MarcoFalke: Add fuzz inputs
<bitcoin-git> qa-assets/main 00c335c Murch: Add failing psbt input
<bitcoin-git> qa-assets/main eac1c57 maflcko: Merge pull request #252 from maflcko/main
jadi has joined #bitcoin-core-dev
maxedw__ is now known as maxedw
jadi has quit [Ping timeout: 240 seconds]
jadi has joined #bitcoin-core-dev
twistedline has quit [Remote host closed the connection]
twistedline has joined #bitcoin-core-dev
<glozow> #proposedmeetingtopic maintainer nomination
greypw1495085720 has quit [Remote host closed the connection]
WizJin_ has joined #bitcoin-core-dev
WizJin__ has quit [Ping timeout: 240 seconds]
kevkevin has quit [Remote host closed the connection]
WizJin__ has joined #bitcoin-core-dev
WizJin_ has quit [Ping timeout: 246 seconds]
twistedline has quit [Ping timeout: 240 seconds]
twistedline has joined #bitcoin-core-dev
<brunoerg> #proposedmeetingtopic incremental mutation testing
deadmanoz has quit [Ping timeout: 260 seconds]
deadmanoz has joined #bitcoin-core-dev
antanst71 has quit [Quit: The Lounge - https://thelounge.chat]
antanst712 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin-detached-sigs] pinheadmz pushed 1 commit to 30.x: https://github.com/bitcoin-core/bitcoin-detached-sigs/compare/ba6a114d0dda...bbc72a717c48
<bitcoin-git> bitcoin-detached-sigs/30.x bbc72a7 Matthew Zipkin: 30.2: osx sig for rc1
Cory96 has joined #bitcoin-core-dev
Cory26 has quit [Ping timeout: 272 seconds]
jonatack has joined #bitcoin-core-dev
l0rinc has quit [Read error: Connection reset by peer]
l0rinc has joined #bitcoin-core-dev
l0rinc has quit [Remote host closed the connection]
l0rinc has joined #bitcoin-core-dev
robszarka has joined #bitcoin-core-dev
___nick___ has quit [Ping timeout: 240 seconds]
szarka has quit [Ping timeout: 246 seconds]
<l0rinc> To help with the recent flood of fake ACKs I pushed a PR to DrahtBot to add the user's avatar to the bot summary field and to highlight org members (with bold) to help maintainers - would appreciate some concept ACKs on https://github.com/maflcko/DrahtBot/pull/72
<sliv3r__-> How does the avatar bot look like? Is there an example to see? Just curiosity
l0rinc has quit [Read error: Connection reset by peer]
l0rinc has joined #bitcoin-core-dev
Cory32 has joined #bitcoin-core-dev
Cory96 has quit [Ping timeout: 272 seconds]
<bitcoin-git> [bitcoin] furszy opened pull request #34221: test: migration, avoid backup name mismatch in default_wallet_failure (master...2026_test_fix_backup_mocktime) https://github.com/bitcoin/bitcoin/pull/34221
<bitcoin-git> [bitcoin] achow101 opened pull request #34222: [29.x] wallettool: fix unnamed createfromdump failure walletsdir deletion (29.x...29.x-createfromdump-deletion) https://github.com/bitcoin/bitcoin/pull/34222
Cory51 has joined #bitcoin-core-dev
<l0rinc> sliv3r__-: It would look something like this: https://gist.github.com/l0rinc/6e92f6ac500a7ab9cc91d0b19a009392
Cory32 has quit [Ping timeout: 272 seconds]
<bitcoin-git> [bitcoin] achow101 opened pull request #34223: [28.x] wallettool: fix unnamed createfromdump failure walletsdir deletion (28.x...28.x-createfromdump-deletion) https://github.com/bitcoin/bitcoin/pull/34223
<bitcoin-git> [bitcoin-detached-sigs] achow101 pushed 1 commit to 30.x: https://github.com/bitcoin-core/bitcoin-detached-sigs/compare/bbc72a717c48...51b85c7c6bd8
<bitcoin-git> bitcoin-detached-sigs/30.x 51b85c7 Ava Chow: 30.2: win sig for rc1
<bitcoin-git> [bitcoin-detached-sigs] achow101 pushed tag v30.2rc1: https://github.com/bitcoin-core/bitcoin-detached-sigs/compare/v30.2rc1
<bitcoin-git> [bitcoin] sedited opened pull request #34224: init: Return EXIT_SUCCESS on interrupt (master...init_interrupt_zero) https://github.com/bitcoin/bitcoin/pull/34224
l0rinc has quit [Quit: l0rinc]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 246 seconds]
Cory51 has quit [Quit: Client closed]
Cory51 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] theStack opened pull request #34225: refactor, key: move `CreateMuSig2{Nonce,PartialSig}` functions to `musig.{h,cpp}` module (master...202601-move-musig-funcs-to-module) https://github.com/bitcoin/bitcoin/pull/34225
Enki has joined #bitcoin-core-dev
Cory51 has quit [Quit: Client closed]
Cory51 has joined #bitcoin-core-dev