< leangjia> Hi,all.
< GitHub119> [bitcoin] MarcoFalke opened pull request #8863: univalue: Pull subtree (master...Mf1610-univalue) https://github.com/bitcoin/bitcoin/pull/8863
< luke-jr> weird, starting my node shows all transactions back to 2010 as "Offline" even after a few connections
< luke-jr> would expect it to show the ones that confirmed in the past as confirmed at least..
< luke-jr> (I can understand not trusting newly confirmed stuff with few connections)
< sipa> transactions can be "offline" ?
< luke-jr> sipa: apparently ☺
< luke-jr> they showed normal after 5 or 6 connections
< wumpus> yes, transactions (in the gui) can be "offline". That transaction classification code is pretty much what it was in satoshi's code, unchanged over all that time
< wumpus> GetAdjustedTime() - wtx.nTimeReceived > 2 * 60 && wtx.GetRequestCount() == 0
< wumpus> most notably it doesn't check the depth, so something can be 100/offline, for whatever that's worth
< wumpus> 'longer than 2 hours old and never requested by other peers'
< luke-jr> wumpus: all of these have been long-confirmed by other peers :p
< wumpus> luke-jr: the logic makes little sense. I wouldn't mind removing that status completely. I don't think it's documented anywhere, and if it surprises even the devs :)
< achow101> how close are we to 0.13.1 release?
< btcdrak> achow101: see the milestone.
< BlueMatt> wumpus: whats you opinion on big code moves?
< BlueMatt> grrr, damn github...whatever, pulls out the CNodeState management from the top of main.cpp to the end as a part of https://github.com/TheBlueMatt/bitcoin/commits/net_processing_file, which disentangles that stuff somewhat and is like 2 functions away from splitting main.cpp in two
< wumpus> achow101: people keep adding new pulls for 0.13.1, but by far the largest change that still has to go in is https://github.com/bitcoin/bitcoin/pull/8393
< wumpus> BlueMatt: code moves are easy to review/verify, so if it makes sense from a code organization viewpoint (and people agree on that) it's fine
< btcdrak> wumpus: there are some trivial merges tho. I think can merge #8848, #8857 and #8817. Havent looked at #8862 but seems trivial enough.
< BlueMatt> wumpus: i was asking in the context of 0.14...when in the release cycle did we say we wanted to do code moves?
< paveljanik> BlueMatt, in the Next one :-)
< GitHub35> [bitcoin] TheBlueMatt opened pull request #8865: Decouple peer-processing-logic from block-connection-logic (master...net_processing_1) https://github.com/bitcoin/bitcoin/pull/8865
< luke-jr> wumpus: well, we really should have better logic for the statuses in general. removing offline alone may make things worse.
< luke-jr> wumpus: if we have few peers or block rate suggests we may be partitioned, we should distrust confirmation
< GitHub168> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6faffb8a83db...6013c73b3312
< GitHub168> bitcoin/master fa66609 MarcoFalke: [qa] mininode: Only allow named args in wait_until
< GitHub168> bitcoin/master 6013c73 MarcoFalke: Merge #8857: [qa] mininode: Only allow named args in wait_until...
< GitHub84> [bitcoin] MarcoFalke closed pull request #8857: [qa] mininode: Only allow named args in wait_until (master...Mf1610-qaMininodeWaitUntil) https://github.com/bitcoin/bitcoin/pull/8857