< GitHub105>
bitcoin/master 36f60a5 Peter Todd: Add copyright/patent issues to possible NACK reasons...
< GitHub105>
bitcoin/master 03dd707 MarcoFalke: Merge #8915: Add copyright/patent issues to possible NACK reasons...
< GitHub97>
[bitcoin] MarcoFalke closed pull request #8915: Add copyright/patent issues to possible NACK reasons (master...2016-10-13-sound-legal-justification) https://github.com/bitcoin/bitcoin/pull/8915
< gmaxwell>
Another subject for the segwit deployment guide, "What if I'm on debian Wheezy and don't have a C++11 compiler"
< sipa>
"Get an odroid and use it as edge router"
< gmaxwell>
okay, yes "see section II on peremeter nodes" -- though isn't there some compiler from the future flag you can hit in wheezy?
< gmaxwell>
(pretty wild that debian in recent memory doesn't have a c++11 compiler...)
< btcdrak>
gmaxwell: are you working on the deployment guide?
< gmaxwell>
no, requirements for the deployment guide.
< gmaxwell>
(GCC 4.7 was like... march 2012, it's 2016 now...)
< sipa>
will debian weezy run release binaries?
< gmaxwell>
I assume, so that would be the obvious answer: border router or release binaries.
< luke-jr>
"upgrade to Debian Jessie"?
< btcdrak>
I wonder if it's something aj would like to do?
< * luke-jr>
notes C++11 is already a requirement for the active csv softfork
< luke-jr>
or is it..
< * luke-jr>
checks when we switched C++11 on
< luke-jr>
I think I'm wrong, 0.12.1 supported pre-C++11 I guess
< gmaxwell>
right
< sipa>
we only switched to compiling with c++11 in 0.13
< sipa>
0.12.x may have been very vlose in being c++11 compliant, but it certaonly did not require it
< gmaxwell>
0.12.x compiles more or less cleanly with a c++11 compiler.
< sipa>
right
< afk11>
Has anyone here implemented the test vectors from bip-0143? In the last example I think I've found an error, it'd be great to check this quickly (writing tests). The scriptCode is 207 (0xcf) bytes, which is greater than OP_PUSHDATA1 (76) and so it's length should be serialized like: 0x4ccf. The scriptCode in the V1 algorithm gets prefixed with it's length, so shouldn't the example have the 0x4c at the start?
< afk11>
ah nevermind, so it's not that you push scriptCode into a script (using the script pushdata length & serialization), instead it's prefixed with a varint
< sipa>
right... exactly as it is in pre-143 sighashing
< afk11>
I didn't equivocate the two because pre-143 the pre-image was a modified transaction, which is no longer true
< BlueMatt>
gmaxwell: dunno about debian, but the oldest ubuntu lts which is still supported cant build bitcoin in c++11 mode (despite its version of clang supporting it) because its version of boost doesnt build in C++11 mode