< jl2012> dcousens: "A non-witness program (defined hereinafter) txin MUST be associated with an empty witness field, represented by a 0x00." means if an input is non-witness program, its associated witness must be empty, which is a 0x00
< jl2012> tx format is [nVersion][marker][flag](varint)[txins](varint)[txouts][witness][nLockTime]
< jl2012> [witness] format is [varint][stack][stack].....[varint][stack][stack]...........
< jl2012> [stack] format is [varint][data]
< jl2012> the varint inside stack is size of data
< jl2012> the varint(s) inside witness is the number of stack for a txin
< jl2012> if an input is non-witness program, the corresponding varint in witness is 0x00, means no stack
< jl2012> if all inputs are non-witness program, the tx must be serialized in the old way
< jl2012> examples of witness serialization could be found in https://github.com/bitcoin/bips/blob/master/bip-0143.mediawiki#Native_P2WPKH
< da2ce7> good morning #bitcoin-core-dev
< jl2012> good afternoon
< GitHub188> [bitcoin] fanquake closed pull request #8733: More granular debug [WIP] (master...MoreGranularDebug.wip) https://github.com/bitcoin/bitcoin/pull/8733
< GitHub180> [bitcoin] sipa pushed 7 new commits to master: https://github.com/bitcoin/bitcoin/compare/072116fceb22...6429cfa8a703
< GitHub180> bitcoin/master 06128da Matt Corallo: Make GetFetchFlags always request witness objects from witness peers...
< GitHub180> bitcoin/master be7555f Matt Corallo: Fix overly-prescriptive p2p-segwit test for new fetch logic
< GitHub180> bitcoin/master 6aa28ab Pieter Wuille: Use cmpctblock type 2 for segwit-enabled transfer...
< GitHub12> [bitcoin] sipa closed pull request #8393: Support for compact blocks together with segwit (master...segwitcb) https://github.com/bitcoin/bitcoin/pull/8393
< BlueMatt> heyyyyyyy
< BlueMatt> yay sipa
< sipa> yay BlueMatt
< sipa> i've really just been merging in your proposed changes to it the past weeks
< BlueMatt> heh
< btcdrak> woot
< GitHub142> [bitcoin] MarcoFalke closed pull request #8871: Make GetFetchFlags always request witness objects from witness peers (master...fetchflags) https://github.com/bitcoin/bitcoin/pull/8871
< jtimon> mhmm, BlueMatt do you know which PR replaced #4692 ?
< jtimon> or anyone, do you remember which PR exposed verifyScript in libconsensus ?
< BlueMatt> jtimon: i dont :/
< wumpus> jtimon: git log -p src/script/bitcoinconsensus.h ?
< jtimon> wumpus: right, it was 2cf5f16c by cfields, in #5235
< jtimon> awesome, got an ACK for #8337 !
< GitHub172> [bitcoin] jonasschnelli pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/6429cfa8a703...bf8e68aba68d
< GitHub172> bitcoin/master faa4de2 MarcoFalke: [qt] sync-overlay: Don't block during reindex
< GitHub172> bitcoin/master fa85e86 MarcoFalke: [qt] sync-overlay: Don't show estimated number of headers left
< GitHub172> bitcoin/master bf8e68a Jonas Schnelli: Merge #8821: [qt] sync-overlay: Don't block during reindex...
< GitHub62> [bitcoin] jonasschnelli closed pull request #8821: [qt] sync-overlay: Don't block during reindex (master...Mf1609-qtSyncReindex) https://github.com/bitcoin/bitcoin/pull/8821
< btcdrak> jtimon: images are broken in that libconsensus repo
< wumpus> a libconsensus repo with images? cool
< sipa> preimages?
< GitHub44> [bitcoin] MarcoFalke opened pull request #8906: [qt] sync-overlay: Don't show progress twice (master...Mf1610-qtSyncProgress) https://github.com/bitcoin/bitcoin/pull/8906