< GitHub17>
[bitcoin] jl2012 opened pull request #8927: Add script tests for FindAndDelete in pre-segwit and segwit scripts (master...findanddeletetest) https://github.com/bitcoin/bitcoin/pull/8927
< GitHub144>
[bitcoin] TheBlueMatt opened pull request #8928: Fix init segfault where InitLoadWallet() calls ATMP before genesis (master...2016-10-fix-segfault) https://github.com/bitcoin/bitcoin/pull/8928
< BlueMatt>
^ I think travis has been lying about tests passing, my reading of the code says it /should/ segfault :/
< luke-jr>
BlueMatt: undefined behaviour is not guaranteed to segfault :D
< friendsofbitcoin>
Which Core dev would be willing to review and creat any needed unit test for this in demand pull request - https://github.com/bitcoin/bitcoin/pull/7534 I would be willing to offer a reward of 0.5BTC for efforts pushing this through. I apologize in advance if this question is inappropriate for this venue as Im not familiar with any precedents
< * luke-jr>
(will be done rebasing it soon FWIW)
< luke-jr>
(done)
< GitHub39>
[bitcoin] TheBlueMatt opened pull request #8930: Move orphan processing to ActivateBestChain (master...net_processing_3) https://github.com/bitcoin/bitcoin/pull/8930
< alpalp>
how hard would it be to modify mining block selection to choose other than first seen?
< luke-jr>
alpalp: not very. see preciousblock RPC.
< luke-jr>
it's not generally a good idea, however.
< alpalp>
why's that luke?
< alpalp>
for example, I might be able to make more fees mining off the 2nd block seen than first.
< luke-jr>
it's liable to cause consensus delay and/or failure
< luke-jr>
for example, you might prefer to make less fees if others will prefer your block over an earlier one
< sipa>
one of the problems that may worsen with declining aubsidy
< sipa>
the incentive to not work on top of the tip may increase in some circumstances
< luke-jr>
I think it gets significantly worse if your peers prefer other than first-seen
< alpalp>
trying to understand the danger before I open a can of worms.
< alpalp>
if there are two "equal" tips at some point in time
< alpalp>
definitely aware of issues down the road with low subsidy
< alpalp>
luke-jr why is it worse if peers are not doing this strategy?