< bitcoin-git> [bitcoin] promag closed pull request #12361: Replace unreachable error handling with assertions in feebumper (master...2018-02-feebumper) https://github.com/bitcoin/bitcoin/pull/12361
< MrBruceWayne> #bitcoin
< sipa> achow101: the "Known issue" you added to the release notes, wasn't that fixed?
< bitcoin-git> [bitcoin] practicalswift opened pull request #12393: Fix a-vs-an typos (master...a-vs-an-typos) https://github.com/bitcoin/bitcoin/pull/12393
< provoostenator> instagibbs: yes, I filed an issue to add NTP support to gitian
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/67447ba06057...89005ddad1c4
< bitcoin-git> bitcoin/master c8edc2c Sjors Provoost: [docs] initial QT documentation, move Qt Creator instructions
< bitcoin-git> bitcoin/master 89005dd Wladimir J. van der Laan: Merge #11761: [docs] initial QT documentation...
< bitcoin-git> [bitcoin] laanwj closed pull request #11761: [docs] initial QT documentation (master...qt-docs) https://github.com/bitcoin/bitcoin/pull/11761
< bitcoin-git> [bitcoin] Sjors opened pull request #12394: gitian-builder.sh: fix --setup doc, since lxc is default (master...2018/02/gitian-build-setup-lxc) https://github.com/bitcoin/bitcoin/pull/12394
< provoostenator> I made an attempt at simplifying the gitian instructions: https://github.com/bitcoin-core/docs/pull/25
< dongcarl> provoostenator: Super helpful
< promag> wumpus: rc4 #12392 ?
< gribble> https://github.com/bitcoin/bitcoin/issues/12392 | Fix ignoring tx data requests when fPauseSend is set on a peer by TheBlueMatt · Pull Request #12392 · bitcoin/bitcoin · GitHub
< wumpus> really?
< wumpus> I don't think it's worth doing yet another rc just because of that, but we still have a week to go I suppose
< promag> ah maybe he means 0.16.1
< promag> #12287 is a simple and nice cleanup
< gribble> https://github.com/bitcoin/bitcoin/issues/12287 | Optimise lock behaviour for GuessVerificationProgress() by jonasschnelli · Pull Request #12287 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] azuchi opened pull request #12396: [Doc] Fix typo (0.16...0.16) https://github.com/bitcoin/bitcoin/pull/12396
< provoostenator> I tried #11857, deleted the indexes folder, swichted back to master and then tried to use index=1. If I agree to rebuilding the block database I get "Error opening block database". Any ideas?
< gribble> https://github.com/bitcoin/bitcoin/issues/11857 | Build tx index in parallel with validation by jimpo · Pull Request #11857 · bitcoin/bitcoin · GitHub
< provoostenator> (technically master from yesterday)
< provoostenator> Master from today has the same issue. Seems to works fine with txindex=0. Seems to be QT specific, bitcoind does reindex.
< provoostenator> In fact, if I let bitcoind do its thing for a minute, stop it and then start QT, it's happy.
< provoostenator> (by happy I mean that it takes over the reindex work)
< wumpus> hmm strange
< achow101> sipa: yeah, that was fixed. Originally we weren't going to fix it but then we did
< provoostenator> It's actually happening on master: "testnet3/blocks/index/LOCK: already held by process"
< provoostenator> I'm pretty sure I quit QT cleanly, so don't know why that lock file doesn't get removed.
< provoostenator> Also I think I'm confused about the difference between chainstate, blocks/index and the proposed /indexes directory.
< provoostenator> If I delete blocks/index and start QT, it immedidately creates a fresh directory with a LOCK file. It then complains "Error initializing block database [rebuild?]". If I say OK I get error building block database and the log compalins "LOCK: already held by process"
< provoostenator> If instead I click on Abort, it also doesn't clean up the LOCK file.
< provoostenator> Launching with -reindex avoids the error message.
< provoostenator> Deleting the LOCK file before agreeing to "Do you want to rebuild the block database now?" doesn't help either; it just creates a new one and throws the above error
< provoostenator> This seems to be the problem: https://github.com/bitcoin/bitcoin/blob/master/src/init.cpp#L1428 (fReset=true here)
< provoostenator> Which then calls CDBWrapper::CDBWrapper with fWipe = true, which calls leveldb::DestroyDB which fails if the file is locked.
< jimpo> Why would that be QT specific then?
< provoostenator> Because bitcoind refuses to start withotu -reindex
< provoostenator> Whereas QT will first open the levelDB file, then find a problem and then run the loop again trying to wipe it.
< provoostenator> I think it needs to close the DB file first
< jimpo> I'll try to reproduce on master
< provoostenator> Deleting blocks/index is probably the easiest way to produce the issue
< provoostenator> I "fixed" the issue by adding one line above: if (fReset) { pblocktree.reset(); }
< provoostenator> jimpo: actually, I had to use the chainstate dir generated by your branch (though possibly corrupted due to some other mistake on my end) to get the error
< jimpo> I think my testnet chain is corrupt anyway, so I need to deal with that first
< bitcoin-git> [bitcoin] Sjors opened pull request #12401: Reset pblocktree before deleting LevelDB file (master...2018/02/reset-pblocktree) https://github.com/bitcoin/bitcoin/pull/12401
< berndj> why were dev keys removed from contrib/gitian-keys/ and replaced with a list of fingerprints? isn't this dangerous now that SHA1 is on its last legs?
< mesh_> berndj: well, finding collisions is much easier than preimage attacks
< meshcollider> berndj: see #11909 for reasoning
< gribble> https://github.com/bitcoin/bitcoin/issues/11909 | contrib: Replace developer keys with list of pgp fingerprints by MarcoFalke · Pull Request #11909 · bitcoin/bitcoin · GitHub
< berndj> i wonder how long it'll be before sha1 preimage attacks are $100bn-level feasible