01:10 < bitcoin-git> [bitcoin] kallewoof opened pull request #12484: [net] Skip stale tip checks in regtest (master...no-staletip-check-regtest) https://github.com/bitcoin/bitcoin/pull/12484

01:16 < bitcoin-git> [bitcoin] bitnitdit opened pull request #12485: Mining: The max number of halvings should be 32 (master...max_halvings) https://github.com/bitcoin/bitcoin/pull/12485

01:55 < bitcoin-git> [bitcoin] kallewoof closed pull request #11019: [wallet] Abandon transactions that fail to go into the mempool (master...abandon-longchain-failed-tx) https://github.com/bitcoin/bitcoin/pull/11019

02:35 < sipa> achow101: technically you can't mix sctruct and class declarations of the same type

02:35 < sipa> but not every compiler version cares

02:38 < achow101> sipa: right

02:38 < achow101> does it matter though?

02:39 < bitcoin-git> [bitcoin] sipa pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/dcfe218626b0...ffc6e48b2983

02:39 < bitcoin-git> bitcoin/master 1e79c05 Andrew Chow: Split signrawtransaction into wallet and non-wallet...

02:39 < bitcoin-git> bitcoin/master eefff65 Andrew Chow: scripted-diff: change signrawtransaction to signrawtransactionwithwallet in tests...

02:39 < bitcoin-git> bitcoin/master d602348 Andrew Chow: Add test for signrawtransaction...

02:39 < sipa> it should be fixed, as it's going to cause warnings for some people

02:39 < bitcoin-git> [bitcoin] sipa closed pull request #10579: [RPC] Split signrawtransaction into wallet and non-wallet RPC command (master...split-signraw) https://github.com/bitcoin/bitcoin/pull/10579

02:39 < sipa> but i just merged the PR; no need to delay this further

02:39 < achow101> ok then

03:04 < bitcoin-git> [bitcoin] achow101 closed pull request #11678: [wallet] Don't shut down after encrypting the wallet (master...encrypt-no-restart) https://github.com/bitcoin/bitcoin/pull/11678

03:05 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #12485: Mining: The max number of halvings should be 32 (master...max_halvings) https://github.com/bitcoin/bitcoin/pull/12485

04:21 < bitcoin-git> [bitcoin] kallewoof opened pull request #12486: [test] Round target fee to 8 decimals (master...round-assert-fee-amount-target-fee) https://github.com/bitcoin/bitcoin/pull/12486

08:08 < promag> achow101: sipa: right, the warning is a non blocker imo

09:50 < bitcoin-git> [bitcoin] laanwj opened pull request #12487: init: Remove translation for `-blockmaxsize` option help (master...2018_02_translation_nightmare) https://github.com/bitcoin/bitcoin/pull/12487

10:08 < bitcoin-git> [bitcoin] jonasschnelli opened pull request #12489: Bugfix: respect user defined configuration file (-conf) in QT settings (master...2018/02/qt_conf) https://github.com/bitcoin/bitcoin/pull/12489

11:31 < mryandao> hey all, how do I patch diffs from upstream to my local working set?

12:02 < mryandao> oh man, did i do the rebase correctly for https://github.com/bitcoin/bitcoin/pull/12240/commits/1869b838e1a818cba6929f6ccdc5c813cc617471?

12:03 < mryandao> doesnt look right on github to me.

12:51 < eklitzke> looks like you squashed too much to me

14:22 < bitcoin-git> [bitcoin] jnewbery opened pull request #12490: Remove deprecated wallet rpc methods from server (master...remove_deprecated_rpcs) https://github.com/bitcoin/bitcoin/pull/12490

14:23 < bitcoin-git> [bitcoin] jnewbery closed pull request #12490: Remove deprecated wallet rpc methods from server (master...remove_deprecated_rpcs) https://github.com/bitcoin/bitcoin/pull/12490

14:34 < arubi> more thoughts on #12321 ? I think it would be a nice addition for working with multisig in segwit

14:34 < gribble> https://github.com/bitcoin/bitcoin/issues/12321 | p2wsh and p2sh-p2wsh address in decodescript by fivepiece · Pull Request #12321 · bitcoin/bitcoin · GitHub

16:36 < nman999> What is the easiest way to install the Berkeley DB dependencies on Debian Stretch?

16:38 < arubi> nman999, why do you want to install it system wide at all?

17:54 < bitcoin-git> [bitcoin] eklitzke opened pull request #12491: Try to use posix_fadvise with CBufferedFile (master...fadvise) https://github.com/bitcoin/bitcoin/pull/12491

19:12 < mrannanay> ```

19:13 < mrannanay> ```

19:13 < mrannanay> libbitcoin_server.a(libbitcoin_server_a-net.o): In function `CCriticalBlock::Enter(char const*, char const*, int)':

19:13 < mrannanay> /home/annanay/bitcoin/src/./sync.h:123: undefined reference to `EnterCritical(char const*, char const*, int, void*, bool)'

19:13 < mrannanay> ```

19:13 < mrannanay> I seem to be getting this recurring error when I build the source.

19:13 < mrannanay> Even though I'm using ```./configure CXXFLAGS="-DDEBUG_LOCKORDER -g"``` when I configure

19:13 < mrannanay> Reposting for better formatting

19:13 < mrannanay> ```

19:13 < mrannanay> libbitcoin_server.a(libbitcoin_server_a-net.o): In function `CCriticalBlock::Enter(char const*, char const*, int)':

19:13 < mrannanay> /home/annanay/bitcoin/src/./sync.h:123: undefined reference to `EnterCritical(char const*, char const*, int, void*, bool)'

19:13 < mrannanay> ```

19:15 < mrannanay> IIUC, the -DDEBUG_LOCKORDER should define the right ```EnterCritical``` in src/net.cpp

19:19 < mrannanay> *src/sync.h

19:30 < sipa> mrannanay: are you sure you're recompiling everything with -DDEBUG_LOCKORDER, and aren't accidentally reusing a sync.o built withouy?

20:05 < midnightmagic> Would it be useful if the database files-- either the chainstate or otherwise-- had a human-readable journalling log and/or bitcoind could be told to lock the db layers while an external program ran? (say to snapshot the db or something?)

20:06 < Randolf> midnightmagic: Are you thinking for backup purposes mainly?

20:07 < midnightmagic> Either for backup, or for db reliability measures on a desired high-uptime node.. or something.

20:08 < sipa> we already have a journalling log for the chainstate

20:08 < midnightmagic> like for fs snapshotting for example.

20:08 < sipa> it's called the blockchain

20:08 < midnightmagic> rebuilding to a known-good state is hard.. ish. :-P

20:09 < sipa> well instructing bitcoind to not write any changes to disk for a while would be certainly doable

20:09 < sipa> if you want to support snapshots or so

20:10 < midnightmagic> hrmm..

20:10 < sipa> it could even continue updating the internal cache, until its size grows too large

20:10 < midnightmagic> is there a db cache which needs to be flushed for that?

20:10 < sipa> yes

20:10 < sipa> all disk writes are localized in a single function

20:10 < midnightmagic> ok.

20:11 < sipa> excluding txindex...

20:11 < sipa> that's just a hack :)

20:11 < midnightmagic> :-)

20:27 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ffc6e48b2983...e117cfe45eee

20:27 < bitcoin-git> bitcoin/master a6e6e39 Jonas Schnelli: Bugfix: respect user defined configuration file (-conf) when open conf. file from QT settings

20:28 < bitcoin-git> bitcoin/master e117cfe MarcoFalke: Merge #12489: Bugfix: respect user defined configuration file (-conf) in QT settings...

20:28 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #12489: Bugfix: respect user defined configuration file (-conf) in QT settings (master...2018/02/qt_conf) https://github.com/bitcoin/bitcoin/pull/12489

21:29 < bitcoin-git> [bitcoin] achow101 opened pull request #12493: [wallet] Reopen CDBEnv after encryption instead of shutting down (master...dbenv-reopen) https://github.com/bitcoin/bitcoin/pull/12493

22:17 < bitcoin-git> [bitcoin] Empact opened pull request #12494: Declare CMutableTransaction a struct in rawtransaction.h (master...mutabletransaction-struct) https://github.com/bitcoin/bitcoin/pull/12494

22:37 < bitcoin-git> [bitcoin] eklitzke opened pull request #12495: Increase LevelDB max_open_files on 64-bit POSIX systems (master...ldb_max_open_files) https://github.com/bitcoin/bitcoin/pull/12495