so i don't think there is any freeze on the master branch, just not a lot of focus
sipa: ah, okay, cool :)
We need to be careful about updating copyright dates, and extending "2017" to a range of "2017-2018" instead of merely replacing with a new year of "2018." I made these comments in this PR, but also mention it here in case someone else also encounters a year that needs updating elsewhere:
[bitcoin] Empact opened pull request #12357: Rationalize the CValidationState interface by splitting ::DoS across ::Invalid and ::Corrupt (master...validation-state-corrupt) https://github.com/bitcoin/bitcoin/pull/12357
afaict you should absolutely be able to hit that same case in 0.15.1
just as long as your disk is somewhat slow to get the first block loaded before you can quit
oh, err...wow that's one hell of a race, you have to manage to kill right after pcoinsTip is created after the db is loaded and emptied and before the ActivateBestChain call in LoadChainTip (so that it returns from the ShutdownRequested() check)
so jnewbery, regarding #12360, do we want to remove bip9? don't we want to reuse that code for bip8 ?
nevermind you're just removing tests related to csv it seems, perhaps conserve some parts of feature_bip9_softforks with the dummy deployment?
BlueMatt: unsure. I hit it last night and didn't have time to look at it deeply, I just didn't want to forget about it. Looking now
BlueMatt: I assumed it was a regression caused by the FlushStateToDisk changes in init, but sure, maybe it's unrelated
jtimon: feature_bip9_softforks only tests CSV. it was never extended to test other bip9 deployments. It's also written using the comparison test framework, so i think it should just be removed
jnewbery: makes sense, thanks, we have the unittests for the dummy deployment anyway
if anybody's got some spare time for more review on #12315 or #12321, I'd appreciate your input