< mryandao> i've re-based #12240, would someone please have a look :)?
< gribble> https://github.com/bitcoin/bitcoin/issues/12240 | [rpc] For consistency, changed Satoshi fee denominations to BTC by mryandao · Pull Request #12240 · bitcoin/bitcoin · GitHub
< promag> mryandao: there you go
< achow101> ryanofsky: how do I use condition_variable with our locks?
< achow101> I'm not very familiar with the locks stuff we use
< luke-jr> achow101: GBT long polling does it
< mrannanay> sipa: I ran make clean and then make again, the sync.cpp error is gone. Thanks!
< mrannanay> How can I run unit tests for src/net.cpp ?
< mrannanay> make check seems to pass despite (known, deliberate) errors in src/net.cpp
< drizztbsd> hi, is rc4 the final candidate?
< hasish> is there a way to stop incoming packets from the network, other then "setnetworkactive false" ?
< cfields> hasish: you can prevent incoming connections with -listen=0
< cfields> not sure if that's what you meant
< bitcoin-git> [bitcoin] randolf opened pull request #12501: [qt] Improved "custom fee" explanation in tooltip (master...patch-2) https://github.com/bitcoin/bitcoin/pull/12501
< Lauda> timothy: if no new bugs are found, I believe yes
< bitcoin-git> [bitcoin] instagibbs opened pull request #12503: [RPC] createmultisig no longer takes addresses (master...createmultikey) https://github.com/bitcoin/bitcoin/pull/12503
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e117cfe45eee...e4ffcacc2187
< bitcoin-git> bitcoin/master eacc5b2 Ben Woosley: Declare CMutableTransaction a struct in rawtransaction.h...
< bitcoin-git> bitcoin/master e4ffcac MarcoFalke: Merge #12494: Declare CMutableTransaction a struct in rawtransaction.h...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12494: Declare CMutableTransaction a struct in rawtransaction.h (master...mutabletransaction-struct) https://github.com/bitcoin/bitcoin/pull/12494
< promag> mryandao: I don't see any verbosity argument or flag
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e4ffcacc2187...0e265916d1c6
< bitcoin-git> bitcoin/master e4c924c Gregory Sanders: createmultisig no longer takes addresses
< bitcoin-git> bitcoin/master 0e26591 MarcoFalke: Merge #12503: [RPC] createmultisig no longer takes addresses...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12503: [RPC] createmultisig no longer takes addresses (master...createmultikey) https://github.com/bitcoin/bitcoin/pull/12503
< mryandao> promag: getrawmempool ( verbose )
< mryandao> getmempoolancestors txid (verbose)
< mryandao> the only RPC command without the verbosity argument is getmempoolentry.
< mryandao> for all the getmempool* rpc commands
< bitcoin-git> [bitcoin] sauldrod opened pull request #12506: Update new qt.mk download url (0.10...patch-1) https://github.com/bitcoin/bitcoin/pull/12506
< mryandao> promag: did you see what I posted? ^
< promag> no
< promag> sorry
< mryandao> so w.r.t verbosity argument: there's getrawmempool (verbose), getmempoolancestors txid (verbose) and etc.
< mryandao> that was what I meant.
< mryandao> promag: ^
< promag> ah getmempoolentry doesn't have it
< mryandao> yeah, just that one.
< mryandao> i've updated the release notes again to exclude getmempoolentry.
< promag> ok, I was going to suggest to not mention that in the release note, it's a detail I guess, but others may think otherwise
< mryandao> have you had a look at the mempool_packages test already?
< promag> mryandao: could you point the test where the others rpcs are tested against getrawmempool?
< mryandao> give me a sec
< promag> tks
< mryandao> my clipboard is broken on this setup, so i'll just give you the line numbers in mempool_packages
< mryandao> T.T
< mryandao> promag, on master, in mempool_package, line 82 - 86 & 89 - 92
< mryandao> for getmempoolentry, line 63.
< promag> ty