< esotericnonsense>
will have to fiddle when I have some more time. CWallet inherits from CValidationInterface, but it overrides TransactionRemovedFromMempool. if you kill it from CValidationInterface and remove the override along with a few other bits of code I think is dead you're there.
< esotericnonsense>
ah, it's finally clear now. connectTrace is the thing that actually uses it. just a few steps deep
< ken2812221>
Gitian build fails on Windows and Linux on master branch.
< ken2812221>
It says "No rule to make target `zlib/adler32.o', needed by `zlib/libz.a'. Stop."
< ken2812221>
But no problem when building MacOS
< ken2812221>
Seems it fails after 2018-02-17, according to jonasschnelli's website.
< achow101>
ken2812221: that's interesting. That's the same error showing up here: https://github.com/bitcoin/bitcoin/issues/12515 I think a dependency might have changed/updated which is now breaking that
< ken2812221>
Just followed build-window.md, it failed on 32-bit and succeed on 64-bit
< achow101>
The 64 bit build failed in a clean 14.04 vm for me. I'm trying a clean 17.10 vm next. It works in my normal 17.10 environment, but that could be because of some other things in my environment that makes it work
< achow101>
ken2812221: which build of windows failed in gitian?
< achow101>
32 or 64 bit?
< ken2812221>
it fails when build 32-bit, so it won't built 64-bit
< ken2812221>
ok, it seem like it works on higher version since I test 64-bit on WSL and 32-bit on my Debian 8 vm
< ken2812221>
64-bit also fails on my Debian vm
< achow101>
you should be able to fix that problem by installing zlib1g-dev
< achow101>
ken2812221: ^
< ken2812221>
yeah, that works.
< fanquake>
achow101 looks like the ccache zlib issue has been fixed upstream, should be included in 3.4.2
< bitcoin-git>
[bitcoin] practicalswift opened pull request #12534: tests: Specify skipped flake8 warnings (rather than enabled warnings) (master...lint-python-invert) https://github.com/bitcoin/bitcoin/pull/12534
< stevenroose>
"For example, in Bitcoin Core 50KB within blocks are reserved for high priority transactions." Is this still the case?
< gmaxwell>
Of course not.
< sipa>
where do you read that?
< gmaxwell>
miners turned that stuff off years ago, and the functionality was subsiquently removed (it massively slowed down block template creation)
< gmaxwell>
it should be a crime to end a url with .pdf but have it just be a webage.
< sipa>
punishable by death by pwnage?
< stevenroose>
Hahaha, agreed
< gmaxwell>
maybe it's just me, but I continually wget urls like that then find myself irritated that I didn't get the file.
< meshcollider>
gmaxwell: yeah it also messes up a lot of mobile browsers :(
< gmaxwell>
cfields: re #12519 it's now been multiple _years_ since it was suggesed that we use MSG_MORE. We shouldn't keep delaying simple improvements forever.
< gmaxwell>
eklitzke: re #12495 is there a way to query if leveldb is going to do the mmap thing more directly rather than using 64/32 bitness as a proxy?