< bitcoin-git> [bitcoin] kallewoof opened pull request #13586: refactor: add benchmarks and speed up bech32 encoder (master...bech32-encode-char) https://github.com/bitcoin/bitcoin/pull/13586
< kallewoof> Are we strict on variable length array used [-Werror,-Wvla] ? Doing malloc/free drops the speed quite a lot :-/
< sipa> kallewoof: MSVC doesn't support vla
< sipa> kallewoof: however, bech32 strings are limited to 90 characters :)
< kallewoof> OH
< kallewoof> Thanks!
< sipa> also, is there any place where the performance of bech32 encoding matters? :)
< kallewoof> Maybe :)
< kallewoof> If someone were to, say, make a vanity address generator for bech32.
< sipa> haha
< sipa> i have secp256k1 code for grinding keys somewhere
< kallewoof> Ohh, can I see it?
< sipa> it's an open PR against the repo
< kallewoof> Found it! Thanks
< kallewoof> Hm. I didn't realize secp256k1 master and bitcoin secp256k1 were as different as they are.
< sipa> they're not so different i think?
< sipa> API should be the same
< kallewoof> Well, applying your PR to the bitcoin one is not trivial, that's for sure. E.g. ecmult_impl.h is 407 lines on bitcoin and 1011 lines on bitcoin-core/secp256k1
< kallewoof> (1011 lines on your PR, actually, but yeah, it only adds 1 line)
< kallewoof> I could just use secp256k1 master. Esp if API is the same.
< sipa> just copy over the whole secp256 code
< * kallewoof> nods
< bitcoin-git> [bitcoin] Empact closed pull request #13267: refactoring: Clean up GetWitnessCommitmentIndex (master...witness-committment-index) https://github.com/bitcoin/bitcoin/pull/13267
< * kallewoof> wonders why secp256k1 refuses to #include for an hour+ then realizes it is including /usr/local/include/secp256k1.h ...
< kallewoof> I have no idea why I even have a secp256k1.h there in the first place.
< bitcoin-git> [bitcoin] lijhui opened pull request #13587: test (master...master) https://github.com/bitcoin/bitcoin/pull/13587
< bitcoin-git> [bitcoin] fanquake closed pull request #13587: test (master...master) https://github.com/bitcoin/bitcoin/pull/13587
< kallewoof> sipa: That function is insanely fast. I have to double check but many times faster than just making them one at a time. (I used 1024 as count... should probably experiment with other values)
< sturles> arowser: Please fix your connection.
< jbaczuk> Are the release branches on github supposed to build (tag v0.16.1) seems to fail build
< echeveria> they do build.
< jbaczuk> should make -s -j4 work then?
< jbaczuk> i must be doing something wrong...
< echeveria> jbaczuk: if you take this to #bitcoin and post some make ouput I can give you some help.
< jbaczuk> escheveria: It builds it was something wrong with my sync script syncing to my build VM, thanks
< crc32> by bitcoind process just started shutting down after getting this from debug.log
< crc32> 2018-07-02 15:28:12 AcceptToMemoryPool: peer=521: accepted bcf14065816d05f2befce7540ee7988d305557c73124249624c06dd15d399026 (poolsz 8194 txn, 26947 kB)
< crc32> 2018-07-02 15:28:12 Interrupting HTTP server
< crc32> 2018-07-02 15:28:12 libevent: event_del: 0x55ac0281c5a8 (fd 9), callback 0x7f866a90b8a0
< crc32> 2018-07-02 15:28:12 libevent: Epoll DEL(1) on fd 9 okay. Old events were 2; read change was 2 (del); write change was 0 (none); close change was 0 (none)
< crc32> after which all these threads started shutting down. but in the end the bitcoind process was stuck in a futexwait and never terminated.
< crc32> I'm running Bitcoin Core Daemon version v0.16.1.0-gdac5d68fc6cf
< gmaxwell> crc32: what is in your log above the AcceptToMemoryPool? The log explaining the shutdown can be (and often is) higher than the last uninteresting line.
< gmaxwell> use 0bin or another pastebin.
< gmaxwell> Can you go back to 15:27?
< crc32> it was just accepting transactions to the memorypool then poof. I see libevent which I don't recognize.
< crc32> 15:27
< gmaxwell> Hm. the only remotely interesting thing I see is that your connections are full.
< gmaxwell> 2018-07-02 15:27:25 failed to find an eviction candidate - connection dropped (f
< gmaxwell> ull)
< gmaxwell> 2018-07-02 15:27:34 failed to find an eviction candidate - connection dropped (f
< gmaxwell> ull)
< bitcoin-git> [bitcoin] wodry opened pull request #13588: Docs: Improve doc of options addnode, connect, seednode (master...improve-documentation-connect-addnode-seednode) https://github.com/bitcoin/bitcoin/pull/13588
< sipa> wumpus: i've swapped out #13062 for #13491 on the high priority list, as i have more things blocked by the latter
< gribble> https://github.com/bitcoin/bitcoin/issues/13491 | Improve handling of INVALID in IsMine by sipa · Pull Request #13491 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13062 | Make script interpreter independent from storage type CScript by sipa · Pull Request #13062 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] Empact closed pull request #13584: Audit string.h inclusion (master...cstring) https://github.com/bitcoin/bitcoin/pull/13584
< bitcoin-git> [bitcoin] Empact closed pull request #13583: Audit stdlib inclusion (master...stdlib) https://github.com/bitcoin/bitcoin/pull/13583
< CubicEarths> arowser: Your are having connection issues...
< bitcoin-git> [bitcoin] satwo opened pull request #13589: Fix command line help for -printtoconsole and -debuglogfile (master...master) https://github.com/bitcoin/bitcoin/pull/13589