< petertodd>
gmaxwell: given how long the expiration period is of time-based mempool expiration the total bandwidth used by expired txs can't be all that high
< luke-jr>
#13191 added an explicit cpuid asm call, without the necessary cpuid feature checks; it says it did this because cpuid.h's wrapper doesn't support subleafs; but cpuid.h has another wrapper that DOES support subleafs..
< luke-jr>
furthermore, it doesn't look like the code is actually *using* subleafs?
< luke-jr>
sipa: ^ what's going on here?
< sipa>
luke-jr: it is using subleaf 0 of leaf 7
< luke-jr>
sipa: subleaf 0 isn't the default subleaf?
< sipa>
luke-jr: no, not all leafs have subleafs
< sipa>
the non-subleaf cpuid code doesn't initialize the register that indicates the subleaf
< luke-jr>
hm
< luke-jr>
what's wrong with __get_cpuid_count then? <.<
< sipa>
luke-jr: not available in all GCC versions we use
< luke-jr>
i c
< sipa>
or not in all compilers we use in general
< luke-jr>
any idea how master is passing Travis, when the simple cpuid call we use clobbers ebx, which is used for PIC on x86-32? :x
< sipa>
luke-jr: it seems that sufficiently recent GCC will just temporarily move the PIC register when you have asm code that indicates clobbering ebx
< sipa>
but older GCC will give an error
< luke-jr>
is someone already working on a fix/workaround for that?
< sipa>
#13611
< gribble>
https://github.com/bitcoin/bitcoin/issues/13611 | [bugfix] Use __cpuid_count for gnu C to avoid gitian build fail. by ken2812221 · Pull Request #13611 · bitcoin/bitcoin · GitHub
< sipa>
ecx, not ebx
< luke-jr>
sipa: shouldn't we still be checking for cpuid support/max (in the __asm__ fallback, after 13611)?
< bitcoin-git>
bitcoin/master 63c16ed Chun Kuan Lee: Use __cpuid_count for gnu C to avoid gitian build fail.
< bitcoin-git>
bitcoin/master b55f0c3 Wladimir J. van der Laan: Merge #13611: [bugfix] Use __cpuid_count for gnu C to avoid gitian build fail....
< bitcoin-git>
[bitcoin] laanwj closed pull request #13611: [bugfix] Use __cpuid_count for gnu C to avoid gitian build fail. (master...sha256-cpuid) https://github.com/bitcoin/bitcoin/pull/13611
< bitcoin-git>
bitcoin/master 5e362c0 Samuel B. Atwood: Fix command line help for -printtoconsole and -debuglogfile...
< bitcoin-git>
bitcoin/master 17e9106 Wladimir J. van der Laan: Merge #13614: doc: Update command line help for -printtoconsole and -debuglogfile (satwo)...
< bitcoin-git>
[bitcoin] laanwj closed pull request #13614: doc: Update command line help for -printtoconsole and -debuglogfile (satwo) (master...satwo_contrib_rebased) https://github.com/bitcoin/bitcoin/pull/13614
< bitcoin-git>
bitcoin/master 8564435 Jeff Frontz: Corrected text to reflect new[er] process of specifying fingerprints instead of individual keys.
< bitcoin-git>
bitcoin/master 8cc048e Wladimir J. van der Laan: Merge #13605: Docs: corrected text to reflect new[er] process of specifying fingerprints...
< bitcoin-git>
[bitcoin] laanwj closed pull request #13605: Docs: corrected text to reflect new[er] process of specifying fingerprints (master...update-gitian-keys-README) https://github.com/bitcoin/bitcoin/pull/13605
< bitcoin-git>
bitcoin/master ed82f17 Gregory Sanders: have verifytxoutproof check the number of txns in proof structure
< bitcoin-git>
bitcoin/master d280617 Suhas Daftuar: [qa] Add a test for merkle proof malleation
< bitcoin-git>
bitcoin/master 7e74c54 Wladimir J. van der Laan: Merge #13452: rpc: have verifytxoutproof check the number of txns in proof structure...
< bitcoin-git>
[bitcoin] laanwj closed pull request #13452: rpc: have verifytxoutproof check the number of txns in proof structure (master...actuallyverifytxoutproof) https://github.com/bitcoin/bitcoin/pull/13452
< jnewbery>
promag: are you still targetting v0.17 for #13100?
< bitcoin-git>
[bitcoin] Empact opened pull request #13619: Inlcude cstring rather than cstddef in compat/glib_sanity.cpp (master...glib-sanity) https://github.com/bitcoin/bitcoin/pull/13619
< jimpo>
#12254 is updated according to new BIP 158 rules (more efficient GCS params, filter with out + prevout scripts)
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #13562: travis: Switch back to trusty for now (master...Mf1806-qaTravisTrusty) https://github.com/bitcoin/bitcoin/pull/13562