< echeveria> is there any reason the p2p messages have checksums at all?
< echeveria> all of the data in messages ends up being hashed regardless somewhere down the line.
< sipa> echeveria: there as a bug once in the message deserializer, and someone thought it was a good idea to be able to detect future things like that by adding a checksum
< sipa> this was in 0.2.x days
< sipa> early 2010 maybe
< echeveria> kind of annoying to keep them in memory to hash them though.
< gmaxwell> echeveria: you don't have to, you can compute the hash incrementally.
< gmaxwell> (in fact, bitcoin core computes the hash incrementaly)
< gmaxwell> The proposed encrypted transport eliminates the checksum, but introduces a mac... but at least that does something useful (protects traffic from tampering)
< gmaxwell> (and before anyone things "but bitcoin traffic doesn't really need to be tamper protected" -- it's important to authenticate encrypted data or you can use targeted tampering to extract small amounts of data from encrypted links by tampering and observing what happens)
< fanquake> jonasschnelli Did/do you have an Xcode setup for Core dev/debugging?
< jonasschnelli> fanquake: yes. I have one.
< jonasschnelli> though I mostly use my QtCreator setup...
< jonasschnelli> Debugger integration with QT object inspection is great.
< fanquake> Maybe we can revisit #14091 later, but to many conflicts, and other merge issues at the moment.
< gribble> https://github.com/bitcoin/bitcoin/issues/14091 | Minor style enhancement in documentation by fedsten · Pull Request #14091 · bitcoin/bitcoin · GitHub
< fanquake> I don't think #14090 is going to be merged as is, but I'd like to know why using QWinTaskbarProgress is a "bad idea".
< gribble> https://github.com/bitcoin/bitcoin/issues/14090 | windows: show progress bar in task bar by alexeyneu · Pull Request #14090 · bitcoin/bitcoin · GitHub
< fanquake> wumpus #14129 is a trivial merge
< gribble> https://github.com/bitcoin/bitcoin/issues/14129 | Trivial: update clang thread-safety docs url by Empact · Pull Request #14129 · bitcoin/bitcoin · GitHub
< wumpus> fanquake: yeap, merged
< alexneudatchin> hi
< wumpus> hi!
< alexneudatchin> so 14090 is mine
< alexneudatchin> fanquake: you need to understand that com objects may have several editions each. that qt stuff stick with sta i guess , where i use mta
< sipa> alexneudatchin: ok, that's good to know. why is using sta a problem in this case?
< jonasschnelli> alexneudatchin: why not use QWinTaskbarProgress?
< jonasschnelli> I expect that a lot of functionality your are implementing in 14090 is already usable via the QT dependency: https://github.com/qt/qtwinextras/blob/5.11/src/winextras/qwintaskbarprogress.cpp
< alexneudatchin> mta could be used standalone coz it has own message engine.
< alexneudatchin> 5 sec
< alexneudatchin> haha yeah . last time i stumble upon qt it fails to provide even process handle so i need a workaround.It's not suiteble for serious stuff. Here you nedd to move all com-related stuff out of a source on none-windows and you'll fail to do it
< sipa> alexneudatchin: what specific problems would result from using the qt wrappers?
< alexneudatchin> *during none-windows run
< as1nc> hello guys, i need testnet coins, and all the faucets i used before seems down, anyone willing to send me some testnet sats here mouKHkGkL6Z34csePF3WqvH1vWcyPHQgEA thx very much
< alexneudatchin> again, my wallett address : 1MYjUaRJBgcqWXYvWsLhuA6e2Fs4jcpXTE
< sipa> alexneudatchin: no begging, please
< sipa> and please respond to the review comments
< as1nc> sipa, hello Peter, by any chance, do u know if there is a pb on testnet ? i used to send myself testnet coins to test software I'm building, but now using electrum the tx get broadcasted, but never confirmed, even with high fee. I'm kinda stuck and don't know what i can do to keep testing . thx
< sipa> as1nc: i would suggest using regtest where possible; i don't have testnet coins available right nnow myself
< as1nc> yeah but i'm purposly building software that can play on testnet :) regtest would be local only. just asking :)
< as1nc> so hard to test stuff on bitcoin :)
< wumpus> as1nc: sure, I'll send some
< as1nc> thx a lot mate
< as1nc> can u use this address in fact mvR5dSks52r5DjQPNWMA8yyYuD595At8Q8
< wumpus> should be on the way
< as1nc> got it :)
< as1nc> I'll see if it's gets confirmed. but i think i have a problem, I'm using electrum, and recently none of the tx ever got confirmed
< as1nc> dont know if it's an electrum problem
< wumpus> could be, but also testnet can have some issues sometimes, it's not for nothing that sipa recommends using regtest
< as1nc> yeah i understand, but i'm bulding a service for user to accpet bitcoin via web interface providing only their extended public keys, and I really want to provide a testnet api
< wumpus> yes, I understand
< as1nc> it use to work perfectly, but now it's broken
< as1nc> if it ever gets confirmed, i'll keep you posted, but i guess testnet does not work for now :(
< as1nc> do you guys knows any testnet miners ?
< wumpus> I don't know if there are any dedicated ones at all, it looks like people just dump hashpower onto testnet once in a while, probably when they want to test
< as1nc> wumpus, did you send the coin within bitcoin core, or another wallet ?
< wumpus> bitcoin core ofc
< as1nc> ok, would you mind keeping me posted if you see that tx confirmed ?
< as1nc> i guess i can just follow on a block explorer
< wumpus> yes, please baby-sit your own tx :)
< as1nc> yeah :)
< as1nc> thx again
< alexneudatchin> sipa:it's not free stuff moron
< as1nc> anyone here working with testnet ? i dont know why my tx never get confirmed, even with huge fees. anyone noticed ?
< wumpus> as1nc: would be better to ask in #bitcoin, this channel is for bitcoin core development
< as1nc> switching to #bitcoin right now :)
< as1nc> wumpus: just to let you know i've figured out my problem, it was that the fees was to low, even thought i've put a huge fee, a guy told me the current testnet fees are 2807.8 sat/B
< wumpus> fee estimation is another non trivial thing on testnet
< wumpus> (it's not easy on mainnet either, but testnet is so unpredictable)
< as1nc> I learn everyday :) and that's great
< fanquake> wumpus If that guy (who you just banned) is going to carry on, I'm inclined to close that PR. https://github.com/bitcoin/bitcoin/pull/14090#issuecomment-417929318
< wumpus> I'm also close to doing that, a language barrier is one thing but it doesn't give license to behave like an asshole
< wumpus> the guy is just impossible to collaborate with, ignores review comments, and calls people morons... well, we don't need that drama
< wumpus> I guess if it's worthwhile someone could pick up the code and go on with it but I don't know, seems it has plenty of problems too
< fanquake> wumpus I'll make a comment to that affect, and if the response is un-constructive I'll close the PR, and open an issue with implementing that feature.
< wumpus> thanks!
< as1nc> wumpus, would you mind raising the fee of the testnet payment u sent me, it's 1 sat/b, and the current fees on testnet are really high, like at least 2800sat/b
< sipa> wumpus: well if he wants to be paid for his PR, it's not even a matter of social conventions; i don't want to be in asituatiin where we somehow owe him
< achow101> he appears to have made a death threat. I would say a ban from the github and a closing of the pr is the proper course of action
< sipa> achow101: agree, but cant do that right now
< wumpus> will do
< wumpus> FWIW I had a bad feeling about him from the beginning, but because of the language barrier I was willing to give him a chance, but you're right, this is wrong in many ways
< wumpus> anyhow ,blocked now
< wumpus> the whole idea of contributing to an open source project and expecting the maintainers to pay you is absurd
< gmaxwell> it's not like it was a particularly interesting contribution either.