< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/94cf1ec94821...5473e255f687
< bitcoin-git> bitcoin/master 0089905 practicalswift: Add compile time checking for cs_main locks which we assert at run time
< bitcoin-git> bitcoin/master 5473e25 MarcoFalke: Merge #14444: Add compile time checking for cs_main locks which we assert at run time...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14444: Add compile time checking for cs_main locks which we assert at run time (master...move-runtime-checking-to-compile-time-checking) https://github.com/bitcoin/bitcoin/pull/14444
< bitcoin-git> [bitcoin] achow101 opened pull request #14558: rpc: Require solvability in importmulti if importing more than the scriptPubKey (master...importmulti-solvability) https://github.com/bitcoin/bitcoin/pull/14558
< bitcoin-git> [bitcoin] ken2812221 opened pull request #14559: appveyor: Enable multiwallet tests (master...appveyor-test-multiwallet) https://github.com/bitcoin/bitcoin/pull/14559
< promag> ken2812221: I don't understand what you mean here https://github.com/bitcoin/bitcoin/pull/14552#issuecomment-432409103
< ken2812221> Sorry, my English is not good. I'll try to explain.
< promag> I have the same problem :P but I don't understand the lazy part
< ken2812221> @promag Can you take a look again?
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/5473e255f687...e895fdc9fc83
< bitcoin-git> bitcoin/master 1c7e25d practicalswift: wallet: Add missing locks
< bitcoin-git> bitcoin/master dee4292 practicalswift: wallet: Add Clang thread safety analysis annotations
< bitcoin-git> bitcoin/master 37b2538 practicalswift: Add GUARDED_BY(cs_wallet) for encrypted_batch, nWalletMaxVersion, m_max_keypool_index and nOrderPosNext...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #11634: wallet: Add missing cs_wallet/cs_KeyStore locks to wallet (master...missing-wallet-locks) https://github.com/bitcoin/bitcoin/pull/11634
< promag> ken2812221: ah now I understand :) ty
< promag> ken2812221: I wonder if it's still possible to abstract "wallet.dat" in db.{cpp,h}
< ken2812221> Maybe we should add add m_file in CWallet?
< ken2812221> To store the exact wallet filename. Then we can get rid of all "wallet.dat" in db.{cpp,h} hopefully.
< promag> FWIW in #14350, I was planning to add WalletLocation::GetEnvironmentPath and WalletLocation::GetDatabasePath
< gribble> https://github.com/bitcoin/bitcoin/issues/14350 | Add WalletLocation class by promag · Pull Request #14350 · bitcoin/bitcoin · GitHub
< promag> ken2812221: should we support -wallet=sub/w5 in windows?
< ken2812221> It's a valid path on Windows, but it is equal to sub\w5
< promag> so in listwallets we honor the supplied value
< wumpus> sounds like a no-brainer to have the wallet object know its own filename
< promag> wumpus: you mean the database file path?
< wumpus> even if it is only or display/UI purposes
< wumpus> yes, whatever the particular database has as a concept of database idenitifier I guess
< wumpus> I mean the user needs to be able to tell databases apart from it, that's the point
< promag> ken2812221: wumpus: BTW you could review #14531
< gribble> https://github.com/bitcoin/bitcoin/issues/14531 | Replace fs::relative call with custom GetRelativePath by promag · Pull Request #14531 · bitcoin/bitcoin · GitHub
< wumpus> yess I will thanks
< wumpus> ohh you added a unit test great
< promag> wumpus: yes let me know if it can be improved
< bitcoin-git> [bitcoin] practicalswift opened pull request #14560: wallet: Avoid calling uiInterface.LoadWallet(...) with cs_wallet held (master...uiInterface.LoadWallet-without-cs_wallet) https://github.com/bitcoin/bitcoin/pull/14560
< promag> ken2812221: I'll rebase mine on #14559 instead
< gribble> https://github.com/bitcoin/bitcoin/issues/14559 | appveyor: Enable multiwallet tests by ken2812221 · Pull Request #14559 · bitcoin/bitcoin · GitHub
< ken2812221> promag: Thank you
< promag> wumpus: sorry going to force push 14531 because of rebase
< ken2812221> promag: Better to make sure that all folders used in 14531 are exist.
< ken2812221> I mean in unit test
< promag> ken2812221: why?
< promag> shouldn't hit the filesystem?
< ken2812221> It would actually open files and compare file descriptor.
< ken2812221> It's using temp folder, so it would not hurt.
< promag> hmm
< promag> ken2812221: is it too bad to just remove the substr(0, base.size()) from the absolute path?
< promag> ken2812221: what is the best way to convert fs::path to string?
< ken2812221> promag: Does substr(0, base.size()) work on case insensitive filesystem?
< ken2812221> .string()?
< bitcoin-git> [bitcoin] promag opened pull request #14561: Remove fs::relative call and fix listwalletdir tests (master...2018-10-fix-listwalletdir) https://github.com/bitcoin/bitcoin/pull/14561
< promag> ken2812221: instead of adding a generic GetRelativePath (just because we have to support boost 1.47), and since we need the relative path in the recursive_directory_iterator loop, I've removed the walletdir there
< bitcoin-git> [bitcoin] practicalswift closed pull request #14560: wallet: Avoid calling uiInterface.LoadWallet(...) with cs_wallet held (master...uiInterface.LoadWallet-without-cs_wallet) https://github.com/bitcoin/bitcoin/pull/14560
< bitcoin-git> [bitcoin] MarcoFalke pushed 9 new commits to master: https://github.com/bitcoin/bitcoin/compare/e895fdc9fc83...9dda5fdf64ca
< bitcoin-git> bitcoin/master 67d7d67 John Newbery: [test] Fix flake8 warnings in tests...
< bitcoin-git> bitcoin/master bdefc97 John Newbery: [tests] Remove deprecated addwitnessaddress call from feature_nulldummy...
< bitcoin-git> bitcoin/master 3cf77f0 John Newbery: [tests] Remove deprecated addwitnessaddress call from wallet_dump.py...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14296: [wallet] Remove addwitnessaddress (master...remove_addwitnessaddress) https://github.com/bitcoin/bitcoin/pull/14296
< bitcoin-git> [bitcoin] karel-3d closed pull request #14502: Rpc help helper class (master...rpc_helper_class) https://github.com/bitcoin/bitcoin/pull/14502
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9dda5fdf64ca...2e15fa16cd3b
< bitcoin-git> bitcoin/master 585b47c João Barbosa: rpc: Prevent concurrent savemempool
< bitcoin-git> bitcoin/master 2e15fa1 Wladimir J. van der Laan: Merge #12842: Prevent concurrent savemempool...
< bitcoin-git> [bitcoin] laanwj closed pull request #12842: Prevent concurrent savemempool (master...2018-03-concurrent-savemempool) https://github.com/bitcoin/bitcoin/pull/12842
< wumpus> loool https://github.com/bitcoin/bitcoin/pull/14504#issuecomment-431169025 apparently a spinner makes for a "boring user experience" of the tests, happy that running the tests is so exciting now
< sipa> wumpus: development goals :)
< promag> so much excitement
< sipa> wow
< wumpus> :D
< promag> merge_queue.push(#14453)
< gribble> https://github.com/bitcoin/bitcoin/issues/14453 | rpc: Fix wallet unload during walletpassphrase timeout by promag · Pull Request #14453 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] promag closed pull request #14531: Replace fs::relative call with custom GetRelativePath (master...2018-10-getrelativepath) https://github.com/bitcoin/bitcoin/pull/14531
< bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/2e15fa16cd3b...9886590116b1
< bitcoin-git> bitcoin/master 9dcf6c0 Wladimir J. van der Laan: build: Add --disable-bip70 configure option...
< bitcoin-git> bitcoin/master 38b9850 Wladimir J. van der Laan: qt: cleanup: Move BIP70 functions together in paymentserver...
< bitcoin-git> bitcoin/master fbb643d James Hilliard: Add BIP70 deprecation warning
< bitcoin-git> [bitcoin] laanwj closed pull request #14451: Add BIP70 deprecation warning and allow building GUI without BIP70 support (master...deprecate-bip70) https://github.com/bitcoin/bitcoin/pull/14451
< fanquake> wumpus are we meant to be able to build bitcoin-qt without protobuf after #14451?
< gribble> https://github.com/bitcoin/bitcoin/issues/14451 | Add BIP70 deprecation warning and allow building GUI without BIP70 support by jameshilliard · Pull Request #14451 · bitcoin/bitcoin · GitHub
< fanquake> I'm unable to, and commented about 30s to late.. Although might be misunderstanding.
< fanquake> np, cleared up by Marco
< luke-jr> not building bitcoin-qt seems a bit extreme though; might make sense to refactor configure to just change the bip70 option
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/9886590116b1...a74ed3a05b27
< bitcoin-git> bitcoin/master 321decf João Barbosa: rpc: Fix wallet unload during walletpassphrase timeout
< bitcoin-git> bitcoin/master 8907df9 João Barbosa: qa: Ensure wallet unload during walletpassphrase timeout
< bitcoin-git> bitcoin/master a74ed3a Wladimir J. van der Laan: Merge #14453: rpc: Fix wallet unload during walletpassphrase timeout...
< promag> ken2812221: there's a bunch of `Error: Specified -walletdir "wallets" is a relative path`
< bitcoin-git> [bitcoin] laanwj closed pull request #14453: rpc: Fix wallet unload during walletpassphrase timeout (master...2018-10-unload-unlocked-wallet) https://github.com/bitcoin/bitcoin/pull/14453
< promag> thanks
< promag> wumpus: sorry, could you replace 14531 with 14561 in HP? also 14350 should not be there.
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a74ed3a05b27...6241eb3224d9
< bitcoin-git> bitcoin/master 96c509e Isidoro Ghezzi: show the progress of functional test...
< bitcoin-git> bitcoin/master 6241eb3 MarcoFalke: Merge #14504: tests: show the progress of functional tests...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14504: tests: show the progress of functional tests (master...functional_test_progress) https://github.com/bitcoin/bitcoin/pull/14504
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/6241eb3224d9...2b88f67e0bcc
< bitcoin-git> bitcoin/master 2d796fa Chun Kuan Lee: wallet: Fix duplicate fileid
< bitcoin-git> bitcoin/master 4ea7732 Chun Kuan Lee: tests: add test case for loading copied wallet twice
< bitcoin-git> bitcoin/master 2b88f67 Wladimir J. van der Laan: Merge #14320: [bugfix] wallet: Fix duplicate fileid detection...
< bitcoin-git> [bitcoin] laanwj closed pull request #14320: [bugfix] wallet: Fix duplicate fileid detection (master...2018-09-25-wallet-duplicate-fileid-fix) https://github.com/bitcoin/bitcoin/pull/14320
< bitcoin-git> [bitcoin] promag closed pull request #12929: Remove CWallet dependency from CWalletTx (master...2018-04-wallettx) https://github.com/bitcoin/bitcoin/pull/12929
< promag> wumpus: I'd like to have #13501 as soon as possible so it gets really tested by other pulls and travis/appveyor before 0.18
< gribble> https://github.com/bitcoin/bitcoin/issues/13501 | Correctly terminate HTTP server by promag · Pull Request #13501 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] promag closed pull request #13637: wallet: Add GetBalances to calculate all balances (master...2018-06-wallet-getbalance) https://github.com/bitcoin/bitcoin/pull/13637
< wumpus> promag: I'm a bit scared of that one, let me see again
< promag> wumpus: thanks
< wumpus> it's one of those things that have been 'fixed' too many times
< luke-jr> is there a reason we distribute tar.gz instead of tar.xz?
< luke-jr> is a 10 GB blockchain benchmark significant?
< luke-jr> or do I need to get real storage involved?
< gmaxwell> luke-jr: tar.xz is probably a PITA to open on windows/mac/openbsd. and who cares if the download is a couple MB bigger when the sync going to be 250GB...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2b88f67e0bcc...613fc95ee4ea
< bitcoin-git> bitcoin/master 4dca7d0 Chun Kuan Lee: appveyor: Enable multiwallet test
< bitcoin-git> bitcoin/master 613fc95 MarcoFalke: Merge #14559: appveyor: Enable multiwallet tests...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14559: appveyor: Enable multiwallet tests (master...appveyor-test-multiwallet) https://github.com/bitcoin/bitcoin/pull/14559
< luke-jr> gmaxwell: well, they're Linux binaries inside
< gmaxwell> there is also source inside.
< luke-jr> a different tarball
< luke-jr> anyway, I see 2.2% performance gain over the first 10 GB of blocks using BlueMatt's POWER8 optimisation stuff (on binaries built for POWER7)
< luke-jr> is that significant?
< * luke-jr> has no idea why -mcpu=power7 performs better than -mcpu=power9 on POWER9..
< sipa> there may be a larger benefit to larger blocks
< gmaxwell> luke-jr: the interesting question is did something break the speedup of sse4/avx over plain C.
< gmaxwell> The microbenchmark on that power8 optimized sha2 is a comparable speedup to sse4 on x86.
< bitcoin-git> [bitcoin] Neeshmacpaul opened pull request #14562: Update CONTRIBUTING.md (master...master) https://github.com/bitcoin/bitcoin/pull/14562
< BlueMatt> luke-jr: yea, I closed it cause 2.2% is wayyyy lower than it should be based on the microbenchmar
< BlueMatt> k
< BlueMatt> it may be that it doesnt actually help cause the limit is cache or something like that
< gmaxwell> s/cache/malloc/ :P
< BlueMatt> yea.....
< BlueMatt> ffs
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14562: Update CONTRIBUTING.md (master...master) https://github.com/bitcoin/bitcoin/pull/14562
< luke-jr> well, even if there's another bottleneck, it probably helps free up CPU resources for other processes?
< BlueMatt> heh could try running ibd with some other cpu-but-not-memory-intensive process running on the same core on another thread and see if you see a difference lol
< luke-jr> hmm, interesting idea.
< gmaxwell> or just profile an figure out why its not speeding things up. :P
< jnewbery> Just running test_runner and the new progress output is thrilling. Glad we didn't go for the boring spinner option.
< instagibbs> it should make some sort of progressive ascii art
< instagibbs> ubuntu flake update apparently
< instagibbs> hmm that one is giving some other error, but here's tip of 0.17 https://travis-ci.org/bitcoin/bitcoin/jobs/443960300
< michagogo> Hm. I just tried fixing https://github.com/bitcoin-core/gitian.sigs/issues/658
< michagogo> And it broke even more
< michagogo> Anyone have any idea wy?
< michagogo> why*
< bitcoin-git> [bitcoin] instagibbs opened pull request #14563: Pin flake8 version to earlier version to avoid pyflakes update (master...fix_flake) https://github.com/bitcoin/bitcoin/pull/14563
< bitcoin-git> [bitcoin] instagibbs closed pull request #14563: Pin flake8 version to earlier version to avoid pyflakes update (master...fix_flake) https://github.com/bitcoin/bitcoin/pull/14563