< dongcarl> Is there naming convention for function parameters? I'm seeing snake_case and CamelCase both
< sipa> dongcarl: developer_notes.md
< sipa> those are variables, so snake case
< dongcarl> sipa: ah okay, didn't know if there was differentiation in terms of convention for parameters vs. other variables since I saw inconsistencies
< sipa> ah, no
< sipa> parameters are just local variables in the scope of the callee
< dongcarl> right right
< dongcarl> and it would be snake case even in the case of method declarations I would assume
< sipa> right
< bitcoin-git> [bitcoin] Peppernrino opened pull request #14615: Image File Compression (master...image-file-compression) https://github.com/bitcoin/bitcoin/pull/14615
< dongcarl> Any way to have `test/lint/commit-script-check.sh` only run on one commit? Even when I specify the particular commit it seems to want to run through everything...
< bitcoin-git> [bitcoin] murrayn opened pull request #14617: FreeBSD: Document Python 3 requirement for 'gmake check' (master...freebsd-test-doc) https://github.com/bitcoin/bitcoin/pull/14617
< jolan8> ⁄﹗\ AᎢTΝ: Тhiѕ ϲhaᥒneⅼ hɑs mഠveԁ tо irc.frеenoԁе.ᥒet #/ϳഠіn /﹗\
< jolan8> Ꮤіtһ ഠur ΙRⅭ aⅾ serⅴⅰсe yо∪ ϲɑn reaⅽh ɑ ɡⅼobal audіence ഠf еntreprеnеurѕ and fеntɑᥒyl aⅾdiсtѕ ᴡіth еxtraordіnɑrỿ enɡɑgeⅿeᥒt rɑtеs! https://wiⅼlⅰampіtϲoсk.com/
< bitcoin-git> [bitcoin] practicalswift opened pull request #14618: rpc: Make HTTP RPC debug logging more informative (master...limit-rpc-request-logging) https://github.com/bitcoin/bitcoin/pull/14618
< bitcoin-git> [bitcoin] merland opened pull request #14619: tests: Fix value display name in test_runner help text (master...test-runner-fix) https://github.com/bitcoin/bitcoin/pull/14619
< wumpus> dongcarl: right, if there is confusion about that, might want to add to the developr guide that the variable convention should be used for function arguments
< wumpus> it's obvious in retrospect maybe but maaybe not to new developers
< wumpus> dongcarl: as for commit-script-check.sh, yes, afaik you can pass it a commit id on the command line?
< bitcoin-git> [bitcoin] laanwj pushed 6 new commits to master: https://github.com/bitcoin/bitcoin/compare/29f429dc7d4c...b312579c69f1
< bitcoin-git> bitcoin/master f6ed748 MeshCollider: Add SegWit support to importmulti with some ProcessImport cleanup
< bitcoin-git> bitcoin/master 353c064 MeshCollider: Fix typo in test_framework/blocktools
< bitcoin-git> bitcoin/master 1753d21 MeshCollider: Add release notes for importmulti segwit change
< bitcoin-git> [bitcoin] laanwj closed pull request #14454: Add SegWit support to importmulti (master...201810_importmulti_segwit_support) https://github.com/bitcoin/bitcoin/pull/14454
< bitcoin-git> [bitcoin] laanwj closed pull request #14615: Image File Compression (master...image-file-compression) https://github.com/bitcoin/bitcoin/pull/14615
< instagibbs> sipa, do you have a prototype importmulti-descriptor support anywhere
< instagibbs> post #14454?
< gribble> https://github.com/bitcoin/bitcoin/issues/14454 | Add SegWit support to importmulti by MeshCollider · Pull Request #14454 · bitcoin/bitcoin · GitHub
< esotericnonsense> am I correct in thinking that the CRPCCommand arrays form the complete set of POST rpc commands?
< esotericnonsense> (i'm writing a proxy for RPC, and I want to go through all of them and whitelist things I think are safe, basically)
< wumpus> esotericnonsense: yes, I'm fairly sure that is the case, even meta-commands of the RPC server such as help should be in one
< esotericnonsense> yep. I like "echo". :P
< esotericnonsense> well, I have a working rust bitcoin-cli. it's not bitcoin-cli, bitcoin-cli has all sorts of edge cases i can't be bothered to emulate because there's ~0 chance of getting a rust binary in the repo anyway.
< wumpus> indeed, it can be surprsingly useful
< esotericnonsense> not really much to it I guess but i'm hoping to have a working Thing this/next week so will put it up as part of that, then.
< wumpus> you're working on rust? why aren't you in #rust-bitcoin
< luke-jr> do we have a way to test non-HD wallet code paths at this point? :/
< sipa> i'm confused why github doesn
< sipa> i'm confused why github doesn't mark #14477 as non-mergable now, since it also adds the "solvable" field
< gribble> https://github.com/bitcoin/bitcoin/issues/14477 | Add ability to convert solvability info to descriptor by sipa · Pull Request #14477 · bitcoin/bitcoin · GitHub
< wumpus> sipa: if it makes *exactly* the same change it might be smart enough to see it as a NULL merge; not sure though
< wumpus> sometimes it's also slow with updating mergeability status
< bitcoin-git> [bitcoin] LRS95 opened pull request #14621: Fix typo italian translation (master...patch-1) https://github.com/bitcoin/bitcoin/pull/14621
< phantomcircuit> wumpus, can you take a look at #14336
< gribble> https://github.com/bitcoin/bitcoin/issues/14336 | wip: net: implement poll by pstratem · Pull Request #14336 · bitcoin/bitcoin · GitHub
< sipa> instagibbs: i'd like to get #14565 in first
< gribble> https://github.com/bitcoin/bitcoin/issues/14565 | Overhaul importmulti logic by sipa · Pull Request #14565 · bitcoin/bitcoin · GitHub
< sipa> but i need to extend the tests and address some nits first
< instagibbs> ok ping me when ready for additional review
< esotericnonsense> ooh. `waitforblockheight` is cool.
< esotericnonsense> is there a sort of 'overriding RPC timeout' anywhere or is it only limited by holding an rpc thread
< * esotericnonsense> is going to get distracted by reading this list of RPCs and get nothing done. whee
< bitcoin-git> [bitcoin] promag closed pull request #14303: rpc: Early call once CWallet::MarkDirty in import calls (master...2018-09-wallet-mark-dirty) https://github.com/bitcoin/bitcoin/pull/14303
< sipa> i just went through all PRs that were touched in the last week, and found 10 that have a (presumably) spurious AppVeyor failure, and restarted those
< instagibbs> looks like we ratcheted boost to 1.60 with boost::relative?
< instagibbs> oh nevermind, fixed a few days ago
< bitcoin-git> [bitcoin] fanquake closed pull request #14621: Fix typo italian translation (master...patch-1) https://github.com/bitcoin/bitcoin/pull/14621
< warren> sipa: regarding ... <sipa> but we have a built-in randomness pool now - it's not fast, but it's more than good enough for what we need
< warren> sipa: Is it fast enough to supply randomness for BIP150 and BIP151 when they happen later? (I'm not sure how demanding they are.)
< sipa> warren: by 'not fast' i mean it's microsecond scale, not nanosecond scale
< sipa> warren: BIP150/BIP151 just need a bit of entropy at connect time
< bitcoin-git> [bitcoin] sipa opened pull request #14624: Some simple improvements to the RNG code (master...201810_randfast) https://github.com/bitcoin/bitcoin/pull/14624
< dongcarl> wumpus: even when I provide a commit-id to `test/lint/commit-script-check.sh` on the command line, it goes thru everything... Not sure what the expected behavior is? Is this correct or no?