< HikoSeijuroXVI> gpg --recv-keys 133E AC17 9436 F14A 5CF1 B794 860F EB80 4E66 9320
< phantomcircuit> HikoSeijuroXVI, ...
< luke-jr> HikoSeijuroXVI: #bitcoin
< HikoSeijuroXVI> Hello? I have never used this before; not sure if I am using it right yet... can you read this?
< luke-jr> HikoSeijuroXVI: you're in the chat room for development discussions. type /join #bitcoin
< luke-jr> was there a recent issue or change in getbalance semantics?
< luke-jr> yeah, it seems like getbalance('*',0) is broken in master -.-
< sipa> luke-jr: how soM
< sipa> ?
< luke-jr> sipa: not sure yet, other than it returning the wrong value
< luke-jr> the same number before and after coins are received unconfirmed
< luke-jr> the internal GetBalance seems to be broken in that it doesn't pay attention to min_depth for IsSpent purposes, but I don't see how that'd be the cause :/
< luke-jr> sipa: if you want to poke at it, it's reproduced by test/functional/wallet_sweepprivkeys.py in my just-updated sweepprivkeys branch; think I'm getting too tired to keep at it tonight
< luke-jr> (changing getbalance to use GetLegacyBalance like it used to makes the test work)
< luke-jr> ah, it's the IsTrusted requirement..
< luke-jr> looks like it was fixed in 2015 with #6276 and reintroduced in accounts-removal stuff
< gribble> https://github.com/bitcoin/bitcoin/issues/6276 | Fix getbalance * 0 by dgenr8 · Pull Request #6276 · bitcoin/bitcoin · GitHub
< josephnicholas> Hi all, how do I change the bitcoin fee to 1 sat/byte?
< bitcoin-git> [bitcoin] practicalswift opened pull request #14599: Use functions guaranteed to be locale independent (IsDigit, ToLower) in {Format,Parse}Money(...), uint256::SetHex(...), etc. (master...no-more-locale) https://github.com/bitcoin/bitcoin/pull/14599
< bitcoin-git> [bitcoin] merland opened pull request #14600: docs: Add instructions about commit message when squashing (master...update-contrib) https://github.com/bitcoin/bitcoin/pull/14600
< bitcoin-git> [bitcoin] fanquake closed pull request #13561: Qt: Remove unnecessary image buffer for Mac dock icon (master...rm_icon_buffer) https://github.com/bitcoin/bitcoin/pull/13561
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f1e2f2a85962...29f429dc7d4c
< bitcoin-git> bitcoin/master d8bf107 Luke Dashjr: Bugfix: RPC: Add address_type named param for createmultisig
< bitcoin-git> bitcoin/master 29f429d MarcoFalke: Merge #14596: Bugfix: RPC: Add address_type named param for createmultisig...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14596: Bugfix: RPC: Add address_type named param for createmultisig (master...bugfix_createMS_named_addresstype) https://github.com/bitcoin/bitcoin/pull/14596
< promag> meshcollider: do you mind reviewing #14350 again?
< gribble> https://github.com/bitcoin/bitcoin/issues/14350 | Add WalletLocation class by promag · Pull Request #14350 · bitcoin/bitcoin · GitHub
< jamesob> anyone have ideas on the best way to monitor for reorgs outside of the bitcoind process? ZMQ doesn't seem to be much help because it won't notify on disconnects and polling some RPC endpoint seems hacky. worth adding a disconnectblock notification to ZMQ?
< jamesob> imo the ZMQ interface should just offer the entire ValidationInterface - any reason not to do that?
< harding> jamesob: when getting details on a new block, you can see if it references the block you thought was the previous chain tip. If it doesn't, then you know something went wrong---either a reorg or you missed a block notification.
< cfields> gitian builders: detached sigs for v0.17.0.1 are pushed
< jamesob> harding: thanks, makes sense. still might be nice to have zmq messages and -blocknotify-esque options for the complete ValidationInterface
< bitcoin-git> [bitcoin] ch4ot1c opened pull request #14601: [rpc] Descriptions: Consistent arg labels for types 'object' and 'boolean' (master...fix/rpc-arg-types) https://github.com/bitcoin/bitcoin/pull/14601
< sdaftuar> /window 5
< bitcoin-git> [bitcoin] luke-jr opened pull request #14602: Bugfix: Correctly calculate balances when min_conf is used, and for getbalance("*") (master...bugfix_rpc_getbalance_untrusted) https://github.com/bitcoin/bitcoin/pull/14602
< meshcollider> promag: sure, sometime in the next couple of days though :)
< luke-jr> MarcoFalke: think I pushed #9152 correctly for reopen
< gribble> https://github.com/bitcoin/bitcoin/issues/9152 | Wallet/RPC: sweepprivkeys method to scan UTXO set and send to local wallet by luke-jr · Pull Request #9152 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jnewbery reopened pull request #9152: Wallet/RPC: sweepprivkeys method to scan UTXO set and send to local wallet (master...sweepprivkeys) https://github.com/bitcoin/bitcoin/pull/9152
< jnewbery> lukejr: reopened. Feel free to push your rebase
< luke-jr> thx
< luke-jr> hm, I did, not sure why github isn't showing it
< jnewbery> oh, it's showing now
< luke-jr> ah, out of order for some reason
< bitcoin-git> [bitcoin] sanket1729 opened pull request #14604: [Tests] Add test and refactor feature_block.py (master...feature-block-test) https://github.com/bitcoin/bitcoin/pull/14604