< bitcoin-git>
[bitcoin] TheBlueMatt opened pull request #16174: Add a new peer state tracking class to reduce cs_main contention. (master...2019-06-net-processing-no-main-start) https://github.com/bitcoin/bitcoin/pull/16174
< meshcollider>
pierre_rochard: the card is left there, the PR itself is just removed from the card
< pierre_rochard>
Is removing the PR from the card a manual GUI step on github? or does that automatically happen on merge?
< pierre_rochard>
I tried reproducing the behavior on my own repo, all that happened was that the card reflected the PR's merged status but no archive/remove happened
< meshcollider>
pierre_rochard: a manual step
< meshcollider>
You can see I removed it from the card after laanwj merged it
< pierre_rochard>
I see, just to clarify, in github's data model, a repo has many projects (High-priority for review), a project has many columns (Blockers), a column has many cards, and a card is just a proxy to either an issue or a PR. You manually removed the PR card from the Blockers column
< pierre_rochard>
Unfortunately "Remove" is a hard delete, where as "Archive" is a soft delete. Archive was recently added and its usage enables queries like "of the merged high priority PRs, what's the average time they were high priority"
< meshcollider>
Ah yes I mixed up card with column. Yep that sounds correct
< pierre_rochard>
I would recommend trying out Archive going forward and seeing if using it has a negative secondary effect or has the same outcome (with better analytics)
< bitcoin-git>
[bitcoin] TheBlueMatt closed pull request #16174: Add a new peer state tracking class to reduce cs_main contention. (master...2019-06-net-processing-no-main-start) https://github.com/bitcoin/bitcoin/pull/16174