< kallewoof>
meshcollider achow101: would you guys mind giving #13756 a review? I would feel a lot more comfortable with it if you two had signed off on it. I think it's pretty much ready to go.
< fanquake>
kallewoof heh I just pinged them both from that PR as well. I'm sure they'll turn up.
< kallewoof>
fanquake: would be great!
< achow101>
coin selection is scary
< chandoo>
hi
< chandoo>
is it possible to dump bitcoin transactions into a csv file or .xls file or a database?
< chandoo>
how to read ledger from cmd line?
< phantomcircuit>
chandoo, #bitcoin
< meshcollider>
fanquake, kallewoof: sure, I'll take a look when I get home
< fanquake>
meshcollider: cheers
< kallewoof>
meshcollider: nice ty
< bitcoin-git>
[bitcoin] luke-jr opened pull request #16228: Bugfix: make check: Only run tests that were compiled (master...bugfix_raii_check_fail) https://github.com/bitcoin/bitcoin/pull/16228
< fanquake>
Is there a particular reason Appveyor isn't running on new PRs?
< wumpus>
fanquake:yes, drahtbot needed write access to the repo, should be fixed now
< fanquake>
wumpus I see. What does drahtbot needs write access to bitcoin/bitcoin for? I'd have thought it'd be able to use the new triage perms?
< wumpus>
it needs write access for the appveyor stuff only, the rest it could do with triage
< fanquake>
ah right, so it's an appveyor over reach issue
< fanquake>
ajtowns I suppose you are "chasing concept ACKs" for 16229 ?
< fanquake>
*aj
< aj>
yes, i guess so
< wumpus>
fanquake: I've actually created a special-exception-for-drahtbot group on the bitcoin org now :-)
< wumpus>
I hope it's enough of a reminder that it can go away if github ever solves this
< fanquake>
Sounds good
< kallewoof>
achow101: only just now saw your comment. I think #13756 is pretty okay, because all it does is remove certain coins, if the user has avoid_reuse turned on, and those coins are from addresses that were used once as inputs already. So coin selection is actually untouched, theres only a part that removes coins before coin sel.
< bitcoin-git>
bitcoin/master fa499b5 MarcoFalke: rpc: bugfix: Properly use iswitness in converttopsbt
< bitcoin-git>
bitcoin/master 22b6c4e MeshCollider: Merge #15899: rpc: Document iswitness flag and fix bug in converttopsbt
< bitcoin-git>
[bitcoin] meshcollider merged pull request #15899: rpc: Document iswitness flag and fix bug in converttopsbt (master...1904-docIsWitness) https://github.com/bitcoin/bitcoin/pull/15899
< bitcoin-git>
[bitcoin] promag opened pull request #16231: gui: Fix open wallet menu initialization order (master...2019-06-fix-open-menu) https://github.com/bitcoin/bitcoin/pull/16231
< bitcoin-git>
[bitcoin] achow101 closed pull request #16022: Don't sign when segwit signatures are being used and the pubkey(s) are uncompressed (master...dont-sign-uncomp-segwit) https://github.com/bitcoin/bitcoin/pull/16022
< kallewoof>
meshcollider: I got some nits from achow101, but I think they are not merge-stoppers, so whenever you feel like it, I think #13756 is finally good to go
< bitcoin-git>
bitcoin/master 8a26567 Luke Dashjr: torcontrol: Use the default/standard network port for Tor hidden services,...
< bitcoin-git>
bitcoin/master 6c9d3c7 Wladimir J. van der Laan: Merge #15651: torcontrol: Use the default/standard network port for Tor hi...
< promag>
I was under the impression there's somewhere a guide for reviewers, or am I dreaming?
< kallewoof>
or wumpus, if you feel comfortable doing that merge.
< kallewoof>
promag: contributor guidelines?
< achow101>
meshcollider is probably asleep
< promag>
no, for code review etc
< bitcoin-git>
[bitcoin] laanwj merged pull request #15651: torcontrol: Use the default/standard network port for Tor hidden services, even if the internal port is set differently (master...tor_standard_port) https://github.com/bitcoin/bitcoin/pull/15651
< kallewoof>
promag: CONTRIBUTING.md has a section on how to review, but not sure there is anything beyond that
< promag>
kallewoof: thanks
< promag>
not the right place to add technicals suggestions though
< bitcoin-git>
bitcoin/master 0959d37 practicalswift: Don't use global (external) symbols for symbols that are used in only one ...
< bitcoin-git>
bitcoin/master 0b68fca MarcoFalke: Merge #16092: Don't use global (external) symbols for symbols that are use...
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #16092: Don't use global (external) symbols for symbols that are used in only one translation unit (master...reduce-global-namespacing) https://github.com/bitcoin/bitcoin/pull/16092
< bitcoin-git>
[bitcoin] sipsorcery opened pull request #16235: Cleaned up and consolidated msbuild files (no code changes) (master...vs2019) https://github.com/bitcoin/bitcoin/pull/16235
< promag>
could ditch ismine.h and move/merge the contents into wallet.h?
< promag>
circular dependency would go away
< achow101>
promag: wallet.h/cpp is already massive. we're trying to break things out of it
< achow101>
the circular dependency is going away soon anyways
< promag>
achow101: I meant only .h
< promag>
anyway, just saying, looks ok to me
< achow101>
meh, I have no strong feelings about it
< sipa>
agree
< bitcoin-git>
[bitcoin] achow101 opened pull request #16237: Have the wallet give out addresses instead of keys (master...cwallet-getnewaddr) https://github.com/bitcoin/bitcoin/pull/16237
< bitcoin-git>
[bitcoin] practicalswift opened pull request #16238: build: Reduce accumulated max memory usage (RSS) during build by 1% (-800 MB) by not including unused C++ standard library headers (master...c++-standard-library-headers) https://github.com/bitcoin/bitcoin/pull/16238
< bitcoin-git>
[bitcoin] meshcollider merged pull request #13756: wallet: "avoid_reuse" wallet flag for improved privacy (master...feature-avoidreuse) https://github.com/bitcoin/bitcoin/pull/13756
< meshcollider>
#16026 is quite a simple change + bugfix so I've added it to the bugfix list, it only needs a little more review
< gribble>
https://github.com/bitcoin/bitcoin/issues/16026 | Ensure that uncompressed public keys in a multisig always returns a legacy address by achow101 · Pull Request #16026 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] meshcollider closed pull request #16012: rpc: addmultisigaddress should fallback to OutputType::LEGACY when uncompressed public keys are provided (master...master) https://github.com/bitcoin/bitcoin/pull/16012