For #13989, I'm wondering what the policy is for adding intrinsics like this. According to jamesob's benchmarks here https://github.com/bitcoin/bitcoin/pull/13989#issuecomment-497381424. I see that: 1. The PR significantly improves SHA-intensive microbenchmarks: `micro.gcc.MerkleRoot` and `micro.gcc.SHA256D64_1024`. 2. It does not speed up IBD performance significantly.
they can certainly be deprecated if there are alternatives, but i suspect here that the expected workflow will be that once you upgrade to a Shiny Descriptor Wallet certain RPCs stop being available, but remain supported on legacy wallets
achow101: oh nice, lots of commits :D
i'm going to reorganize them after I get the thing to actually work
achow101: why do you need [ci skip], does CI run on every commit? I thought it only ran on the tip.
jb55: it's just to note that those commits won't compile/won't pass tests
the order is kind of screwed up right now
all the [ci skip] commits should be at the end
eh, why wouldn't they compile at least?
cause I fucked up. they'll compile later when I reorganize everything