07:19 < bitcoin-git> [bitcoin] gertjaap opened pull request #16192: Catches situations where capping on maxtxfee drops the fee too low (master...issue-10122) https://github.com/bitcoin/bitcoin/pull/16192

13:13 < instagibbs> is it really true there are no tests for wallet upgrades :(

13:14 < instagibbs> #16193

13:14 < gribble> https://github.com/bitcoin/bitcoin/issues/16193 | `-upgradewallet` from pre-HD Split not working · Issue #16193 · bitcoin/bitcoin · GitHub

14:01 < bitcoin-git> [bitcoin] TheBlueMatt closed pull request #16171: Remove -mempoolreplacement to prevent needless block prop slowness. (master...2019-06-fix-tx-prop) https://github.com/bitcoin/bitcoin/pull/16171

14:48 < bitcoin-git> [bitcoin] jamesob opened pull request #16194: refactor: share blockmetadata with BlockManager (master...2019-06-au-blockman) https://github.com/bitcoin/bitcoin/pull/16194

15:11 < jonasschnelli> sipa: about the CNetMessage serialization split: what do you think about using a CNetBuffer for keeping the buffer & hash state, and once complete, we convert it into a CNetMessage (pure command / payload)?

15:20 < jnewbery> instagibbs: it really is true as far as I'm aware :(

15:32 < ryanofsky> instagibbs, #12134 adds a nice framework for writing upgrade tests, and i'd like it merged but others think it would complicate testing framework to support old rpc versions, and would prefer to check in binary wallet blobs

15:32 < gribble> https://github.com/bitcoin/bitcoin/issues/12134 | Build previous releases and run functional tests by Sjors · Pull Request #12134 · bitcoin/bitcoin · GitHub

15:33 < instagibbs> looking

15:46 < bitcoin-git> [bitcoin] jkczyz opened pull request #16195: util: Use void* throughout support/lockedpool.h (master...2019-06-arena-key) https://github.com/bitcoin/bitcoin/pull/16195

16:08 < promag> why travis didn't pick #16192?

16:08 < gribble> https://github.com/bitcoin/bitcoin/issues/16192 | Wallet: Catches situations where capping on maxtxfee drops the fee too low by gertjaap · Pull Request #16192 · bitcoin/bitcoin · GitHub

16:36 < bitcoin-git> [bitcoin] MarcoFalke reopened pull request #16171: Remove -mempoolreplacement to prevent needless block prop slowness. (master...2019-06-fix-tx-prop) https://github.com/bitcoin/bitcoin/pull/16171

16:36 < bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/473c6b7c5ab0...f792395d13aa

16:36 < bitcoin-git> bitcoin/master 218697b Suhas Daftuar: Improve NOTFOUND comment

16:36 < bitcoin-git> bitcoin/master 23163b7 Suhas Daftuar: Add an explicit memory bound to m_tx_process_time

16:36 < bitcoin-git> bitcoin/master e32e084 Suhas Daftuar: Remove NOTFOUND transactions from in-flight data structures

16:37 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15834: Fix transaction relay bugs introduced in #14897 and expire transactions from peer in-flight map (master...2019-04-fix-getdata) https://github.com/bitcoin/bitcoin/pull/15834

16:49 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #16196: doc: Add release notes for 14897 & 15834 (master...1906-docRel) https://github.com/bitcoin/bitcoin/pull/16196

16:54 < bitcoin-git> [bitcoin] sdaftuar reopened pull request #15505: [p2p] Request NOTFOUND transactions immediately from other outbound peers, when possible (master...2019-02-notfound-requests) https://github.com/bitcoin/bitcoin/pull/15505

21:09 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #16197: net: Use mockable time for tx download (master...1906-netMock) https://github.com/bitcoin/bitcoin/pull/16197

22:03 < darosior> Hi, with functional tests why do I need to generate >100 blocks to have my wallet knowing about the funds ? `self.nodes[0].generate(1)` then `self.nodes[0].sendtoaddress(` fails while `self.nodes[0].generate(101)` then `self.nodes[0].sendtoaddress(` passes ? Is this a good usage or should I do something else ? Reading other functional tests some seems to use the 101 trick but others don't

22:04 < sipa> darosior: maturity rule

22:04 < darosior> Thank you

22:04 < sipa> coinbase outputs are unspendable until buried 100 blocks deep

22:04 < sipa> so the wallet treats them as balance only when those blocks exist

22:05 < darosior> Yes did not think to that, thank you for the quick answer !

22:38 < jb55> oh nice scantxoutset is decently fast, gave it 100k p2pk descriptors and it finished in around 30 seconds.

22:44 < promag> jb55 yeah wallet batch pr from achow101 improved that

22:45 < jb55> promag: I thought that slowness was due to saving keys to disk

22:46 < sipa> promag: scantxoutset is completely unrelated to the wallet

22:46 < sipa> i think you're talking about importmulti

22:46 < promag> sipa: oh my bad

22:47 < promag> right it was #15741

22:47 < gribble> https://github.com/bitcoin/bitcoin/issues/15741 | Batch write imported stuff in importmulti by achow101 · Pull Request #15741 · bitcoin/bitcoin · GitHub

22:48 < jb55> I scanned all unspent p2pk outputs in the first 100k blocks, 1692540 btc still in those