< kallewoof>
Sorry for the refactoring PR. I honestly think it is worth it, with the # of lines saved (623 lines -> 284, with current codebase), and less copy-pasting.
< fanquake>
kallewoof don't apologise. Looks like a good cleanup / deduplication.
< wumpus>
not all refactors are equally bad !
< bitcoin-git>
[bitcoin] fanquake opened pull request #16241: docs: add rapidcheck to vcpkg install list (master...windows_build_msvc) https://github.com/bitcoin/bitcoin/pull/16241
< bitcoin-git>
[bitcoin] kallewoof closed pull request #12096: [rpc] [wallet] Allow specifying the output index when using bumpfee (master...better-bumpfee) https://github.com/bitcoin/bitcoin/pull/12096
< kallewoof>
Is there a way to do a scripted diff that shows you only did whitespace changes? I assume no, since it would have to know the correct indentation(s) but sipa seems to indicate it's doable. (Or I misunderstood him)
< sipa>
kallewoof: i don't see why not?
< sipa>
you can write any script you want to perform the changes
< sipa>
including a small python script or so, though awk/sed are probably more compact
< sipa>
promag showed a much better way
< promag>
not sure if travis has the required tools
< sipa>
promag: also... clang splitting the {} and the .check part is weird
< sipa>
*clang-format
< promag>
it must be some rule (or lack of) in src/.clang-format?
< sipa>
yeah
< sipa>
a nonsensical one for sure
< sipa>
can you avoid it by putting a () around the {} or so (not sure that's actually still correct c++)
< meshcollider>
review beg #16026
< gribble>
https://github.com/bitcoin/bitcoin/issues/16026 | Ensure that uncompressed public keys in a multisig always returns a legacy address by achow101 · Pull Request #16026 · bitcoin/bitcoin · GitHub
< fanquake>
Chris_Stewart_5: Hey mate. From what I could tell all the tests passed. I couldn’t even compile without rapidcheck. Can confirm tomorrow if required.
< kallewoof>
sipa promag: I tried promag's example, but it's choking on b/src/rpc/blockchain.cpp not found for some reason, at least when I run from cli. linter also throws..
< bitcoin-git>
[bitcoin] achow101 opened pull request #16244: Move wallet creation out of the createwallet rpc into its own function (master...mv-createwallet) https://github.com/bitcoin/bitcoin/pull/16244
< achow101>
promag: would it be possible to split #16215 into two commits, one refactoring open wallet, the other for create wallet? I would like to pull in the create wallet part into #15450 so that it's async there. It would also make #16215 be able to stand on its own with just an open wallet refactor