< phantomcircuit> provoostenator, seems like something where building the entire system with the masm would be necessary
< wumpus> seems today it's travis' turn to fail on every PR for no good reason
< wumpus> #17626
< gribble> https://github.com/bitcoin/bitcoin/issues/17626 | Travis apt download for trusty is failing with 401 . Issue #17626 . bitcoin/bitcoin . GitHub
< bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/d8a66626d631...1f59885d27a0
< bitcoin-git> bitcoin/master 14aded4 Hennadii Stepanov: script: Lint Gitian descriptors with ShellCheck
< bitcoin-git> bitcoin/master 577682d Hennadii Stepanov: script: Enable SC2006 rule for Gitian scripts
< bitcoin-git> bitcoin/master 61bb21b Hennadii Stepanov: script: Enable SC2155 rule for Gitian scripts
< bitcoin-git> [bitcoin] laanwj merged pull request #17361: script: Lint Gitian descriptors with ShellCheck (master...20191103-lint-gitian-scripts) https://github.com/bitcoin/bitcoin/pull/17361
< provoostenator> Ouch, bitcoincore.org SSL expired: https://github.com/bitcoin-core/bitcoincore.org/issues/690
< provoostenator> Maybe a broken Certbot cron job? (
< wumpus> it doesn't use certbot, it's being done manual
< wumpus> but it's clear that it was forgotten
< bitcoin-git> [bitcoin] Sjors opened pull request #17627: Initialize entropy buffers to suppress false positive warning (master...2019/11/buffers) https://github.com/bitcoin/bitcoin/pull/17627
< wumpus> can't we just like, stop using C++...
< elichai2> wumpus: yes we can :P
< wumpus> I was kidding but yea
< elichai2> me too heh, like no matter what I don't see consensus ever going to a different code
< elichai2> even if C++ dies
< wumpus> man, all these tools that generate lots of false positives an *sometimes* find a real issue
< wumpus> and when they do it's really serious so it has to be worth it to put up with it all
< provoostenator> They found 2 recently, one almost shiped, and the other on master
< wumpus> it's awful
< wumpus> I don't want C++ to die, I just never want to touch it anymore...
< elichai2> wumpus: well even in rust you need to first initialize the buffers to 0
< provoostenator> elichai2: it's too early for drinking games when someone brings up Rust
< elichai2> lol
< wumpus> elichai2: but at least the compiler refuses to compile if you don't
< wumpus> but this needs to be set up in a specific way, need you to recompile the stdc++ standard library, etc
< wumpus> does anyone here perhaps have a clue about windows utf-8 handling https://github.com/google/leveldb/issues/755
< wumpus> I'd really hate having to patch leveldb for this so please tell me this is okay and I just have to add a set_codepage(UTF8) somewhere
< wumpus> note that we already *have* SetConsoleCP(CP_UTF8); and SetConsoleOutputCP(CP_UTF8); on windows, but this does not affect filenames (only console output)
< sipsorcery> wumpus: I'm taking a look at the test failures on the leveldb PR.
< sipsorcery> would you expect the dbwrapper unit tests to fail in test_bitcoin if it was a leveldb unicode problem?
< wumpus> sipsorcery: I don't know, do the dbwrapper tests exercise things such as UTF-8 emoji in filenames?
< sipsorcery> I'm not sure either, seems to be some random file name generation going on but can't see any emojis.
< wumpus> is it possible at all for the *A windows filename functions to handle utf-8? if so, how to make windows do that?
< wumpus> all workarounds I see online use conversion to wstring then *W functions
< wumpus> this was also what we did in the old windows leveldb env
< wumpus> because of that I think the new leveldb windows env can only handle filenames in the configured codepage, which depends on language etc
< sipsorcery> i don't claim to be an expert but my understanding is that given the A in *A stands for ASCII those calls can't deal with unicode paths.
< wumpus> right
< wumpus> I could find https://docs.microsoft.com/en-us/windows/uwp/design/globalizing/use-utf8-code-page but that speaks of "As of Windows Version 1903 (May 2019 Update)"
< wumpus> which is not useful unless we want to drop support for everything except windows 10 :)
< sipsorcery> actually could be the 'A' stands for 'ANSI' and as you allude to means the *A calls can deal with ANSI defined code pages
< sipsorcery> but the python functional tests are failing for me in a cmd window with current code page set to 65001 (UTF-8)
< wumpus> oh, maybe that needs some other change too
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1f59885d27a0...23cecd6cd56f
< bitcoin-git> bitcoin/master d2a3a5c fanquake: util: make ScheduleBatchPriority advisory only
< bitcoin-git> bitcoin/master 23cecd6 Wladimir J. van der Laan: Merge #17604: util: make ScheduleBatchPriority advisory only
< bitcoin-git> [bitcoin] laanwj merged pull request #17604: util: make ScheduleBatchPriority advisory only (master...fix_ScheduleBatchPriority_comment) https://github.com/bitcoin/bitcoin/pull/17604
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/23cecd6cd56f...114e89e596a6
< bitcoin-git> bitcoin/master 73b96c9 practicalswift: net: Fix uninitialized read in ProcessMessage(...)
< bitcoin-git> bitcoin/master 114e89e Wladimir J. van der Laan: Merge #17624: net: Fix an uninitialized read in ProcessMessage(..., "tx", ...)...
< bitcoin-git> [bitcoin] laanwj merged pull request #17624: net: Fix an uninitialized read in ProcessMessage(..., "tx", ...) when receiving a transaction we already have (master...uninitialized-read-in-ProcessMessage) https://github.com/bitcoin/bitcoin/pull/17624
< elichai2> Found an endianness bug :)
< elichai2> `AssertionError: not(1711276032 == 102)`
< elichai2> now the question is, is that bug in python or C++
< sipa> elichai2: the one fixed in #17599 ?
< gribble> https://github.com/bitcoin/bitcoin/issues/17599 | ci: Run functional tests on s390x by MarcoFalke . Pull Request #17599 . bitcoin/bitcoin . GitHub
< elichai2> lol I guess so
< elichai2> MarcoFalke: two days I'm not working on it and you already do that :P
< elichai2> but mine also include depends (kinda)
< Livestradamus> bitcoincore.org down?
< fanquake> Livestradamus the cert has expired.
< Livestradamus> thanks fanquake,
< provoostenator> This outage breaks a bunch of deploy scripts out there, e.g. https://github.com/btcpayserver/dockerfile-deps/blob/master/Bitcoin/0.17.0/linuxamd64.Dockerfile#L8
< provoostenator> Arguably relying on the site to be up is not a good idea.
< provoostenator> It's back
< hebasto> \o/
< jonatack_> yay
< emilengler> hi
< meshcollider> Meeting?
< wumpus> #startmeeting
< lightningbot> Meeting started Thu Nov 28 19:01:27 2019 UTC. The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
< lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
< provoostenator> hi
< emilengler> hi again
< meshcollider> Or not because of thanksgiving
< provoostenator> good point
< wumpus> yea...
< jonatack_> hi
< amiti> hi
< wumpus> no proposed topics this week anyway, if people prefer not to do a meeting on thanksgiving I'll close it again
< wumpus> #endmeeting
< lightningbot> Meeting ended Thu Nov 28 19:03:33 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
< meshcollider> I want to talk about #15729 but we can do that next week
< gribble> https://github.com/bitcoin/bitcoin/issues/15729 | rpc: Raise error in getbalance if minconf is not zero by promag . Pull Request #15729 . bitcoin/bitcoin . GitHub
< kanzure> hi
< elichai2> kanzure: missed the metting already :) :P
< elichai2> *meeting
< emilengler> elichai2: You haven't missed anything
< emilengler> It was 2 minutes long, and there were very few people there because of thanksgiving
< elichai2> emilengler: I know, I was joking to kanzure because he wrote hi now. I guess it wasn't very funny lol
< fanquake> hi