01:03 < gleb> Oh forgot about the meeting. I was wondering if we can add #16702 to high-prio. If we want to make it to the next release better start early, the change is not big but require reviewers looking into addrman so..

01:03 < gribble> https://github.com/bitcoin/bitcoin/issues/16702 | p2p: supplying and using asmap to improve IP bucketing in addrman by naumenkogs . Pull Request #16702 . bitcoin/bitcoin . GitHub

01:04 < gleb> As a general question, is it better to ask for things like this during the meeting? Since there is a special high prio slot in the meeting.

01:28 < fanquake> gleb: yea sounds like you should bring it up next meeting. Propose a topic with the # so it isn't forgotten.

01:41 < bitcoin-git> [bitcoin] wooseopkim opened pull request #17630: Align assignment operator vertically (master...patch-1) https://github.com/bitcoin/bitcoin/pull/17630

01:53 < bitcoin-git> [bitcoin] fanquake closed pull request #17630: Align assignment operator vertically (master...patch-1) https://github.com/bitcoin/bitcoin/pull/17630

04:45 < bitcoin-git> [bitcoin] TheBlueMatt opened pull request #17631: Expose block filters over REST. (master...2019-11-filter-rest) https://github.com/bitcoin/bitcoin/pull/17631

08:05 < provoostenator> Looks like Travis Trusty builds are working again.

08:07 < provoostenator> I'm restarting a bunch of them for recent commits.

08:11 < wumpus> can you show me any succesful one? then I'll close the issue

08:16 < wumpus> apparently versions are cropped (and 0.19.0.1 shows as 0.19.0) on macos #14701

08:16 < gribble> https://github.com/bitcoin/bitcoin/issues/14701 | build: Add CLIENT_VERSION_BUILD to CFBundleGetInfoString by fanquake . Pull Request #14701 . bitcoin/bitcoin . GitHub

08:23 < wumpus> bahh I reallly don't feel like doing windows programming, don't even have any real windows machines to test on anymore

08:47 < provoostenator> wumpus: the top of the PR list, and some new commits on master, are green.

10:16 < bitcoin-git> [bitcoin] meshcollider pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/114e89e596a6...abb30de63f36

10:16 < bitcoin-git> bitcoin/master 2689c8f Sjors Provoost: [test] qt: add send screen balance test

10:16 < bitcoin-git> bitcoin/master 4a96e45 Sjors Provoost: [gui] send: show watch-only balance in send screen

10:16 < bitcoin-git> bitcoin/master abb30de Samuel Dobson: Merge #17587: gui: show watch-only balance in send screen

10:17 < bitcoin-git> [bitcoin] meshcollider merged pull request #17587: gui: show watch-only balance in send screen (master...2019/11/send_balance) https://github.com/bitcoin/bitcoin/pull/17587

10:29 < fanquake> wumpus I saw that earlier and double-checked, I couldn't find any version numbers that were cropped in the macOS release binaries

11:08 < Sentineo> FYI the verify-commits script was failing for me again. And doing a pull of keys as stated in the readme did not resolve it sadly. Anybody having the same issue? Had trouble getting this key: 262685BC78ED11FB

11:09 < Sentineo> was on 23cecd6cd56f952c757f469c46d7593c2ffaa419 when running it

11:59 < wumpus> there is no maintainer key 262685BC78ED11FB, where did you see it used?

12:00 < wumpus> merge commit 23cecd6cd56f952c757f469c46d7593c2ffaa419 is signed by my key

12:45 < Sentineo> wumpus: I wend to github and checked the key of the commit signed, that is where it said so

12:45 < Sentineo> *went

12:47 < Sentineo> I should be able to reproduce that by going back with git reflog to the state the repo was before. I lost patience and just did a git pull

13:07 < wumpus> and "git pull" did a fast forward, I suppose? in that case, there's probably nothing fishy going on there

13:29 < Sentineo> wumpus: yes it did

16:13 < bitcoin-git> [bitcoin] practicalswift opened pull request #17633: tests: Add option --valgrind to run the functional tests under Valgrind (master...functional-valgrind) https://github.com/bitcoin/bitcoin/pull/17633

16:15 < fanquake> note

19:37 < bitcoin-git> [bitcoin] hebasto opened pull request #17634: qt: Fix comparison function signature (master...20191129-fix-comp) https://github.com/bitcoin/bitcoin/pull/17634

21:39 < bitcoin-git> [bitcoin] hebasto opened pull request #17635: build: Add Travis CentOS 7 build (master...20191129-travis-centos-build) https://github.com/bitcoin/bitcoin/pull/17635