02:06 < gwillen> where does appveyor/msbuild get dependency/link information from?

02:06 < gwillen> Does it use something other than the Makefiles?

02:06 < gwillen> (if I'm seeing a link error that _only_ happens on appveyor, not Travis, what does that mean?)

02:07 < gwillen> (https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/30501687)

02:11 < sipa> gwillen: i have no idea

02:13 < gwillen> there is a build_msvc/msvc-autogen.py script that appears to scrape them from the Makefiles and make visual studio projects

02:14 < gwillen> it looks like this may be a bug in that script, possibly it was not updated when something got refactored in how the build was done

02:15 < gwillen> curiously, it looks like the generated vcxproj files are BOTH checked-in AND .gitignored, which is not a usual configuration

02:16 < gwillen> so the script failing to regenerate one of them means that the stale one is used

02:20 < fanquake> gwillen There's some discussion in #17287, if you want to "fix" that somehow feel free.

02:20 < gribble> https://github.com/bitcoin/bitcoin/issues/17287 | Git ignore policy in build_msvc directory . Issue #17287 . bitcoin/bitcoin . GitHub

02:22 < bitcoin-git> [bitcoin] sipa opened pull request #18086: Accurately account for mempool index memory (master...201910_accounting_allocator) https://github.com/bitcoin/bitcoin/pull/18086

02:57 < gwillen> fanquake: aha, thanks, I probably don't want to touch it at all :D but it's helpful to have context about it

02:57 < gwillen> it looks like the right thing for me to do is just update the bitcoin-qt windows dependencies in the checked-in msvc project file by hand, it looks like actually the script does not know how to rebuild that one anyway

04:05 < bitcoin-git> [bitcoin] sipa opened pull request #18087: Get rid of VARINT default argument (master...202002_novarintvarmacro) https://github.com/bitcoin/bitcoin/pull/18087

04:39 < bitcoin-git> [bitcoin] fanquake opened pull request #18088: build: ensure we aren't using GNU extensions (master...no_gnu_extensions) https://github.com/bitcoin/bitcoin/pull/18088

05:28 < bitcoin-git> [bitcoin] thorie7912 opened pull request #18089: Merge pull request #1 from bitcoin/master (master...master) https://github.com/bitcoin/bitcoin/pull/18089

05:29 < bitcoin-git> [bitcoin] thorie7912 closed pull request #18089: Merge pull request #1 from bitcoin/master (master...master) https://github.com/bitcoin/bitcoin/pull/18089

08:44 < bitcoin-git> [bitcoin] jonasschnelli opened pull request #18091: Qt: pass clientmodel changes from walletframe to walletviews (master...2020/02/missing_clientmodel) https://github.com/bitcoin/bitcoin/pull/18091

17:20 < bitcoin-git> [bitcoin] moniquejank opened pull request #18093: Controlling und die Scheidung ist eine Empfangsbestatigung fur die PO... (master...patch-1) https://github.com/bitcoin/bitcoin/pull/18093

17:24 < bitcoin-git> [bitcoin] thorie7912 opened pull request #18094: Split blocks into multiple dirs (master...split_blocks_into_multiple_dirs) https://github.com/bitcoin/bitcoin/pull/18094

17:35 < emilengler> Can someone close #18093? It is a junk PR

17:35 < gribble> https://github.com/bitcoin/bitcoin/issues/18093 | Controlling und die Scheidung ist eine Empfangsbestatigung fur die PO... by moniquejank . Pull Request #18093 . bitcoin/bitcoin . GitHub

17:37 < bitcoin-git> [bitcoin] sipa closed pull request #18093: Controlling und die Scheidung ist eine Empfangsbestatigung fur die PO... (master...patch-1) https://github.com/bitcoin/bitcoin/pull/18093

17:44 < hebasto> jonasschnelli: mind looking in #18051 ?

17:44 < gribble> https://github.com/bitcoin/bitcoin/issues/18051 | build: Fix behavior when ALLOW_HOST_PACKAGES unset by hebasto . Pull Request #18051 . bitcoin/bitcoin . GitHub

20:52 < bitcoin-git> [bitcoin] uhliksk opened pull request #18095: Fix crashes and infinite loop in ListWalletDir() (master...master) https://github.com/bitcoin/bitcoin/pull/18095

20:54 < bitcoin-git> [bitcoin] nothingmuch opened pull request #18096: doc: IsFinalTx comment about nSequence & OP_CLTV (master...nLockTime-comment) https://github.com/bitcoin/bitcoin/pull/18096

23:05 < jeremyrubin> I accidentally pushed a checktemplateverify branch to bitcoin/bitcoin if someone wants to delete it

23:08 < jeremyrubin> trying to get CTV and Taproot onto a common root commit has kinda made my life hell

23:08 < jeremyrubin> My git-fu isn't that strong, but Taproot seems almost *impossible* to work with in git for rebase workflows

23:14 < jeremyrubin> it's not super clear to me what branch Taproot was actually based on? Was master ever in the state of taproot~19?

23:14 < jeremyrubin> sipa: ^^^

23:25 < jeremyrubin> from taproot~19 I can't even pull in master without merge conflict

23:25 < jeremyrubin> because of build_msvc/bitcoin_config.h