< kallewoof> gwillen: weird!
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6d0e532ae029...365c83e6a839
< bitcoin-git> bitcoin/master 9a299a5 Jon Atack: net: reference instead of copy in BlockConnected range loop
< bitcoin-git> bitcoin/master 365c83e fanquake: Merge #18054: net: reference instead of copy in BlockConnected range loop
< bitcoin-git> [bitcoin] fanquake merged pull request #18054: net: reference instead of copy in BlockConnected range loop (master...block-connected-ref-instead-of-copy) https://github.com/bitcoin/bitcoin/pull/18054
< bitcoin-git> [bitcoin] fanquake closed pull request #17958: rpc: query general daemon information via RPC (master...rpc-implement-getgeneralinfo) https://github.com/bitcoin/bitcoin/pull/17958
< bitcoin-git> [bitcoin] fanquake opened pull request #18059: build: add missing attributes to Win installer (master...win_installer_attributes) https://github.com/bitcoin/bitcoin/pull/18059
< bitcoin-git> [bitcoin] fanquake closed pull request #16233: WIP: add basic semaphore2 CI (master...master) https://github.com/bitcoin/bitcoin/pull/16233
< gwillen> kallewoof: not that weird, Apple hates backwards compatibility almost as much as Microsoft loves it
< wumpus> same for apple users
< wumpus> (fortunately, because it's more or less impossible to support old apple stuff sanely)
< kallewoof> when I was doing ios stuff, as long as you picked the older SDK things tended to just work most of the time (not always tho).
< wumpus> it's definitely possible, just a lot of work navigating the maze of deprecations and API churn
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/365c83e6a839...b2df21b32ca9
< bitcoin-git> bitcoin/master 2ccb7cc Jeremy Rubin: Add Epoch Guards to CTXMemPoolEntry and CTxMemPool
< bitcoin-git> bitcoin/master bd5a026 Jeremy Rubin: Make UpdateTransactionsFromBlock use Epochs
< bitcoin-git> bitcoin/master b2df21b Wladimir J. van der Laan: Merge #17925: Improve UpdateTransactionsFromBlock with Epochs
< bitcoin-git> [bitcoin] laanwj merged pull request #17925: Improve UpdateTransactionsFromBlock with Epochs (master...epoch-mempool-clean-split) https://github.com/bitcoin/bitcoin/pull/17925
< aj> oh no, i got @'ed in 17925's merge
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b2df21b32ca9...651e34388832
< bitcoin-git> bitcoin/master 0a50019 Matt Corallo: Walk pindexBestHeader back to ChainActive().Tip() if it is invalid
< bitcoin-git> bitcoin/master 651e343 Wladimir J. van der Laan: Merge #16974: Walk pindexBestHeader back to ChainActive().Tip() if it is i...
< bitcoin-git> [bitcoin] laanwj merged pull request #16974: Walk pindexBestHeader back to ChainActive().Tip() if it is invalid (master...2019-09-better-header-knowledge) https://github.com/bitcoin/bitcoin/pull/16974
< fanquake> aj: ugh. Along with a bunch of others in the ajonas comment
< jonatack> perhaps the merge script should discount "acks" as opposed to "ack"
< wumpus> ugh
< wumpus> btw is #16392 ready now?
< gribble> https://github.com/bitcoin/bitcoin/issues/16392 | build: macOS toolchain update by fanquake . Pull Request #16392 . bitcoin/bitcoin . GitHub
< wumpus> looks like the travis passed so it's getting the SDK from the right place?
< fanquake> wumpus I haven't pushed yet. Can do in a minute
< wumpus> oh
< fanquake> Did you restart travis?
< wumpus> travis was running on it a few minutes ago
< wumpus> I didn't!
< fanquake> heh neither
< wumpus> fanquake: jonatack: looks like the merge script doesn't warn about @ in ACK comments as it does in the PR description
< fanquake> Yea, that wasn't even an actual ACK either. Just a comment mentioning who had and hadn't.
< fanquake> Guess I can rebase #17800 on top of that now as well
< gribble> https://github.com/bitcoin/bitcoin/issues/17800 | random: dont special case clock usage on macOS by fanquake . Pull Request #17800 . bitcoin/bitcoin . GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16392 | build: macOS toolchain update by fanquake . Pull Request #16392 . bitcoin/bitcoin . GitHub
< wumpus> fanquake: oh it misdetected it, oops
< fanquake> I see "--sysroot /home/travis/build/bitcoin/bitcoin/depends/SDKs/MacOSX10.14.sdk object... (cached) ok" in the logs.
< fanquake> but I'd like to push again anyways.
< wumpus> ok
< jonatack> wumpus: right, looking at it rn
< wumpus> jonatack: thank you!
< fanquake> wumpus: there's been some activity in binutils in regards to PE binaries and ASLR (#8248): https://sourceware.org/bugzilla/show_bug.cgi?id=19011#c9
< gribble> https://github.com/bitcoin/bitcoin/issues/8248 | ASLR seems not to be working as it should on Windows . Issue #8248 . bitcoin/bitcoin . GitHub
< fanquake> They've added a --enable-reloc-section flag, which we'll eventually get as part of --dynamicbase and/or --high-entropy-va
< elichai2> Do we save rejected(prev-blk-not-found) orphan blocks so we have them in case the parent appears? or do we discard them?
< elichai2> (looking at BlockManager::AcceptBlockHeader it seems like they're not saved)
< wumpus> no, rejected blocks are never saved, we never request blocks with unknown parent, also this would be a trivial DoS
< wumpus> fanquake: good to know mingw-w64 is making progress on that at least!
< elichai2> wumpus: hmm makes sense. forgot for a sec about the headers first :)
< jonatack> wumpus: simple proposal to warn if @ in ACK messages https://github.com/bitcoin-core/bitcoin-maintainer-tools/pull/51/
< elichai2> Looking for things to work on :) any suggestions are wellcome
< emilengler> elichai2: Check out good first issues
< emilengler> Or in general any issue :P
< emilengler> Also reviewing PRs is never wrong also because the PR stack is growing and growing
< elichai2> emilengler: I try to review all the PRs I feel like I have enough knowledge to review. but that's the thing, writing code is a great way to gain knowledge in new parts of the code (which I find harder by "just" reviewing - easier to miss things that you couldn't by writing code (ie tests would fail)). i'll go through the open issues again
< promag> elichai2: I find reviewing better to learn - checkout branch/commit-by-commit, build, run, etc
< emilengler> I agree with promag, looking up definitons, etc. gives you better understanding of the src
< emilengler> Also playing a bit around and modifying the patch to better see what it does is a good approach, at least for me.
< bitcoin-git> [bitcoin] promag opened pull request #18060: gui: Drop PeerTableModel dependency to ClientModel (master...2020-02-peertablemodel) https://github.com/bitcoin/bitcoin/pull/18060
< elichai2> well sadly people are different and I learn best by writing :/
< jonatack> elichai2: some ideas: improve the asmap unit tests, see jamesob review comments in #16702
< gribble> https://github.com/bitcoin/bitcoin/issues/16702 | p2p: supplying and using asmap to improve IP bucketing in addrman by naumenkogs . Pull Request #16702 . bitcoin/bitcoin . GitHub
< jonatack> elichai2: also some good stuff is up for grabs, like #16323 and #16324 by BlueMatt
< gribble> https://github.com/bitcoin/bitcoin/issues/16323 | Call ProcessNewBlock() asynchronously by TheBlueMatt . Pull Request #16323 . bitcoin/bitcoin . GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16324 | Get cs_main out of the critical path in ProcessMessages by TheBlueMatt . Pull Request #16324 . bitcoin/bitcoin . GitHub
< jonatack> basically anything labeled up for grabs: https://github.com/bitcoin/bitcoin/issues?q=label%3A%22Up+for+grabs%22+
< jonatack> (of course, review is not only really needed, it's also a good way to see things to do)
< elichai2> thanks
< petezz4> ? @jorijn
< jorijn> Hi!
< bitcoin-git> [bitcoin] elichai opened pull request #18061: util: Reimplement DecodeBase32/64 with std::string to remove `strlen` (master...2020-02-remove-strlen) https://github.com/bitcoin/bitcoin/pull/18061
< hebasto> MarcoFalke: close #8225 ?
< gribble> https://github.com/bitcoin/bitcoin/issues/8225 | Minimise/close and startup bugs . Issue #8225 . bitcoin/bitcoin . GitHub
< bitcoin-git> [bitcoin] promag opened pull request #18062: gui: Fix unintialized WalletView::progressDialog (master...2020-02-fix-unitialized-progressDialog) https://github.com/bitcoin/bitcoin/pull/18062
< bitcoin-git> [bitcoin] JeremyRubin opened pull request #18063: Improve UpdateForDescendants by using Epochs and Removing CacheMap (master...epoch-mempool-clean-split-2) https://github.com/bitcoin/bitcoin/pull/18063
< bitcoin-git> [bitcoin] promag opened pull request #18064: gui: Drop WalletModel dependency to RecentRequestsTableModel (master...2020-02-recentrequeststablemodel) https://github.com/bitcoin/bitcoin/pull/18064
< promag> going to hold pushing more prs regarding circular dependency until existing ones are merged
< hebasto> promag: \o/
< promag> lol :P
< jeremyrubin> Does anyone know what crypter parameters one might see in the wild? E.g. looking here
< jeremyrubin> If I were to see a value for nDeriveIterations that was not 25000 does anyone have any idea what sort of wallet would generate that
< sipa> jeremyrubin: it's measured at encryption time
< sipa> if you have a faster machine, the number will be higher
< jeremyrubin> Ah I see
< jeremyrubin> that's funny
< phantomcircuit> jeremyrubin, means lots of them have very high numbers and are effectively un-bruteforceable
< phantomcircuit> like would take longer to attack and to guess keys at random
< jeremyrubin> so we start by doing a check with the default iters for timing, then scale to a second then redo it and save?
< sipa> yup
< midnight> ³/w gmax
< jeremyrubin> Interesting... kinda weird that changing you passphrase on a older computer than when you set it originally would decrease security
< jeremyrubin> but other than that makes sense
< jeremyrubin> Maybe we should make it monotonically increase?
< jeremyrubin> May not be lower than a previously set value