< bitcoin-git> [bitcoin] fanquake closed pull request #18171: build: add macOS signing entitlements to macdeploy (master...macos_signing_requirements) https://github.com/bitcoin/bitcoin/pull/18171
< yevaud> I'm running rc2 on armv7/armv8 in a few weird setups. haven't seen anything noticeably wrong.
< fanquake> yevaud: thanks for testing
< kallewoof> If anyone is up for reviewing the Signet pull request (#16411) I'm willing to answer questions and stuff. :) Even feedback on whether to use a static genesis block or a dynamic one would be helpful. Would love to get this merged before 0.20 release.
< gribble> https://github.com/bitcoin/bitcoin/issues/16411 | BIP-325: Signet support by kallewoof · Pull Request #16411 · bitcoin/bitcoin · GitHub
< fanquake> Just about finished tracking down the race in #16307 !
< gribble> https://github.com/bitcoin/bitcoin/issues/16307 | scheduler: crash after releasing wallet · Issue #16307 · bitcoin/bitcoin · GitHub
< aj> fanquake: !!
< jeremyrubin> nice!
< fanquake> From what I currently understand, it's a race where if BlockConnected() is called just after BlockUntilSyncedToCurrentChain in UnloadWallet, the scheduler thread is looping in SyncTransaction -> AddToWalletIfInvolvingMe, which grabs the cs_wallet lock each time, but then we try and delete the wallet (and lock) and blow up
< fanquake> The more logging I add to try and diagnose, the less frequent the crash seems to be.
< fanquake> So that's definitely the problem. We are trying to delete the cs_wallet lock that's being held by the scheduler thread. Shoddy debugging notes: https://gist.github.com/fanquake/a2dc2cddc153e07c077cd67653f3350d
< pnn_m> hi!
< meshcollider> ping achow101 ?
< meshcollider> Oh probably not at this time of the morning
< provoostenator> Maybe promag is around?
< provoostenator> fanquake: I'm running the load/unload loop now, so far no crash. Any (build) configuration options that matter?
< provoostenator> Crash!
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #18131: add macOS notarization info to the release process doc (master...2020/02/notarize) https://github.com/bitcoin/bitcoin/pull/18131
< bitcoin-git> [bitcoin] uhliksk opened pull request #18189: Add error handling to all boost filesystem functions (master...master) https://github.com/bitcoin/bitcoin/pull/18189
< instagibbs> #17577 RFM
< gribble> https://github.com/bitcoin/bitcoin/issues/17577 | refactor: deduplicate the message sign/verify code by vasild · Pull Request #17577 · bitcoin/bitcoin · GitHub
< instagibbs> achow101, can you update #16528 description to include any active PRs that are rolling out subsets of those commits? I see at least one I just reviweed
< gribble> https://github.com/bitcoin/bitcoin/issues/16528 | Native Descriptor Wallets using DescriptorScriptPubKeyMan by achow101 · Pull Request #16528 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] practicalswift opened pull request #18190: tests: Add fuzzing harness for Golomb-Rice coding (GolombRiceEncode/GolombRiceDecode) (master...fuzzers-golomb-rice) https://github.com/bitcoin/bitcoin/pull/18190
< achow101> meshcollider: pong?
< achow101> instagibbs: updated
< instagibbs> fantastic thanks
< instagibbs> #18034 RFM as well
< gribble> https://github.com/bitcoin/bitcoin/issues/18034 | Get the OutputType for a descriptor by achow101 · Pull Request #18034 · bitcoin/bitcoin · GitHub
< achow101> if only meshcollider would wake up and merge things
< bitcoin-git> [bitcoin] MarcoFalke reopened pull request #16117: util: Replace boost:: with std:: in utiltime (master...1905-noBoostUtilTime) https://github.com/bitcoin/bitcoin/pull/16117
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/eb3c6b091234...e9fc8f6e7f57
< bitcoin-git> bitcoin/master d6d2602 0xb10c: add: test that transactions expire from mempool
< bitcoin-git> bitcoin/master e9fc8f6 MarcoFalke: Merge #18172: test: Transaction expiry from mempool
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18172: test: Transaction expiry from mempool (master...2020-02-mempool-expiry-test) https://github.com/bitcoin/bitcoin/pull/18172
< bitcoin-git> [bitcoin] meshcollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e9fc8f6e7f57...9dd7bd47be2f
< bitcoin-git> bitcoin/master 7e80f64 Andrew Chow: Get the OutputType for a descriptor
< bitcoin-git> bitcoin/master 9dd7bd4 Samuel Dobson: Merge #18034: Get the OutputType for a descriptor
< bitcoin-git> [bitcoin] meshcollider merged pull request #18034: Get the OutputType for a descriptor (master...desc-getoutputtype) https://github.com/bitcoin/bitcoin/pull/18034
< bitcoin-git> [bitcoin] luke-jr closed pull request #18175: [0.19] build: Allow export of environ symbols and work around rv64 toolchain issue (0.19...pr17569-0.18) https://github.com/bitcoin/bitcoin/pull/18175
< meshcollider> achow101: all good,
< meshcollider> instagibbs: thanks, I'll take a look at 17577 and 17264 today
< luke-jr> jonasschnelli: re https://github.com/bitcoin/bitcoin/issues/15774#issuecomment-589794604 the right-click trick no longer works⁇
< provoostenator> luke-jr: right-click still works, notarization removes the need for right-click.
< luke-jr> i c
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9dd7bd47be2f...36e507227ed6
< bitcoin-git> bitcoin/master fac52da MarcoFalke: test: Set catch_system_errors=no on boost unit tests
< bitcoin-git> bitcoin/master 36e5072 MarcoFalke: Merge #18183: test: Set catch_system_errors=no on boost unit tests
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18183: test: Set catch_system_errors=no on boost unit tests (master...2002-testNoCatchSystemErrors) https://github.com/bitcoin/bitcoin/pull/18183
< luke-jr> hmm, avoid-reuse wallets I think had a pretty big bug? they're setting address book data on change addresses..
< * luke-jr> works on a fix