< fanquake> promag: does #18160 actually fix a bug, like incorrect balances, or just improves on "a waste of resources"? If it's the later, it's unlikely it'd be backported.
< gribble> https://github.com/bitcoin/bitcoin/issues/18160 | gui: Avoid Wallet::GetBalance in WalletModel::pollBalanceChanged by promag · Pull Request #18160 · bitcoin/bitcoin · GitHub
< fanquake> Generally we only want to backport actual bug/security fixes. Making some poll/loop in the GUI slightly more efficient doesn't really qualify. Unless I'm missing something of course.
< bitcoin-git> [bitcoin] luke-jr closed pull request #17213: gui: Add Windows taskbar progress (master...win_taskbar_progress) https://github.com/bitcoin/bitcoin/pull/17213
< meshcollider> fanquake: I think it's the latter
< bitcoin-git> [bitcoin] promag closed pull request #16145: gui: Prevent idle sleep in macos while in IBD (master...2019-06-prevent-idle-sleep-ibd) https://github.com/bitcoin/bitcoin/pull/16145
< bitcoin-git> [bitcoin] jonatack closed pull request #18178: script: de-dupe and update valgrind suppressions (master...add-valgrind-suppressions) https://github.com/bitcoin/bitcoin/pull/18178
< stevenroose> Is anyone aware of some tools that auto-generate Core documentation from the source code? Basically like https://masonicboom.github.io/btcrpcapi/ but updated?
< sdaftuar> stevenroose: doxygen?
< sdaftuar> oh you mean API stuff, i don't know anything about that
< stevenroose> I'm talking about rpc docs, yes.
< stevenroose> Are the ones on bitcoin.org hand-crafted?
< sdaftuar> no idea, maybe check with that project
< sipa> sdaftuar: they're autogenerated from the rpc help command
< harding> stevenroose: this is the tool used for the RPC docs on BitcoinCore.org: https://github.com/bitcoin-core/bitcoincore.org/tree/master/contrib/doc-gen
< stevenroose> harding: thanks!
< harding> Bitcoin.org currently uses: https://github.com/cornelius/rpc-docs-helper
< stevenroose> eh, there's two different ones?
< stevenroose> harding: do you have an opinion on which one is better? :D
< harding> stevenroose: I've only used the BitcoinCore.org. Back when I worked on Bitcoin.org, I hand crafted those docs. After years of those docs bitrotting, they wrote their own tool, but I've never used it.
< bitcoin-git> [bitcoin] achow101 closed pull request #18163: descriptors: Use xpub at last hardened step if possible (master...desc-last-hardened) https://github.com/bitcoin/bitcoin/pull/18163
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c3b471592346...89a97a71f2ee
< bitcoin-git> bitcoin/master facb715 MarcoFalke: net: Remove forcerelay of rejected txs
< bitcoin-git> bitcoin/master 89a97a7 Wladimir J. van der Laan: Merge #17985: net: Remove forcerelay of rejected txs
< bitcoin-git> [bitcoin] laanwj merged pull request #17985: net: Remove forcerelay of rejected txs (master...2001-p2pNoDeadCode) https://github.com/bitcoin/bitcoin/pull/17985
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/89a97a71f2ee...e5d47ed8fd37
< bitcoin-git> bitcoin/master be94096 Samer Afach: Fix a violation of C++ standard rules that unions cannot be switched.
< bitcoin-git> bitcoin/master 0653939 Samer Afach: Add static_asserts to ser_X_to_Y() methods
< bitcoin-git> bitcoin/master e5d47ed Wladimir J. van der Laan: Merge #18167: Fix a violation of C++ standard rules where unions are used ...
< bitcoin-git> [bitcoin] laanwj merged pull request #18167: Fix a violation of C++ standard rules where unions are used for type-punning (master...master) https://github.com/bitcoin/bitcoin/pull/18167
< luke-jr> Is there a reason 0.19.1 isn't tagged yet? :x wumpus
< luke-jr> are we waiting on the macOS notary stuff?
< luke-jr> (if not, relnotes are missing the right-click tip)
< achow101> provoostenator: instagibbs: with descriptor wallets, do we even want to cache the individual keys if we're going to cache the intermediate xpub?
< achow101> so we just do on the fly key derivation
< meshcollider> yeah i dont think we need individual pubkeys cached
< achow101> I guess we only need them cached for hardened derivation
< luke-jr> uh, are descriptor wallets not going to support hardened derivation?
< achow101> they do
< luke-jr> so then we need to cache the individual keys..
< achow101> but only if they are hardened
< luke-jr> seems like a bad idea to special-case each type of derivation
< achow101> it shouldn't be a problem, just depends on what's in the cache
< achow101> i'm trying to avoid storing a ton of pubkeys in the wallet file
< luke-jr> never been a problem before..
< instagibbs> achow101, remind me what things are currently being cached when
< instagibbs> (in descriptor wallet PR)
< achow101> instagibbs: all derived pubkeys are cached during TopUp
< achow101> no intermediate xpubs yet, currently writing that
< instagibbs> cached where? (I gotta seriously review the PR...)
< achow101> in the wallet file
< instagibbs> ah
< instagibbs> It's two different things to test vs 1 if you make it different. Depends on relative complexity I guess
< bitcoin-git> [bitcoin] luke-jr closed pull request #10729: Wrap EvalScript in a ScriptExecution class (master...scriptex) https://github.com/bitcoin/bitcoin/pull/10729