< fanquake> Does anyone have anything to report re 0.19.1rc1 so far?
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/651e34388832...02fafdd12cca
< bitcoin-git> bitcoin/master ff59bcd Joao Barbosa: gui: Drop PeerTableModel dependency to ClientModel
< bitcoin-git> bitcoin/master 02fafdd fanquake: Merge #18060: gui: Drop PeerTableModel dependency to ClientModel
< bitcoin-git> [bitcoin] fanquake merged pull request #18060: gui: Drop PeerTableModel dependency to ClientModel (master...2020-02-peertablemodel) https://github.com/bitcoin/bitcoin/pull/18060
< fanquake> #18028
< gribble> https://github.com/bitcoin/bitcoin/issues/18028 | Some transactions cant be decoded from hex strings . Issue #18028 . bitcoin/bitcoin . GitHub
< aj> oh restarting doesn't leave old logs around? failed due to witness txid mismatch on wallet_bumpfee.py:190, sendrawtransaction( signrawtransactionwithwallet( .. )["hex"] )
< fanquake> I feel like normally they are somewhere, but I couldn't find them
< wumpus> FWIW I've seen nothing reported for 0.19.1rc1 so far
< fanquake> aj: yea it's happening frequently
< fanquake> #18016
< gribble> https://github.com/bitcoin/bitcoin/issues/18016 | travis: s390x ci build fails on travis because disk is too small . Issue #18016 . bitcoin/bitcoin . GitHub
< elichai2> Is 390x behabing for everyone lately? it's starting to get on my nerve hehe
< bitcoin-git> [bitcoin] jtimon closed pull request #16527: B: Get rid of Params().RequireStandard() (master...b19-chainparams-no-requirestd) https://github.com/bitcoin/bitcoin/pull/16527
< bitcoin-git> [bitcoin] jtimon closed pull request #17106: Chainparams: Decouple AllowSetMockTime from MineBlocksOnDemand (master...b20-chainparams-mocktime) https://github.com/bitcoin/bitcoin/pull/17106
< jtimon> I guess if I rebase now there will be more instances, but then I would lose the 2 ACKs.
< jtimon> What should I do?
< jtimon> how many acks do I need to get something merged anyway?
< elichai2> promag: hi, did you mean I should replace it with `ParseHex(const std::string&)` even though it will add a std::string allocations where we have raw strings (about 15% penalty in time in 32 byte hex on my machine)
< elichai2> I'll probably leave only the hex change.
< Talkless> A bit offtopic but.. I used `git fetch origin pull/ID/head:BRANCHNAME` from https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/checking-out-pull-requests-locally but how do now I update it after author force-pushed update..? My commit now is outadated, compared to what's visible on github...
< Talkless> whatever, just deleted branch and did that "trick" again.. ugh git is so daunting.. :/
< gwillen> Talkless: after you did that command, what did you do? There are a few ways to proceed from there, and the answer depends on which one you did.
< gwillen> It sounds like you checked it out into a local branch, in which case deleting the local branch and doing it again (as you did) is probably the easiest thing to do.
< Talkless> pulling produced merge errors, resetting just gone back to the original old version
< Talkless> yes :BRANCHNAME does that, doing second time is not allowed by git
< Talkless> then checkout BRANCHNAME I believe
< gwillen> aha yeah, I see the instructions
< gwillen> so, when you "checkout branchname" what it's doing is creating a new _local_ branch that is a copy of the _remote_ branch, and then it gets mad when the remote branch is force-pushed vs the local copy
< Talkless> gwillen: what would be your suggestion? I guess it's simpler to just go to authors git pate, clone it's repo and checkout that branch he's working on...
< gwillen> the way I prefer to do this is not to create a local branch at all -- instead I will directly "git checkout origin/pull/ID"
< gwillen> this does not create a local branch, and after a fetch you can just do it again to check out the new version
< Talkless> gwillen: wow, didn't new that trick, thanks
< Talkless> cool
< gwillen> np! git will warn you about "detached head", this warning just means you are on no local branch
< gwillen> which means you cannot commit any changes
< gwillen> but for reviewing this is fine
< Talkless> no I don't need commiting, just for review
< gwillen> exactly
< gwillen> (it's possible that I spelled the name of the remote branch wrong in the checkout -- you can "git branch -av" to see a list of all branches including remote ones, this will tell you the exact correct name of the remote branch)
< Talkless> this could be added to that tutorial on help.github.com :)
< gwillen> well, I have no power over help.github.com, but perhaps we could add it to one of the docs in the bitcoin core repo, if it's not there already
< gwillen> (if you haven't read all the stuff under https://github.com/bitcoin/bitcoin/tree/master/doc , do take a look, especially check out productivity.md, which is where I would add this with the other git tips)
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/02fafdd12cca...f32564f0a73c
< bitcoin-git> bitcoin/master 1abcecc Jorge Timon: Tests: Use self.chain instead of 'regtest' in almost all current tests
< bitcoin-git> bitcoin/master f32564f MarcoFalke: Merge #16681: Tests: Use self.chain instead of 'regtest' in all current te...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16681: Tests: Use self.chain instead of 'regtest' in all current tests (master...b19-testchains-tests) https://github.com/bitcoin/bitcoin/pull/16681
< promag> fanquake: damn
< fanquake> ?
< promag> we comment almost at the same time
< fanquake> ah ok
< bitcoin-git> [bitcoin] ryanofsky opened pull request #18067: wallet: Improve LegacyScriptPubKeyMan::CanProvide script recognition (master...pr/provide) https://github.com/bitcoin/bitcoin/pull/18067
< promag> FWIW WalletView::showProgress doesn't work well if it's not called with nProgress=0 - no progress dialog :/
< promag> fanquake: updated OP
< promag> I think that change is fine for backport
< fanquake> promag: thanks
< promag> later we can improve that
< promag> np