00:01 < meshcollider> Yes we can see both of your "test" messages

03:06 < bitcoin-git> [bitcoin] luke-jr opened pull request #19502: Bugfix: Wallet: Soft-fail exceptions within ListWalletDir file checks (master...bugfix_listwalletdir_errors) https://github.com/bitcoin/bitcoin/pull/19502

04:13 < luke-jr> I wonder if CIs should automatically detect when a lot of stuff is failing, and retest something known good previously.. then delete questionable results and pause until fixed?

04:24 < aj> it'd be nice to have an index of CI logs by failure type -- this PR failed due to X, did any others? oh, yes, everything after time T; some did, but it seems low-probability random; yes, a bunch of PRs touching this code do; nope, just yours

04:26 < luke-jr> well, that FreeBSD one seems to always fail?

04:28 < aj> "pkg: repository meta /var/db/pkg/FreeBSD.meta has wrong version 2" ? lame

04:29 < aj> cirrus-ci had some other "sysmtem is misconfigured and keeps failing" for me too

04:37 < kallewoof> sipa: getting "could not convert ‘(const uint8_t*)(& SIGNET_HEADER)’ from ‘const uint8_t*’ {aka ‘const unsigned char*’} to ‘Span<const unsigned char>’"

04:38 < sipa> just pass SIGNET_HEADER

04:38 < sipa> don't cast it to a pointer

04:38 < kallewoof> I am

04:38 < sipa> what is the code?

04:38 < kallewoof> if (!GetWitnessCommitmentSection(block, SIGNET_HEADER, signet_data)) {

04:38 < sipa> how is SIGNET_HEADER declared?

04:38 < kallewoof> static const uint8_t SIGNET_HEADER[4] = {0xec, 0xc7, 0xda, 0xa2};

04:39 < sipa> hmm!

04:39 < kallewoof> and bool GetWitnessCommitmentSection(const CBlock& block, Span<const uint8_t> header, std::vector<uint8_t>& result);

04:39 < sipa> you have a branch somewhere i can try?

04:40 < kallewoof> https://github.com/kallewoof/bitcoin/tree/signet-tmp

04:40 < bitcoin-git> [bitcoin] sipa opened pull request #19503: Add parameter feature to serialization and use it for CAddress (master...202007_ser_options) https://github.com/bitcoin/bitcoin/pull/19503

04:41 < r8921039> thx meshcollider i'm also verifying with the log http://www.erisian.com.au/bitcoin-core-dev a bit delay tho

04:41 < aj> kallewoof: my patch has the span stuff already

04:41 < kallewoof> aj: is that from your two emails? I haven't gotten to those yet :) Was going there next

04:42 < kallewoof> Maybe if you already have this down, sipa doesn't really have to waste his time on it tho..

04:42 < aj> kallewoof: https://github.com/ajtowns/bitcoin/commit/9d4949c6beab69f088d35ad333becfa0909ac0c9#diff-4bdd7c44636dae0429a4d61909eeed17R111

04:42 < kallewoof> oh, so use MakeSpan() is the solution?

04:43 < aj> kallewoof: yeah, i started a review then got distracted by the stuff in those emails, then looked at the pr again and it had a half finished review so i thought "should submit that" :)

04:43 < sipa> kallewoof: you should just rebase :p

04:43 < sipa> you don't have the recent Span improvements that permit this

04:43 < kallewoof> oh! thanks, will do

04:46 < sipa> kallewoof: specifically, you need #18468

04:46 < gribble> https://github.com/bitcoin/bitcoin/issues/18468 | Span improvements by sipa · Pull Request #18468 · bitcoin/bitcoin · GitHub

04:47 < kallewoof> very cool

04:47 < kallewoof> we don't need new c++ standards, we'll just bake it into our codebase ourselves! :P

04:48 < luke-jr> I thought this was just intended to be temporary until we upgrade?

04:49 < kallewoof> I was joking, ofc, but it might be a long time before we are on C++20, I assume.

04:49 < sipa> luke-jr: c++20 may take a while still

04:49 < sipa> as it doesn't formally exist yet

04:50 < sipa> but sure, once that's the case, obviously we don't need our own anymore (the interface is compatible)

04:50 < sipa> so it should just be a search/replace pretty much

04:51 < kallewoof> we are on c++11 now, though, right? or did we switch to 14 when I wasn't looking

04:51 < sipa> kallewoof: currently c++11; 0.22 will be c++17

04:51 < kallewoof> nice

04:52 < sipa> https://github.com/bitcoin/bitcoin/issues/16684

04:52 < * kallewoof> needs to read up on diff between 11 and 17

05:26 < bitcoin-git> [bitcoin] ajtowns opened pull request #19504: Bump minimum python version to 3.6 (master...202007-python3.6) https://github.com/bitcoin/bitcoin/pull/19504

08:25 < jnewbery> MarcoFalke wumpus fanquake: now that github is up again, I think #19109 and #19486 are Ready For Merge

08:25 < gribble> https://github.com/bitcoin/bitcoin/issues/19109 | Only allow getdata of recently announced invs by sipa · Pull Request #19109 · bitcoin/bitcoin · GitHub

08:25 < gribble> https://github.com/bitcoin/bitcoin/issues/19486 | Remove unused constants `CADDR_TIME_VERSION` and `GETHEADERS_VERSION` by jnewbery · Pull Request #19486 · bitcoin/bitcoin · GitHub

08:34 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/4db44acf2d5d...631284f09a18

08:34 < bitcoin-git> bitcoin/master 37a934e John Newbery: [protocol] Remove unused CADDR_TIME_VERSION

08:34 < bitcoin-git> bitcoin/master 7bb6f9b John Newbery: [protocol] Remove unused GETHEADERS_VERSION

08:34 < bitcoin-git> bitcoin/master 631284f MarcoFalke: Merge #19486: Remove unused constants `CADDR_TIME_VERSION` and `GETHEADERS...

08:34 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #19486: Remove unused constants `CADDR_TIME_VERSION` and `GETHEADERS_VERSION` (master...pr14033.1) https://github.com/bitcoin/bitcoin/pull/19486

08:37 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/631284f09a18...d52bfc491617

08:37 < bitcoin-git> bitcoin/master e74cd20 Hennadii Stepanov: qt, refactor: Cleanup ModalOverlay slots

08:37 < bitcoin-git> bitcoin/master d0cc1f6 Hennadii Stepanov: qt: Disable toolbar when overlay is shown

08:37 < bitcoin-git> bitcoin/master d52bfc4 MarcoFalke: Merge bitcoin-core/gui#30: Disable the main window toolbar when the modal ...

08:45 < MarcoFalke> wumpus: Mind to activate cirrus ci for the qa-assets repo ( https://github.com/apps/cirrus-ci/installations/9863527 ) ?

09:57 < vasild> sipa: MarcoFalke: Is there a reason to avoid `auto` in e.g. `auto var = FuncFoo();` and to prefer writing the type explicitly in some cases?

09:58 < vasild> Or is it just a matter of "taste"?

09:58 < hebasto> vasild: https://herbsutter.com/2013/08/12/gotw-94-solution-aaa-style-almost-always-auto/

10:00 < jonatack> steve meyers' effective c++ books generally recommended auto, but for consensus-critical bitcoin code i have observed a preference for explicit typing in some reviews and by some authors

10:09 < jonatack> just came across https://josephmansfield.uk/articles/dont-use-auto-unless-you-mean-it.html

12:18 < bitcoin-git> [bitcoin] Mr-Leshiy opened pull request #19505: ProcessHeadersMessage() fix potential bug (master...ProcessHeadersMessage/fix_bug) https://github.com/bitcoin/bitcoin/pull/19505

12:29 < bitcoin-git> [bitcoin] Mr-Leshiy closed pull request #19505: ProcessHeadersMessage() fix potential bug (master...ProcessHeadersMessage/fix_bug) https://github.com/bitcoin/bitcoin/pull/19505

12:54 < elichai2> jonatack: personally I think auto is great for iterators and other complex types where you don't really care about the type, but I find it harder to reason about things like auto return type, especially the way it can interact with implicit constructors

13:29 < fjahr> Can someone kick Travis for me on #19055? One job just didn't start...

13:29 < gribble> https://github.com/bitcoin/bitcoin/issues/19055 | Add MuHash3072 implementation by fjahr · Pull Request #19055 · bitcoin/bitcoin · GitHub

13:33 < wumpus> MarcoFalke: the Cirrus CI should be approved now

13:33 < instagibbs> elichai2, ack, mostly use it for iterators. I find it generally more confusing otherwise for review

13:33 < fjahr> Not sure if I should be able to do it myself but I am not seeing the restart button. I remember others having similar issues.

13:34 < fjahr> I can restart AppVeyor for example

13:34 < wumpus> fjahr: restarted

13:34 < fjahr> wumpus: thanks!

13:35 < wumpus> I think to restart travis runs you need write access to the repository

13:36 < fjahr> Ok :)

16:19 < jonatack> elichai2: thanks, seems sensible

16:33 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/d52bfc491617...37485baa2751

16:33 < bitcoin-git> bitcoin/master faa3d2e MarcoFalke: doc: Remove release notes of backports

16:33 < bitcoin-git> bitcoin/master fa740d4 MarcoFalke: doc: move-only release notes

16:33 < bitcoin-git> bitcoin/master 37485ba Wladimir J. van der Laan: Merge #19483: doc: Merge release notes

16:33 < bitcoin-git> [bitcoin] laanwj merged pull request #19483: doc: Merge release notes (master...2007-docRel) https://github.com/bitcoin/bitcoin/pull/19483

18:48 < bitcoin-git> [bitcoin] instagibbs opened pull request #19507: Expand functional zmq transaction tests (master...zmq_testing) https://github.com/bitcoin/bitcoin/pull/19507

20:01 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #19508: Work around memory-aliasing in descriptor ParsePubkey (master...2007-noAliasMemDesc) https://github.com/bitcoin/bitcoin/pull/19508

23:09 < bitcoin-git> [bitcoin] kallewoof closed pull request #18265: build: add data.h dependency to raw files (master...2003-makefile-bench-data) https://github.com/bitcoin/bitcoin/pull/18265

23:11 < kallewoof> wumpus: nah, i can restart travis builds and i'm readonly

23:12 < kallewoof> fjahr: sometimes you have to log out and back in. a bug i think