< fanquake> wumpus: I think I've tracked down the issue with your test for the ELF header LOAD commands 🚀
< fanquake> Just looks like some alignment issuses in the readelf output.
< fanquake> Still need to investigate your queries about potential alignment issues in the actual binary
< fanquake> The problem only shows up in readelf when the binary itself is large, and the addr/size columns push into the Flg column. So you ended up with '9 R' rather than 'R E' etc
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19604: Pass mempool pointer to UnloadBlockIndex/GetCoinsCacheSizeState (master...2007-memPointer) https://github.com/bitcoin/bitcoin/pull/19604
< bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/b62fbf9e1c19...a1da180b1b27
< bitcoin-git> bitcoin/master fa1f7f2 MarcoFalke: rpc: Style fixups in gettxoutproof
< bitcoin-git> bitcoin/master fa5979d MarcoFalke: rpc: Avoid useless mempool query in gettxoutproof
< bitcoin-git> bitcoin/master a1da180 fanquake: Merge #19589: rpc: Avoid useless mempool query in gettxoutproof
< bitcoin-git> [bitcoin] fanquake merged pull request #19589: rpc: Avoid useless mempool query in gettxoutproof (master...2007-rpcMempool) https://github.com/bitcoin/bitcoin/pull/19589
< bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/a1da180b1b27...2979a7aff04b
< bitcoin-git> bitcoin/master 634144a John Newbery: [net processing] Fixup MaybeDiscourageAndDisconnect() style
< bitcoin-git> bitcoin/master d15b3af John Newbery: [net processing] Always supply debug message to Misbehaving()
< bitcoin-git> bitcoin/master a8865f8 John Newbery: [net processing] Tidy up Misbehaving()
< bitcoin-git> [bitcoin] fanquake merged pull request #19583: p2p: clean up Misbehaving() (master...2020-07-tidy-misbehavior) https://github.com/bitcoin/bitcoin/pull/19583
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2979a7aff04b...cea39fc268e3
< bitcoin-git> bitcoin/master 623f665 Hennadii Stepanov: Fix .gitignore for src/test/fuzz directory
< bitcoin-git> bitcoin/master cea39fc fanquake: Merge #19595: Fix .gitignore for src/test/fuzz directory
< bitcoin-git> [bitcoin] fanquake merged pull request #19595: Fix .gitignore for src/test/fuzz directory (master...200727-fuzz) https://github.com/bitcoin/bitcoin/pull/19595
< bitcoin-git> [bitcoin] fanquake closed pull request #19578: wallet: Avoid duplicate checks on signing failure (master...2020-07-signtransaction) https://github.com/bitcoin/bitcoin/pull/19578
< bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/cea39fc268e3...e0ed4cc50de1
< bitcoin-git> bitcoin/master 00d1ba7 Cory Fields: depends: enable lto support for Apple's ld64
< bitcoin-git> bitcoin/master 5962522 Cory Fields: depends: bump native_cctools for fixed lto with external clang
< bitcoin-git> bitcoin/master e0ed4cc fanquake: Merge #19530: depends: build LTO support into Apple's ld64
< bitcoin-git> [bitcoin] fanquake merged pull request #19530: depends: build LTO support into Apple's ld64 (master...darwin-lto) https://github.com/bitcoin/bitcoin/pull/19530
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e0ed4cc50de1...24ead1a923e3
< bitcoin-git> bitcoin/master fdf697f Hennadii Stepanov: ci: Increase CCACHE_SIZE in some builds on Travis
< bitcoin-git> bitcoin/master 24ead1a MarcoFalke: Merge #19519: ci: Increase CCACHE_SIZE in some builds on Travis
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19519: ci: Increase CCACHE_SIZE in some builds on Travis (master...200714-ccache) https://github.com/bitcoin/bitcoin/pull/19519
< bitcoin-git> [bitcoin] fanquake opened pull request #19605: doc: set CC_FOR_BUILD when building on OpenBSD (master...openbsd_cc_for_build) https://github.com/bitcoin/bitcoin/pull/19605
< bitcoin-git> [bitcoin] jnewbery opened pull request #19606: Backport wtxid to v0.20 (0.20...2020-07-v20-wtxid-relay) https://github.com/bitcoin/bitcoin/pull/19606
< bitcoin-git> [bitcoin] jnewbery opened pull request #19607: [p2p] Add Peer struct for per-peer data in net processing (master...2020-07-peer) https://github.com/bitcoin/bitcoin/pull/19607
< jnewbery> ShellCheck is breaking travis builds: https://travis-ci.org/github/bitcoin/bitcoin/jobs/712484395
< jnewbery> You are downloading ShellCheck from an outdated URL!
< jnewbery> Please update to the new URL:
< jnewbery> For more information, see:
< jnewbery> PS: Sorry for breaking your build. The hosting costs were getting out of hand :(
< fanquake> ugh
< fanquake> I can fix that now if you're not going to
< fanquake> Actually. We are already downloading from https://github.com/koalaman/shellcheck/. So I'm not sure why that would have broken.
< jnewbery> ah, it's for my backport to the 0.20 branch
< jnewbery> I suppose I need to backport the ShellCheck fix too?
< fanquake> Just PR that separately. If it's going to break any other builds / backports and be a pain no need for it to wait on your PR.
< jnewbery> will do. Thanks!
< fanquake> Should be able to merge right away
< bitcoin-git> [bitcoin] jonatack opened pull request #19610: p2p, refactor: add `CInv` block message helpers; use in net processing (master...CInv-block-message-helpers) https://github.com/bitcoin/bitcoin/pull/19610
< bitcoin-git> [bitcoin] jonatack opened pull request #19611: p2p: refactor CInv::type from public int to private uint32_t (master...CInv-type-refactoring) https://github.com/bitcoin/bitcoin/pull/19611
< darosior> MarcoFalke: regarding https://github.com/bitcoin/bitcoin/pull/19556. I plan to rebase https://github.com/bitcoin/bitcoin/pull/18766 on top of it and you mentioned "Removing the fee estimates global": do you think the fee estimator could be a field of CTxMemPool instead ?
< bitcoin-git> [bitcoin] fanquake opened pull request #19612: [0.20] lint: fix shellcheck URL in CI install (0.20...fix_shellcheck_0_20) https://github.com/bitcoin/bitcoin/pull/19612
< fanquake> #pointlessPRoftheweek
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to 0.20: https://github.com/bitcoin/bitcoin/compare/58feb9ecb647...6acb21e724e3
< bitcoin-git> bitcoin/0.20 7ee4769 fanquake: [0.20] lint: fix shellcheck URL in CI install
< bitcoin-git> bitcoin/0.20 6acb21e MarcoFalke: Merge #19612: [0.20] lint: fix shellcheck URL in CI install
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19612: [0.20] lint: fix shellcheck URL in CI install (0.20...fix_shellcheck_0_20) https://github.com/bitcoin/bitcoin/pull/19612
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19613: travis: Re-enable s390x (master...2007-travisS390x) https://github.com/bitcoin/bitcoin/pull/19613
< shesek> I released Minsc, a compile-to-Miniscript scripting language with some additional features and syntactic sugar. Documentation and a live compiler are available on https://min.sc/, source code is at https://github.com/shesek/minsc
< bitcoin-git> [bitcoin] fanquake opened pull request #19614: util: use HAVE_FDATASYNC to determine fdatasync() use (master...use_have_fdatasync) https://github.com/bitcoin/bitcoin/pull/19614
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/24ead1a923e3...a41ae6805338
< bitcoin-git> bitcoin/master fae6561 MarcoFalke: travis: Re-enable s390x
< bitcoin-git> bitcoin/master a41ae68 MarcoFalke: Merge #19613: travis: Re-enable s390x
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19613: travis: Re-enable s390x (master...2007-travisS390x) https://github.com/bitcoin/bitcoin/pull/19613
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #19509: Per-Peer Message Logging (master...message-dump) https://github.com/bitcoin/bitcoin/pull/19509
< bitcoin-git> [bitcoin] MarcoFalke reopened pull request #19509: Per-Peer Message Logging (master...message-dump) https://github.com/bitcoin/bitcoin/pull/19509
< sdaftuar> i saw i missed some discussion around wtxid-relay being deployed in advance of taproot, driving some desire to backport it
< sdaftuar> jnewbery: sipa: ^^
< sdaftuar> it's not clear to me how important that is...
< sdaftuar> for instance, a simpler solution might be to just backport a patch to 0.20 (and 0.19 and older, however far back people want to go) that adds txids of transactions that fail the AreInputsStandard check to the reject filter
< sdaftuar> that might take some small refactoring of the logic, but would involve a much less involved p2p change and would presumably be much easier to test and reason about
< sdaftuar> i haven't tried doing it to see how hard it would be though, so up to whoever is interested in what direction to go
< sipa> sdaftuar: another alternative that was suggested somewhere was just not relaying taproot spending txn to non-wtxidrelay peers
< sdaftuar> i guess that would work too -- and also is much simpler than backporting
< sipa> (i'm not a fan in general of adding these ad-hoc assumptions about relay policy, but if there is a concern about timelines of wtxid relay and taproot interacting, that's a simple solution)
< sdaftuar> i like the simple fix to the reject filter because it gives users concerned about bandwidth considerations a simple way to mitigate the issue
< sdaftuar> without redoing a lot of p2p code, which is higher risk
< sdaftuar> and it should be exactly correct
< sdaftuar> and it should be exactly correct/
< sdaftuar> that was supposed to say: taproot doesn't support p2sh, right?
< sipa> indeed
< sipa> adding AreInputsStandard failures to the reject filter also seems simple
< sipa> but it will only benefit nodes that adopt that patch
< sdaftuar> which i think is (more than?) sufficient for this type of concern
< sipa> regarding p2dh: that isn't relevant i think?
< sipa> sends to future witness versions are standard already
< sipa> only spends from them aren't
< sipa> ah.
< sdaftuar> i'd have to double-chekc, but i think if taproot supported p2sh wrapped outputs, the witness check would happen elsewhere no?
< sipa> but this also means that AreInputsStandard won't detect this
< sipa> it needs script execution to detect?
< sdaftuar> i think it will -- i think spending a (bare) v1 output will fail there
< sdaftuar> we use that solver thing in AreInputsStandard? i'll double check
< sipa> ah ye
< sipa> Solver will return WITNESS_UNKNOWN, which isn't automatically rejected
< sipa> by AreInputsStandard, but it easily could be made so
< sdaftuar> oh, you're right -- i assumed that was a failure
< sdaftuar> odd