< yanmaani>
What's the deal with the style guide? Bools used to be prefixed with f, but now this is prohibited?
< instagibbs>
yanmaani, prohibited is probably not the right word, but yeah discouraged
< yanmaani>
what changed? It looks really jarring with the overlap
< sipa>
first there was satoshi, and he strictly used his own weird coding style (which included hungarian notation for variable names)
< sipa>
then he suddenly disapppeared, and people started using whatever coding style they like, in particular not following hungarian notation anymore (which is widely considered to be a bad idea now; it was popular in the '90s)
< yanmaani>
seems easier to just stick with the Hungarian notation tbh
< sipa>
so we had a codebase that was mixed in many ways, but given that people tend to mimick the surrounding code when writing new code, ot wasn't ever going to converge
< sipa>
so we had to pick one of the other to encourage for new code
< sipa>
and we picked the more modern one
< yanmaani>
Why not just auto-lint the entire codebase?
< sipa>
because that breaks literally everything
< sipa>
pull requests often have month-long depays, sometimes years
< yanmaani>
it'd be a mighty merge commit, that's true
< sipa>
including downstream projects, or people who maintain patchsets on top
< instagibbs>
it would also make git blaming harder for basically no reason
< yanmaani>
Wouldn't it have been easier to just go with what was the most code by loc count? So some weird mix of hungarian and the other stuff
< instagibbs>
pre style guide people estimated that, often incorrectly, so you had oscillating mixtures based on surrounding loc....
< yanmaani>
like a cellular automaton :D
< instagibbs>
if you're writing the line, use the style guide, if you're touching the line, maybe update it :)
< yanmaani>
yeah it just looks so jarring, cause you can't randomly refactor the surrounding code. I guess it's fine if you don't think about it too much
< sipa>
when refactoring, you're allowed to stick to the old names
< sipa>
if you're going to touch every place a particular variable name is used, preferably change to new stylr
< instagibbs>
right, sorry if unclear. If you're introducing the variable, stick to guide
< yanmaani>
I guess I'll get used to it lol
< yanmaani>
thanks
< instagibbs>
it's an art, just don't go renaming everything for no reason :)
< mutatrum>
With the aarch64 build, Is it correct that the ARMv8 Crypto Extensions are not used?
< mutatrum>
As it logs "Using the 'standard' SHA256 implementation" on a Cortex-A55 cpu.
< luke-jr>
mutatrum: aarch64 is apparently completely different from 32-bit arm architecture; do you know which one the extensions are for?
< sipa>
mutatrum: there are is no platform specific optimized version of sha256 for arm, afaik
< luke-jr>
mutatrum: is the extension for the 32-bit ARM architecture, or aarch64?
< luke-jr>
x86 comes in 32-bit and 64-bit flavours, but ARM only comes in 32-bit, and aarch64 only in 64-bit; they're not two flavours of the same architecture
< mutatrum>
luke-jr: The Crypto extensions are available on armv8 and it states it's available in both 32 and 64 bit mode. But the core 32 bit arm build is Armv7, so there it's not available.
< mutatrum>
Or, more accurate: support is optional for Armv8.
< phantomcircuit>
mutatrum, those patches looks reasonably easy to port