< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/476436b2dec2...f5000ae66c40
< bitcoin-git> bitcoin/master 55057ff Sebastian Falbesoner: rpc: deduplicate WriteHDKeypath() used in decodepsbt
< bitcoin-git> bitcoin/master f5000ae fanquake: Merge #19555: rpc: deduplicate WriteHDKeypath() used in decodepsbt
< bitcoin-git> [bitcoin] fanquake merged pull request #19555: rpc: deduplicate WriteHDKeypath() used in decodepsbt (master...20200719-rpc-dedup-writehdkeypath) https://github.com/bitcoin/bitcoin/pull/19555
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f5000ae66c40...caf1766daf2f
< bitcoin-git> bitcoin/master 6be3eeb Hennadii Stepanov: doc: Update macOS cross compilation dependencies for Focal
< bitcoin-git> bitcoin/master caf1766 fanquake: Merge #19547: doc: Update macOS cross compilation dependencies for Focal
< bitcoin-git> [bitcoin] fanquake merged pull request #19547: doc: Update macOS cross compilation dependencies for Focal (master...200718-mac-dep) https://github.com/bitcoin/bitcoin/pull/19547
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/caf1766daf2f...b763ae02a660
< bitcoin-git> bitcoin/master 4455949 David Reikher: Make test DoS_mapOrphans deterministic
< bitcoin-git> bitcoin/master b763ae0 MarcoFalke: Merge #16878: Fix non-deterministic coverage of test DoS_mapOrphans
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16878: Fix non-deterministic coverage of test DoS_mapOrphans (master...make_denialofservice_tests_deterministic) https://github.com/bitcoin/bitcoin/pull/16878
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/b763ae02a660...ea595d39f7e7
< bitcoin-git> bitcoin/master e1e5960 Brian Liotti: script: Add previous_release.py
< bitcoin-git> bitcoin/master 9c34aff Brian Liotti: Remove previous_release.sh
< bitcoin-git> bitcoin/master ea595d3 MarcoFalke: Merge #19205: script: previous_release.sh rewritten in python
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19205: script: previous_release.sh rewritten in python (master...previous-release-py) https://github.com/bitcoin/bitcoin/pull/19205
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19560: contrib: Clean up previous_releases.py (master...2007-prevRelTidy) https://github.com/bitcoin/bitcoin/pull/19560
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ea595d39f7e7...65a54d684fcf
< bitcoin-git> bitcoin/master 5fa067a Tom Harding: Remove unnecessary blockfile SetPos
< bitcoin-git> bitcoin/master 65a54d6 MarcoFalke: Merge #18984: Remove unnecessary input blockfile SetPos
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18984: Remove unnecessary input blockfile SetPos (master...patch-1) https://github.com/bitcoin/bitcoin/pull/18984
< bitcoin-git> [bitcoin] S3RK opened pull request #19561: refactor: Pass ArgsManager into functions that register args (master...args_manager) https://github.com/bitcoin/bitcoin/pull/19561
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/65a54d684fcf...910a8d9c6fb4
< bitcoin-git> bitcoin/master facdf53 MarcoFalke: contrib: Clean up previous_releases.py
< bitcoin-git> bitcoin/master 910a8d9 fanquake: Merge #19560: contrib: Clean up previous_releases.py
< bitcoin-git> [bitcoin] fanquake merged pull request #19560: contrib: Clean up previous_releases.py (master...2007-prevRelTidy) https://github.com/bitcoin/bitcoin/pull/19560
< bitcoin-git> [bitcoin] troygiorshev closed pull request #19107: p2p: Move all header verification into the network layer, extend logging (master...p2p-refactor-header) https://github.com/bitcoin/bitcoin/pull/19107
< bitcoin-git> [bitcoin] troygiorshev reopened pull request #19107: p2p: Move all header verification into the network layer, extend logging (master...p2p-refactor-header) https://github.com/bitcoin/bitcoin/pull/19107
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/910a8d9c6fb4...edfeaf6836f1
< bitcoin-git> bitcoin/master 12410b1 Jon Atack: test: fix intermittent p2p_ibd_txrelay race, add test_framework.py#wait_un...
< bitcoin-git> bitcoin/master edfeaf6 MarcoFalke: Merge #19552: test: fix intermittent failure in p2p_ibd_txrelay
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19552: test: fix intermittent failure in p2p_ibd_txrelay (master...fix-intermittent-p2p_ibd_txrelay-failure) https://github.com/bitcoin/bitcoin/pull/19552
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/edfeaf6836f1...2c0c3f8e8ca6
< bitcoin-git> bitcoin/master ec4c6a1 glowang: scripted-diff: replace MAX_BLOCKS_ONLY_CONNECTIONS with MAX_BLOCK_RELAY_ON...
< bitcoin-git> bitcoin/master 2c0c3f8 MarcoFalke: Merge #19217: p2p: disambiguate block-relay-only variable names from block...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19217: p2p: disambiguate block-relay-only variable names from blocksonly variables (master...2020/06/08/rename-max-block-relay-connection-name) https://github.com/bitcoin/bitcoin/pull/19217
< yanmaani> What's the deal with the style guide? Bools used to be prefixed with f, but now this is prohibited?
< instagibbs> yanmaani, prohibited is probably not the right word, but yeah discouraged
< yanmaani> what changed? It looks really jarring with the overlap
< sipa> first there was satoshi, and he strictly used his own weird coding style (which included hungarian notation for variable names)
< sipa> then he suddenly disapppeared, and people started using whatever coding style they like, in particular not following hungarian notation anymore (which is widely considered to be a bad idea now; it was popular in the '90s)
< yanmaani> seems easier to just stick with the Hungarian notation tbh
< sipa> so we had a codebase that was mixed in many ways, but given that people tend to mimick the surrounding code when writing new code, ot wasn't ever going to converge
< sipa> so we had to pick one of the other to encourage for new code
< sipa> and we picked the more modern one
< yanmaani> Why not just auto-lint the entire codebase?
< sipa> because that breaks literally everything
< sipa> pull requests often have month-long depays, sometimes years
< yanmaani> it'd be a mighty merge commit, that's true
< sipa> including downstream projects, or people who maintain patchsets on top
< instagibbs> it would also make git blaming harder for basically no reason
< yanmaani> Wouldn't it have been easier to just go with what was the most code by loc count? So some weird mix of hungarian and the other stuff
< instagibbs> pre style guide people estimated that, often incorrectly, so you had oscillating mixtures based on surrounding loc....
< yanmaani> like a cellular automaton :D
< instagibbs> if you're writing the line, use the style guide, if you're touching the line, maybe update it :)
< yanmaani> yeah it just looks so jarring, cause you can't randomly refactor the surrounding code. I guess it's fine if you don't think about it too much
< sipa> when refactoring, you're allowed to stick to the old names
< sipa> if you're going to touch every place a particular variable name is used, preferably change to new stylr
< instagibbs> right, sorry if unclear. If you're introducing the variable, stick to guide
< yanmaani> I guess I'll get used to it lol
< yanmaani> thanks
< instagibbs> it's an art, just don't go renaming everything for no reason :)
< mutatrum> With the aarch64 build, Is it correct that the ARMv8 Crypto Extensions are not used?
< mutatrum> As it logs "Using the 'standard' SHA256 implementation" on a Cortex-A55 cpu.
< luke-jr> mutatrum: aarch64 is apparently completely different from 32-bit arm architecture; do you know which one the extensions are for?
< sipa> mutatrum: there are is no platform specific optimized version of sha256 for arm, afaik
< mutatrum> I found this repo, but it's stale https://github.com/rollmeister/bitcoin-armv8
< sipa> mutatrum: heh, i've never seen that
< sipa> no idea why it wasn't upstreamed
< mutatrum> luke-jr: what do you mean by 'which one '? Which cpus? Or which cryptographic algos?
< mutatrum> Armv8-A Cryptographic Extension: AES encryption and decryption, SHA functions SHA-1, SHA-224, and SHA-256.
< mutatrum> This is from the Cortex-A55 docs.
< phantomcircuit> sipa, ey neat
< bitcoin-git> [bitcoin] freenancial opened pull request #19562: test: Fix fuzzer compilation on macOS (master...fix-fuzzer-macos) https://github.com/bitcoin/bitcoin/pull/19562
< luke-jr> mutatrum: is the extension for the 32-bit ARM architecture, or aarch64?
< luke-jr> x86 comes in 32-bit and 64-bit flavours, but ARM only comes in 32-bit, and aarch64 only in 64-bit; they're not two flavours of the same architecture
< mutatrum> luke-jr: The Crypto extensions are available on armv8 and it states it's available in both 32 and 64 bit mode. But the core 32 bit arm build is Armv7, so there it's not available.
< mutatrum> Or, more accurate: support is optional for Armv8.
< phantomcircuit> mutatrum, those patches looks reasonably easy to port