02:29 < luke-jr> #21111 sounds rtm

02:29 < gribble> https://github.com/bitcoin/bitcoin/issues/21111 | Improve OpenRC initscript by parazyd · Pull Request #21111 · bitcoin/bitcoin · GitHub

06:41 < vasild> luke-jr: "should #19763 get backported?" - I don't think so because it is a kind of optimisation, not a bugfix.

06:41 < gribble> https://github.com/bitcoin/bitcoin/issues/19763 | net: dont try to relay to the address originator by vasild · Pull Request #19763 · bitcoin/bitcoin · GitHub

07:12 < bitcoin-git> [bitcoin] fanquake opened pull request #21320: build: fix libnatpmp macos cross compile (master...fix_libnatpmp_cross_macos) https://github.com/bitcoin/bitcoin/pull/21320

07:57 < bitcoin-git> [bitcoin] hebasto opened pull request #21321: guix: Add curl to required tool list (master...210301-curl) https://github.com/bitcoin/bitcoin/pull/21321

08:37 < bitcoin-git> [bitcoin] hebasto opened pull request #21323: guix, doc: Update default HOSTS value (master...210301-guixdoc) https://github.com/bitcoin/bitcoin/pull/21323

09:06 < wumpus> fanquake: blocked

09:23 < aj> wumpus: aww, don't block fanquake, he's cool

09:24 < hebasto> :)

10:14 < wumpus> lol !

10:38 < wumpus> seems #21007 is ready, but some more ACKs would be nice

10:38 < gribble> https://github.com/bitcoin/bitcoin/issues/21007 | bitcoind: Add -daemonwait option to wait for initialization by laanwj · Pull Request #21007 · bitcoin/bitcoin · GitHub

10:46 < bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/e52ce9f2b312...362e901a17cc

10:46 < bitcoin-git> bitcoin/master e62f0c7 Sebastian Falbesoner: rpc: fix {sign,message}verify RPC errors for invalid address/signature

10:46 < bitcoin-git> bitcoin/master 9e399b9 Sebastian Falbesoner: test: check parameter validity in rpc_signmessage.py

10:46 < bitcoin-git> bitcoin/master a5cfb40 Sebastian Falbesoner: doc: release note for changed {sign,verify}message error codes

10:46 < bitcoin-git> [bitcoin] laanwj merged pull request #18466: rpc: fix invalid parameter error codes for {sign,verify}message RPCs (master...20200329-rpc-improve-signverifymessage-error-codes) https://github.com/bitcoin/bitcoin/pull/18466

11:08 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/362e901a17cc...ad89812c70a9

11:08 < bitcoin-git> bitcoin/master 97f1062 Hennadii Stepanov: guix: Add curl to required tool list

11:08 < bitcoin-git> bitcoin/master ad89812 Wladimir J. van der Laan: Merge #21321: guix: Add curl to required tool list

11:09 < bitcoin-git> [bitcoin] laanwj merged pull request #21321: guix: Add curl to required tool list (master...210301-curl) https://github.com/bitcoin/bitcoin/pull/21321

11:09 < aj> wumpus: (looking at 21007)

11:29 < wumpus> thank u

11:56 < vasild> jonatack: wumpus: thanks for your comments on #20685, I will rebase, address comments, add tests. Just some health issues at home are limiting my dev time. Hold on! :)

11:56 < gribble> https://github.com/bitcoin/bitcoin/issues/20685 | Add I2P support using I2P SAM by vasild · Pull Request #20685 · bitcoin/bitcoin · GitHub

11:56 < vasild> first rebase, that should be easy...

12:01 < jonatack> vasild: oh no, stay healthy for you and yours at home! (also as wumpus suggested, can do minimal changes for now on 20685 and tests as follow-up)

12:02 < jonatack> vasild: (and thank you for your outstanding review of #20197)

12:03 < gribble> https://github.com/bitcoin/bitcoin/issues/20197 | p2p: protect onions in AttemptToEvictConnection(), add eviction protection test coverage by jonatack · Pull Request #20197 · bitcoin/bitcoin · GitHub

12:14 < wumpus> vasild: no hurry, and if you prefer so, one of us could pick it up

14:13 < bitcoin-git> [bitcoin] hebasto opened pull request #21324: doc: Update build instructions for Fedora (master...210301-fedora) https://github.com/bitcoin/bitcoin/pull/21324

15:26 < bitcoin-git> [bitcoin] fyquah opened pull request #21325: lint: Fix spelling errors in comments (master...fix-spelling-errors) https://github.com/bitcoin/bitcoin/pull/21325

15:41 < hebasto> achow101: does "File" -> "Load PSBT from {file|clipboard}" make any sense when no wallet is loaded?

15:51 < bitcoin-git> [bitcoin] dougEfresh opened pull request #21326: doc: remove the word 'experimental' in README (master...master) https://github.com/bitcoin/bitcoin/pull/21326

16:20 < bitcoin-git> [bitcoin] dougEfresh closed pull request #21326: doc: remove the word 'experimental' in README (master...master) https://github.com/bitcoin/bitcoin/pull/21326

16:27 < bitcoin-git> [bitcoin] glozow opened pull request #21327: net_processing: ignore transactions while in IBD (master...2021-02-ibd-txrelay) https://github.com/bitcoin/bitcoin/pull/21327

17:02 < achow101> hebasto: yes, for finalize and sending

17:02 < * hebasto> achow101: doesn't finalizing require a private key?

17:03 < vasild> jonatack: wrt commenting on a PR via your own commit in your repo - I think this is superior to github comments to some extent. However if you delete that branch, some review history will be lost.

17:04 < achow101> hebasto: no, it does not. Finalizing is only creating the final scriptSig and scriptWitness from the data already in the PSBT

17:05 < hebasto> oh, I see; but "File" -> "Load PSBT from file" do not work, actually (with no loaded wallet)

17:10 < jonatack> vasild: that's true. I see you pushed updates...LMK when it's time to re-review.

17:11 < vasild> now :)

17:12 < jonatack> ok :)

17:13 < vasild> I still have not come to the Sock -> unique_ptr<Sock> change to facilitate fuzzing. Once I do I will assess whether to amend this PR or leave that as a followup PR, depening on the size of the change and number of ACKs accumulated :)

17:15 < vasild> oh, no, the linter does not like R"(foo "bar" baz)" - I used that syntax at some point but removed it and now I remember why!

18:07 < jonatack> vasild: tested ack but github once again lost my review before I sent it :/ ...re-writing...

18:13 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ad89812c70a9...05e821ee1955

18:13 < bitcoin-git> bitcoin/master e3e0a24 Martin Ankerl: Add benchmark to write JSON into a string

18:13 < bitcoin-git> bitcoin/master 05e821e Wladimir J. van der Laan: Merge #21170: bench: Add benchmark to write JSON into a string

18:13 < bitcoin-git> [bitcoin] laanwj merged pull request #21170: bench: Add benchmark to write JSON into a string (master...2021-02-benchmark-BlockToJsonVerboseWrite) https://github.com/bitcoin/bitcoin/pull/21170

21:26 < bitcoin-git> [gui] achow101 opened pull request #233: qt test: Don't bind to regtest port (master...qttest-other-port) https://github.com/bitcoin-core/gui/pull/233

22:25 < bitcoin-git> [bitcoin] jonatack opened pull request #21328: net, refactor: pass uint16 CService::port as uint16 (master...pass-uint16_t-CService-port-as-uint16_t) https://github.com/bitcoin/bitcoin/pull/21328

22:53 < bitcoin-git> [bitcoin] achow101 opened pull request #21329: descriptor wallet: Cache last hardened xpub and use in normalized descriptors (master...norm-desc-xpub-cache) https://github.com/bitcoin/bitcoin/pull/21329