hebasto: yes, for finalize and sending
< * hebasto>
achow101: doesn't finalizing require a private key?
jonatack: wrt commenting on a PR via your own commit in your repo - I think this is superior to github comments to some extent. However if you delete that branch, some review history will be lost.
hebasto: no, it does not. Finalizing is only creating the final scriptSig and scriptWitness from the data already in the PSBT
oh, I see; but "File" -> "Load PSBT from file" do not work, actually (with no loaded wallet)
vasild: that's true. I see you pushed updates...LMK when it's time to re-review.
I still have not come to the Sock -> unique_ptr<Sock> change to facilitate fuzzing. Once I do I will assess whether to amend this PR or leave that as a followup PR, depening on the size of the change and number of ACKs accumulated :)
oh, no, the linter does not like R"(foo "bar" baz)" - I used that syntax at some point but removed it and now I remember why!
vasild: tested ack but github once again lost my review before I sent it :/ ...re-writing...