< hebasto>
fanquake: hah, last week I was banned in linguist telegram group after mentioning translation Bitcoin Core
< fanquake>
hebasto: hope you got the info you needed beforehand
< hebasto>
nope :)
< fanquake>
Same person has followed up by emailing me a private key. “Here, take my private key, you get zero bitcoin”
< sipa>
How nice.
< aj>
sipa: Add a comment: "round up to the next strictly larger multiple of 1000"? -- would "Have each group of tests be counted by the 1000s part, starting at 1000" be clear enough? explains more the why than the what
< sipa>
aj: sgtm
< fanquake>
“You are ruining people's lives.”
< fanquake>
it really is the morning for nice emails
< bitcoin-git>
[gui] hebasto opened pull request #257: refactor: Use template function qOverload in signal-slot connections (master...210323-overload) https://github.com/bitcoin-core/gui/pull/257
< aj>
fanquake: what is "your branch" that differed from 20901? is that something worth knowing about?
< aj>
oh, duh, read the comment more carefully aj
< aj>
fanquake: your correctly worded ACKs are ruining my life :(
< fanquake>
aj: I'll try and word them more "fast and loose" going forward
< aj>
oh wait, forget i said anything. i should be riffing off "said hanrahan" for fanquake ruining things
< aj>
"We'll all be rooned" said fanquake's man // In an email most forlorn // Outside the repo, evading bans // One toasty We'n'sd'y morn. // The IRCers lurked and talked // PRs up to their ears // And talked of tests, CI and forks // As they had done for years.
< bitcoin-git>
[bitcoin] achow101 opened pull request #21520: [0.21] wallet: Avoid requesting fee rates multiple times during coin selection (0.21...0.21-createtx-same-feerate) https://github.com/bitcoin/bitcoin/pull/21520
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #21522: fuzz: [refactor] Use PickValue where possible (master...2103-fuzzPickValue) https://github.com/bitcoin/bitcoin/pull/21522
< achow101>
I think that was marked as a draft for a reason
< aj>
fanquake: like it said in the description, it was a draft to avoid conflicting with the speedy trial PRs. now it'll also need backporting to 0.21
< aj>
also, i'm loving this ruining my life meme
< fanquake>
none of the speedy trial PRs are anywhere near close to being merged right?
< aj>
well they're further away now!
< aj>
should've titled it DO-NOT-MERGE as well as marked it draft i suppose
< fanquake>
aj: apologies. Is there an overarching issue tracking how all of these PRs piece together. It's not very clear, and they all seem to based on, or borrow commits from each other etc.
< fanquake>
I'm also just trying to figure out where the "root" of the conflict is. I assume e9e24b9ad836c4f425e6c22f1c4a179dab9e75ea ?
< aj>
fanquake: there'll be neighbouring lines changed between removing the 'const x = 0' defaults and adding a 'const min_activation_height' if nothing else
< aj>
fanquake: no big deal to fix in either PR, just extra rebasing we could've avoided
< fanquake>
achow101: sorry. Thanks for the quick rebase.
< aj>
fanquake: you could poke at #20353 if you wanted? :)
< bitcoin-git>
[bitcoin] fanquake merged pull request #20734: build: Make platform-specific targets available for proper platform builds only (master...201221-targets) https://github.com/bitcoin/bitcoin/pull/20734
< jnewbery>
aj: I did a bit of analysis on which symbols are being repeatedly built: https://0bin.net/paste/-OvrrVEt#RCFVJG+4cfPl1M7UmHWxu9HGLh+xLilkZM1XeR2v-bN
< jnewbery>
the big offenders are tinyformat and boost::system
< jnewbery>
I did the same for 0.21, and all the numbers have gone up
< jnewbery>
the largest/most built symbol is this, which is new since 0.21:
< bitcoin-git>
bitcoin/master 39a9ec5 Troy Giorshev: Unconditionally check for fRelay field in test framework
< bitcoin-git>
bitcoin/master ed49203 MarcoFalke: Merge #21357: test: Unconditionally check for fRelay field in test framewo...
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #21357: test: Unconditionally check for fRelay field in test framework (master...test-framework-ver-msg-fix) https://github.com/bitcoin/bitcoin/pull/21357
< bitcoin-git>
[bitcoin] dongcarl opened pull request #21525: [Bundle 4.5/n] Followup fixups to bundle 4 (master...2021-03-kernel-bundle-4.5) https://github.com/bitcoin/bitcoin/pull/21525