< bitcoin-git>
[bitcoin] sipa opened pull request #21330: Deal with missing data in signature hashes more consistently (master...202103_missing_data_verify) https://github.com/bitcoin/bitcoin/pull/21330
< bitcoin-git>
[bitcoin] fanquake opened pull request #21331: rpc: replace raw pointers with shared_ptrs (#18592 rebased) (master...18592_rebased) https://github.com/bitcoin/bitcoin/pull/21331
< jnewbery>
luke-jr: #20557 doesn't seem worth the effort to backport. It's not critical
< wumpus>
thanks vasild and everyone who helped testing and reviewing
< prusnak>
does that work with i2pd too, or only the original i2p software works?
< vasild>
prusnak: also with i2pd
< wumpus>
it definitely works with i2pd (i think most current users use that)
< prusnak>
great, thanks!
< vasild>
prusnak: it would work with anything that provides an I2P SAM proxy
< prusnak>
right, i just didn't know whether i2pd talks SAM
< vasild>
it does, alas some old version 3.1 which is why I limited some of the functionality we use
< vasild>
in 3.2 it is possible to listen for incoming connections concurrently with more than one listener
< vasild>
we don't use that because i2pd only supports sam 3.1
< wumpus>
we could make it optional if the server supports it, that said, it's good to start with basic support like this i think
< vasild>
yeah
< vasild>
I was not sure if the code complexity would be worth it - to support both 3.1 and 3.2
< wumpus>
i think it's already quite impressive what it does (both listening and connecting outwards, automatically, without all the micro-proxy-management we have for Tor)
< wumpus>
it's much more integrated than Tor's control socket
< vasild>
and it is about ok to listen with just one listener - it is not like we expect many incoming connections per second
< wumpus>
right
< vasild>
yes
< vasild>
next - tests
< wumpus>
yes, i wonder if there's a python SAM implementation that we can borrow
< bitcoin-git>
[bitcoin] hebasto opened pull request #21344: build: Fix libbitcoinconsensus cross-compiling for Windows with DEBUG=1 (master...210302-debug) https://github.com/bitcoin/bitcoin/pull/21344