[gui] MarcoFalke merged pull request #248: Fix: For values of "Bytes transferred" and "Bytes/s" with 1000-based prefix names use 1000-based divisor instead of 1024-based (master...binary-prefix) https://github.com/bitcoin-core/gui/pull/248
both the fact that p2p high-level goals still work (transactions propagate etc) and the fact that erlay itself works, down to as much detail as possible
sipa: Right but I'm just thinking of where Erlay could break down and you'd need a specific test for that
michaelfolkson: it could for example work perfectly, but be subtle different from the spec, i a way that makes it (a) useless and not actually saving bandwidth or (b) won't be compatible with other implementations
sipa: Testing subtleties against spec, yeah that's a good one
sure, happy to review beg for 21061 :) there are some outstanding comments I need to address, but approach feedback would be very useful!!
I'm planning to review rebroadcast soon
I think it's also interesting how erlay and traditional relay work together in the transition phase, my intuition says that unexpected things could happen, considering the different time scales.
jnewbery: thanks :)
lightlike: that's a good question, but probably something that's hard to test through automated tests (unless you mean things like it actually failing to propagate at all)
sipa: yes - that's probably something for simulations
more like something to verify in simulations or large deployments
lightlike: yeah I saw your comment earlier.
I can try simulating that too, it's just would be so much better for us if we had an alternative simul stack crafted by non-me :)
I'd appreciate some more review on #21236. It got some attention early on but it seems to have stalled a bit.